From: "Bjørn Mork" <bjorn@mork.no>
To: Hayes Wang <hayeswang@realtek.com>
Cc: <netdev@vger.kernel.org>, <nic_swsd@realtek.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
Oliver Neukum <oliver@neukum.org>
Subject: Re: [PATCH net-next 0/3] r8152: configuration setting
Date: Wed, 07 Sep 2016 15:51:09 +0200 [thread overview]
Message-ID: <87h99rizsi.fsf@miraculix.mork.no> (raw)
In-Reply-To: <1394712342-15778-215-Taiwan-albertk@realtek.com> (Hayes Wang's message of "Wed, 7 Sep 2016 16:12:19 +0800")
[ CCing Oliver, who AFAIK still is the cdc_ether maintainer and should
have the final word on this ]
Hayes Wang <hayeswang@realtek.com> writes:
> Some people prefer to use ECM mode rather than vendor mode. Therefore, I add
> CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB
> configuration value which they want. The default is to support vendor mode
> only.
>
> Hayes Wang (3):
> r8152: check hw version first
> r8152: support ECM mode
> r8152: add CONFIG_RTL8152_CONFIG_VALUE
>
> drivers/net/usb/Kconfig | 13 ++
> drivers/net/usb/r8152.c | 383 +++++++++++++++++++++++++++++++++++++++++-------
> 2 files changed, 345 insertions(+), 51 deletions(-)
So this adds a lot of code to work around the issues you introduced by
unnecessarily blacklisting the CDC ECM configuration earlier, and still
makes the r8152 driver handle the device even in ECM mode.
Sorry, but this is a total mess.
Just remove the completely unnecessary blacklist, and let the cdc_ether
driver handle the device if the user selects the ECM configuration.
That't how the USB system works. There is no need for any code in r8152
to do that.
Ref https://lkml.org/lkml/2014/1/3/57
Bjørn
next prev parent reply other threads:[~2016-09-07 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 8:12 [PATCH net-next 0/3] r8152: configuration setting Hayes Wang
2016-09-07 8:12 ` [PATCH net-next 1/3] r8152: check hw version first Hayes Wang
2016-09-07 8:12 ` [PATCH net-next 2/3] r8152: support ECM mode Hayes Wang
2016-09-18 18:37 ` kbuild test robot
2016-09-19 0:43 ` kbuild test robot
2016-09-07 8:12 ` [PATCH net-next 3/3] r8152: add CONFIG_RTL8152_CONFIG_VALUE Hayes Wang
2016-09-07 13:51 ` Bjørn Mork [this message]
2016-09-08 2:44 ` [PATCH net-next 0/3] r8152: configuration setting Hayes Wang
2016-09-08 7:54 ` Bjørn Mork
2016-09-08 13:02 ` Hayes Wang
2016-09-08 13:08 ` Oliver Neukum
2016-09-08 13:16 ` Bjørn Mork
2016-09-08 0:37 ` David Miller
2016-09-08 3:00 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h99rizsi.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).