From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <salil.mehta@huawei.com>,
<lipeng321@huawei.com>
Subject: Re: [PATCH net-next 3/3] net: hns3: add support for link diagnosis info in debugfs
Date: Thu, 1 Jul 2021 17:03:32 +0800 [thread overview]
Message-ID: <08395721-4ca1-9913-19fd-4d8ec7e41e4b@huawei.com> (raw)
In-Reply-To: <20210624122517.7c8cb329@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2021/6/25 3:25, Jakub Kicinski wrote:
> On Thu, 24 Jun 2021 22:36:45 +0800 Guangbin Huang wrote:
>> In order to know reason why link down, add a debugfs file
>> "link_diagnosis_info" to get link faults from firmware, and each bit
>> represents one kind of fault.
>>
>> usage example:
>> $ cat link_diagnosis_info
>> Reference clock lost
>
> Please use ethtool->get_link_ext_state instead.
> .
>
Hi Jakub, I have a question to consult you.
Some fault information in our patch are not existed in current ethtool extended
link states, for examples:
"Serdes reference clock lost"
"Serdes analog loss of signal"
"SFP tx is disabled"
"PHY power down"
"Remote fault"
Do you think these fault information can be added to ethtool extended link states?
Thanks,
Guangbin
.
next prev parent reply other threads:[~2021-07-01 9:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 14:36 [PATCH net-next 0/3] net: hns3: add new debugfs commands Guangbin Huang
2021-06-24 14:36 ` [PATCH net-next 1/3] net: hns3: add support for FD counter in debugfs Guangbin Huang
2021-06-24 14:36 ` [PATCH net-next 2/3] net: hns3: add support for dumping MAC umv " Guangbin Huang
2021-06-24 14:36 ` [PATCH net-next 3/3] net: hns3: add support for link diagnosis info " Guangbin Huang
2021-06-24 19:25 ` Jakub Kicinski
2021-06-25 7:08 ` huangguangbin (A)
2021-07-01 9:03 ` huangguangbin (A) [this message]
2021-07-01 15:54 ` Jakub Kicinski
2021-07-04 1:37 ` huangguangbin (A)
2021-07-04 19:57 ` Andrew Lunn
2021-07-05 1:12 ` huangguangbin (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08395721-4ca1-9913-19fd-4d8ec7e41e4b@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).