From: "Rafał Miłecki" <rafal@milecki.pl>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: INAGAKI Hiroshi <musashino.open@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values
Date: Mon, 09 Jan 2023 10:52:33 +0100 [thread overview]
Message-ID: <0857740baa7bd7fd2c3f5ff5a5cb911b@milecki.pl> (raw)
In-Reply-To: <d0df69da-e881-46aa-da51-eb3b610dee57@linaro.org>
On 2023-01-09 10:48, Srinivas Kandagatla wrote:
> On 06/01/2023 19:15, Rafał Miłecki wrote:
>> On 2022-11-11 18:41, Srinivas Kandagatla wrote:
>>> On 12/10/2022 16:51, INAGAKI Hiroshi wrote:
>>>> This patch fixes crc32 error on Big-Endianness system by conversion
>>>> of
>>>> calculated crc32 value.
>>>>
>>>> Little-Endianness system:
>>>>
>>>> obtained crc32: Little
>>>> calculated crc32: Little
>>>>
>>>> Big-Endianness system:
>>>>
>>>> obtained crc32: Little
>>>> calculated crc32: Big
>>>>
>>>> log (APRESIA ApresiaLightGS120GT-SS, RTL8382M, Big-Endianness):
>>>>
>>>> [ 8.570000] u_boot_env
>>>> 18001200.spi:flash@0:partitions:partition@c0000: Invalid calculated
>>>> CRC32: 0x88cd6f09 (expected: 0x096fcd88)
>>>> [ 8.580000] u_boot_env: probe of
>>>> 18001200.spi:flash@0:partitions:partition@c0000 failed with error
>>>> -22
>>>>
>>>> Fixes: f955dc1445069 ("nvmem: add driver handling U-Boot environment
>>>> variables")
>>>>
>>>> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
>>>> ---
>>>
>>> Applied thanks,
>>
>> has this patch been lost somewhere in the process?
>>
>> I'm quite sure I saw it in linux-next.git and probably in nvmem.git.
>> Now
>> it seems to be gone.
> Yes, I had to revert this one as next reported sparse warnings [1]
> with this patch which were not addressed.
I missed that, thank you.
INAGAKI: could you take a look at this, please?
next prev parent reply other threads:[~2023-01-09 10:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:51 [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values INAGAKI Hiroshi
2022-10-17 8:43 ` Rafał Miłecki
2022-11-04 16:43 ` Christian Lamparter
2022-11-11 17:41 ` Srinivas Kandagatla
2023-01-06 19:15 ` Rafał Miłecki
2023-01-09 9:48 ` Srinivas Kandagatla
2023-01-09 9:52 ` Rafał Miłecki [this message]
2023-01-10 13:04 ` INAGAKI Hiroshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0857740baa7bd7fd2c3f5ff5a5cb911b@milecki.pl \
--to=rafal@milecki.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=musashino.open@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).