From: INAGAKI Hiroshi <musashino.open@gmail.com>
To: rafal@milecki.pl, srinivas.kandagatla@linaro.org
Cc: linux-kernel@vger.kernel.org, INAGAKI Hiroshi <musashino.open@gmail.com>
Subject: [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values
Date: Thu, 13 Oct 2022 00:51:33 +0900 [thread overview]
Message-ID: <20221012155133.287-1-musashino.open@gmail.com> (raw)
This patch fixes crc32 error on Big-Endianness system by conversion of
calculated crc32 value.
Little-Endianness system:
obtained crc32: Little
calculated crc32: Little
Big-Endianness system:
obtained crc32: Little
calculated crc32: Big
log (APRESIA ApresiaLightGS120GT-SS, RTL8382M, Big-Endianness):
[ 8.570000] u_boot_env 18001200.spi:flash@0:partitions:partition@c0000: Invalid calculated CRC32: 0x88cd6f09 (expected: 0x096fcd88)
[ 8.580000] u_boot_env: probe of 18001200.spi:flash@0:partitions:partition@c0000 failed with error -22
Fixes: f955dc1445069 ("nvmem: add driver handling U-Boot environment variables")
Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
---
v1 -> v2
- add missing cast to __le32 for calculated crc32
(reported by kernel test robot <lkp@intel.com>)
- add missing "Fixes:" tag
drivers/nvmem/u-boot-env.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/u-boot-env.c b/drivers/nvmem/u-boot-env.c
index 8e72d1bbd649..b5aacf805fc6 100644
--- a/drivers/nvmem/u-boot-env.c
+++ b/drivers/nvmem/u-boot-env.c
@@ -143,7 +143,7 @@ static int u_boot_env_parse(struct u_boot_env *priv)
crc32_data_len = priv->mtd->size - crc32_data_offset;
data_len = priv->mtd->size - data_offset;
- calc = crc32(~0, buf + crc32_data_offset, crc32_data_len) ^ ~0L;
+ calc = le32_to_cpu((__le32)crc32(~0, buf + crc32_data_offset, crc32_data_len) ^ ~0L);
if (calc != crc32) {
dev_err(dev, "Invalid calculated CRC32: 0x%08x (expected: 0x%08x)\n", calc, crc32);
err = -EINVAL;
base-commit: 60bbaad38109684b156e21112322e0a922f92cde
--
2.25.1
next reply other threads:[~2022-10-12 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:51 INAGAKI Hiroshi [this message]
2022-10-17 8:43 ` [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values Rafał Miłecki
2022-11-04 16:43 ` Christian Lamparter
2022-11-11 17:41 ` Srinivas Kandagatla
2023-01-06 19:15 ` Rafał Miłecki
2023-01-09 9:48 ` Srinivas Kandagatla
2023-01-09 9:52 ` Rafał Miłecki
2023-01-10 13:04 ` INAGAKI Hiroshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221012155133.287-1-musashino.open@gmail.com \
--to=musashino.open@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).