From: Christian Lamparter <christian.lamparter@isd.uni-stuttgart.de>
To: INAGAKI Hiroshi <musashino.open@gmail.com>,
rafal@milecki.pl, srinivas.kandagatla@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values
Date: Fri, 4 Nov 2022 17:43:33 +0100 [thread overview]
Message-ID: <e7ebabf9-a7b2-6155-cdd0-5dafb6bb2a7a@isd.uni-stuttgart.de> (raw)
In-Reply-To: <20221012155133.287-1-musashino.open@gmail.com>
On 10/12/22 17:51, INAGAKI Hiroshi wrote:
> This patch fixes crc32 error on Big-Endianness system by conversion of
> calculated crc32 value.
>
> Little-Endianness system:
>
> obtained crc32: Little
> calculated crc32: Little
>
> Big-Endianness system:
>
> obtained crc32: Little
> calculated crc32: Big
>
> log (APRESIA ApresiaLightGS120GT-SS, RTL8382M, Big-Endianness):
>
> [ 8.570000] u_boot_env 18001200.spi:flash@0:partitions:partition@c0000: Invalid calculated CRC32: 0x88cd6f09 (expected: 0x096fcd88)
> [ 8.580000] u_boot_env: probe of 18001200.spi:flash@0:partitions:partition@c0000 failed with error -22
>
> Fixes: f955dc1445069 ("nvmem: add driver handling U-Boot environment variables")
>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
Tested-by: Christian Lamparter <chunkeey@gmail.com> # PowerPC/MyBookLive
next prev parent reply other threads:[~2022-11-04 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:51 [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values INAGAKI Hiroshi
2022-10-17 8:43 ` Rafał Miłecki
2022-11-04 16:43 ` Christian Lamparter [this message]
2022-11-11 17:41 ` Srinivas Kandagatla
2023-01-06 19:15 ` Rafał Miłecki
2023-01-09 9:48 ` Srinivas Kandagatla
2023-01-09 9:52 ` Rafał Miłecki
2023-01-10 13:04 ` INAGAKI Hiroshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7ebabf9-a7b2-6155-cdd0-5dafb6bb2a7a@isd.uni-stuttgart.de \
--to=christian.lamparter@isd.uni-stuttgart.de \
--cc=linux-kernel@vger.kernel.org \
--cc=musashino.open@gmail.com \
--cc=rafal@milecki.pl \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).