* [PATCH 0/8] ARM: dts: Switch to new DSA binding
@ 2017-01-02 2:22 Florian Fainelli
2017-01-02 2:22 ` [PATCH 1/8] ARM: dts: armada-370-rd: Utilize " Florian Fainelli
` (8 more replies)
0 siblings, 9 replies; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi all,
This patch series converts the in-tree users to utilize the new (relatively)
DSA binding that was introduced with commit 8c5ad1d6179d ("net: dsa: Document
new binding"). The legacy binding node is kept included, but is marked
disabled.
In about 2-3 releases we may consider removing the old DSA binding entirely
from the kernel.
Thank you!
Florian Fainelli (8):
ARM: dts: armada-370-rd: Utilize new DSA binding
ARM: dts: armada-38x: Utilize new DSA binding
ARM: dts: armada-388-clearfog: Utilize new DSA binding
ARM: dts: armada-xp-linksys-mamba: Utilize new DSA binding
ARM: dts: kirkwood-dir665: Utilize new DSA binding
ARM: dts: kirkwood-linksys-viper: Utilize new DSA binding
ARM: dts: kirkwood-mv88f6281gtw-ge: Utilize new DSA binding
ARM: dts: kirkwood-rd88f6281: Utilize new DSA binding
arch/arm/boot/dts/armada-370-rd.dts | 44 +++++++++++++++++
arch/arm/boot/dts/armada-385-linksys.dtsi | 52 ++++++++++++++++++++-
arch/arm/boot/dts/armada-388-clearfog.dts | 65 ++++++++++++++++++++++++++
arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 53 +++++++++++++++++++++
arch/arm/boot/dts/kirkwood-dir665.dts | 49 +++++++++++++++++++
arch/arm/boot/dts/kirkwood-linksys-viper.dts | 49 +++++++++++++++++++
arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 49 +++++++++++++++++++
arch/arm/boot/dts/kirkwood-rd88f6281-z0.dts | 11 +++++
arch/arm/boot/dts/kirkwood-rd88f6281.dtsi | 44 +++++++++++++++++
9 files changed, 415 insertions(+), 1 deletion(-)
--
2.9.3
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/8] ARM: dts: armada-370-rd: Utilize new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
@ 2017-01-02 2:22 ` Florian Fainelli
2017-01-03 16:36 ` Andrew Lunn
2017-01-02 2:22 ` [PATCH 2/8] ARM: dts: armada-38x: " Florian Fainelli
` (7 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
Document new binding"). The legacy binding node is kept included, but is marked
disabled.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/armada-370-rd.dts | 44 +++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/boot/dts/armada-370-rd.dts b/arch/arm/boot/dts/armada-370-rd.dts
index c3fd6e49212f..9c6e924ac0b3 100644
--- a/arch/arm/boot/dts/armada-370-rd.dts
+++ b/arch/arm/boot/dts/armada-370-rd.dts
@@ -173,6 +173,8 @@
};
dsa {
+ status = "disabled";
+
compatible = "marvell,dsa";
#address-cells = <2>;
#size-cells = <0>;
@@ -235,6 +237,48 @@
phy0: ethernet-phy@0 {
reg = <0>;
};
+
+ switch: switch@10 {
+ compatible = "marvell,mv88e6085";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <16>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan0";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "lan1";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "lan2";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "lan3";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <ð1>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
};
--
2.9.3
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 2/8] ARM: dts: armada-38x: Utilize new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
2017-01-02 2:22 ` [PATCH 1/8] ARM: dts: armada-370-rd: Utilize " Florian Fainelli
@ 2017-01-02 2:22 ` Florian Fainelli
2017-01-03 16:14 ` Gregory CLEMENT
2017-01-02 2:22 ` [PATCH 3/8] ARM: dts: armada-388-clearfog: " Florian Fainelli
` (6 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
Document new binding"). The legacy binding node is kept included, but is marked
disabled.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/armada-385-linksys.dtsi | 52 ++++++++++++++++++++++++++++++-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
index 8f0e508f64ae..20d5e8b00f2d 100644
--- a/arch/arm/boot/dts/armada-385-linksys.dtsi
+++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
@@ -103,8 +103,56 @@
};
};
- mdio {
+ mdio@72004 {
status = "okay";
+
+ switch@0 {
+ compatible = "marvell,mv88e6095";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan4";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "lan3";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "lan2";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "lan1";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "wan";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <ð2>;
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
};
sata@a8000 {
@@ -261,6 +309,8 @@
};
dsa@0 {
+ status = "disabled";
+
compatible = "marvell,dsa";
#address-cells = <2>;
#size-cells = <0>;
--
2.9.3
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
2017-01-02 2:22 ` [PATCH 1/8] ARM: dts: armada-370-rd: Utilize " Florian Fainelli
2017-01-02 2:22 ` [PATCH 2/8] ARM: dts: armada-38x: " Florian Fainelli
@ 2017-01-02 2:22 ` Florian Fainelli
2017-01-02 8:59 ` Neil Armstrong
2017-01-04 17:23 ` Gregory CLEMENT
2017-01-02 2:22 ` [PATCH 4/8] ARM: dts: armada-xp-linksys-mamba: " Florian Fainelli
` (5 subsequent siblings)
8 siblings, 2 replies; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
dsa: Document new binding"). The legacy binding node is kept included, but is
marked disabled.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/armada-388-clearfog.dts | 65 +++++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)
diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts
index 71ce201c903e..35207aa1f4ec 100644
--- a/arch/arm/boot/dts/armada-388-clearfog.dts
+++ b/arch/arm/boot/dts/armada-388-clearfog.dts
@@ -351,6 +351,8 @@
};
dsa@0 {
+ status = "okay";
+
compatible = "marvell,dsa";
dsa,ethernet = <ð1>;
dsa,mii-bus = <&mdio>;
@@ -444,3 +446,66 @@
status = "disabled";
};
};
+
+&mdio {
+ status = "okay";
+
+ switch@4 {
+ compatible = "marvell,mv88e6085";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <4>;
+ pinctrl-0 = <&clearfog_dsa0_clk_pins &clearfog_dsa0_pins>;
+ pinctrl-names = "default";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan5";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "lan4";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "lan2";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "lan1";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <ð1>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+
+ port@6 {
+ /* 88E1512 external phy */
+ reg = <6>;
+ label = "lan6";
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
+};
--
2.9.3
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 4/8] ARM: dts: armada-xp-linksys-mamba: Utilize new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
` (2 preceding siblings ...)
2017-01-02 2:22 ` [PATCH 3/8] ARM: dts: armada-388-clearfog: " Florian Fainelli
@ 2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 5/8] ARM: dts: kirkwood-dir665: " Florian Fainelli
` (4 subsequent siblings)
8 siblings, 0 replies; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
Document new binding"). The legacy binding node is kept included, but is marked
disabled.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 53 +++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
index 83ac884c0f8a..42ea8764814c 100644
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
@@ -302,6 +302,8 @@
};
dsa {
+ status = "disabled";
+
compatible = "marvell,dsa";
#address-cells = <2>;
#size-cells = <0>;
@@ -398,3 +400,54 @@
spi-max-frequency = <40000000>;
};
};
+
+&mdio {
+ status = "okay";
+
+ switch@0 {
+ compatible = "marvell,mv88e6085";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan4";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "lan3";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "lan2";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "lan1";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "internet";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <ð0>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
+};
--
2.9.3
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 5/8] ARM: dts: kirkwood-dir665: Utilize new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
` (3 preceding siblings ...)
2017-01-02 2:22 ` [PATCH 4/8] ARM: dts: armada-xp-linksys-mamba: " Florian Fainelli
@ 2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 6/8] ARM: dts: kirkwood-linksys-viper: " Florian Fainelli
` (3 subsequent siblings)
8 siblings, 0 replies; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
Document new binding"). The legacy binding node is kept included, but is marked
disabled.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/kirkwood-dir665.dts | 49 +++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-dir665.dts b/arch/arm/boot/dts/kirkwood-dir665.dts
index 41acbb6dd6ab..4d2b15d6244a 100644
--- a/arch/arm/boot/dts/kirkwood-dir665.dts
+++ b/arch/arm/boot/dts/kirkwood-dir665.dts
@@ -194,6 +194,8 @@
};
dsa {
+ status = "disabled";
+
compatible = "marvell,dsa";
#address-cells = <2>;
#size-cells = <0>;
@@ -241,6 +243,53 @@
&mdio {
status = "okay";
+
+ switch@0 {
+ compatible = "marvell,mv88e6085";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan4";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "lan3";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "lan2";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "lan1";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "wan";
+ };
+
+ port@6 {
+ reg = <6>;
+ label = "cpu";
+ ethernet = <ð0port>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
};
/* eth0 is connected to a Marvell 88E6171 switch, without a PHY. So set
--
2.9.3
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 6/8] ARM: dts: kirkwood-linksys-viper: Utilize new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
` (4 preceding siblings ...)
2017-01-02 2:22 ` [PATCH 5/8] ARM: dts: kirkwood-dir665: " Florian Fainelli
@ 2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 7/8] ARM: dts: kirkwood-mv88f6281gtw-ge: " Florian Fainelli
` (2 subsequent siblings)
8 siblings, 0 replies; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
Document new binding"). The legacy binding node is kept included, but is marked
disabled.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/kirkwood-linksys-viper.dts | 49 ++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-linksys-viper.dts b/arch/arm/boot/dts/kirkwood-linksys-viper.dts
index 345fcac48dc7..df7851820507 100644
--- a/arch/arm/boot/dts/kirkwood-linksys-viper.dts
+++ b/arch/arm/boot/dts/kirkwood-linksys-viper.dts
@@ -70,6 +70,8 @@
};
dsa {
+ status = "disabled";
+
compatible = "marvell,dsa";
#address-cells = <2>;
#size-cells = <0>;
@@ -207,6 +209,53 @@
&mdio {
status = "okay";
+
+ switch@10 {
+ compatible = "marvell,mv88e6085";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <16>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "ethernet1";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "ethernet2";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "ethernet3";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "ethernet4";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "internet";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <ð0port>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
};
&uart0 {
--
2.9.3
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 7/8] ARM: dts: kirkwood-mv88f6281gtw-ge: Utilize new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
` (5 preceding siblings ...)
2017-01-02 2:22 ` [PATCH 6/8] ARM: dts: kirkwood-linksys-viper: " Florian Fainelli
@ 2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 8/8] ARM: dts: kirkwood-rd88f6281: " Florian Fainelli
2017-01-03 16:19 ` [PATCH 0/8] ARM: dts: Switch to " Gregory CLEMENT
8 siblings, 0 replies; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
Document new binding"). The legacy binding node is kept included, but is marked
disabled.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 49 ++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
index 172a38c0b8a9..5622115158ab 100644
--- a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
+++ b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
@@ -112,6 +112,8 @@
};
dsa {
+ status = "disabled";
+
compatible = "marvell,dsa";
#address-cells = <1>;
#size-cells = <0>;
@@ -159,6 +161,53 @@
&mdio {
status = "okay";
+
+ switch@0 {
+ compatible = "marvell,mv88e6085";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan1";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "lan2";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "lan4";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "wan";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <ð0port>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
};
ð0 {
--
2.9.3
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 8/8] ARM: dts: kirkwood-rd88f6281: Utilize new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
` (6 preceding siblings ...)
2017-01-02 2:22 ` [PATCH 7/8] ARM: dts: kirkwood-mv88f6281gtw-ge: " Florian Fainelli
@ 2017-01-02 2:22 ` Florian Fainelli
2017-01-03 16:19 ` [PATCH 0/8] ARM: dts: Switch to " Gregory CLEMENT
8 siblings, 0 replies; 22+ messages in thread
From: Florian Fainelli @ 2017-01-02 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: vivien.didelot, Florian Fainelli, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
Document new binding"). The legacy binding node is kept included, but is marked
disabled.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/kirkwood-rd88f6281-z0.dts | 11 ++++++++
arch/arm/boot/dts/kirkwood-rd88f6281.dtsi | 44 +++++++++++++++++++++++++++++
2 files changed, 55 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-rd88f6281-z0.dts b/arch/arm/boot/dts/kirkwood-rd88f6281-z0.dts
index 1a797381d3d4..57cfcc2941cd 100644
--- a/arch/arm/boot/dts/kirkwood-rd88f6281-z0.dts
+++ b/arch/arm/boot/dts/kirkwood-rd88f6281-z0.dts
@@ -33,3 +33,14 @@
ð1 {
status = "disabled";
};
+
+&switch {
+ reg = <0>;
+
+ ports {
+ port@4 {
+ reg = <4>;
+ label = "wan";
+ };
+ };
+};
diff --git a/arch/arm/boot/dts/kirkwood-rd88f6281.dtsi b/arch/arm/boot/dts/kirkwood-rd88f6281.dtsi
index d5aacf137e40..91f5da5dae5f 100644
--- a/arch/arm/boot/dts/kirkwood-rd88f6281.dtsi
+++ b/arch/arm/boot/dts/kirkwood-rd88f6281.dtsi
@@ -54,6 +54,8 @@
};
dsa {
+ status = "disabled";
+
compatible = "marvell,dsa";
#address-cells = <2>;
#size-cells = <0>;
@@ -115,6 +117,48 @@
&mdio {
status = "okay";
+
+ switch: switch@0 {
+ compatible = "marvell,mv88e6085";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan1";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "lan2";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "lan4";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <ð0port>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+
+ };
+ };
};
ð0 {
--
2.9.3
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
2017-01-02 2:22 ` [PATCH 3/8] ARM: dts: armada-388-clearfog: " Florian Fainelli
@ 2017-01-02 8:59 ` Neil Armstrong
2017-01-04 17:23 ` Gregory CLEMENT
1 sibling, 0 replies; 22+ messages in thread
From: Neil Armstrong @ 2017-01-02 8:59 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel
Cc: Mark Rutland, Andrew Lunn, Jason Cooper, vivien.didelot,
Russell King, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Gregory Clement, Sebastian Hesselbarth
Hi Florian,
On 01/02/2017 03:22 AM, Florian Fainelli wrote:
> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
> dsa: Document new binding"). The legacy binding node is kept included, but is
> marked disabled.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/armada-388-clearfog.dts | 65 +++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts
> index 71ce201c903e..35207aa1f4ec 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dts
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dts
> @@ -351,6 +351,8 @@
> };
>
> dsa@0 {
> + status = "okay";
I think you wanted "disabled" here !
> +
> compatible = "marvell,dsa";
> dsa,ethernet = <ð1>;
> dsa,mii-bus = <&mdio>;
> @@ -444,3 +446,66 @@
> status = "disabled";
> };
> };
[...]
Neil
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 2/8] ARM: dts: armada-38x: Utilize new DSA binding
2017-01-02 2:22 ` [PATCH 2/8] ARM: dts: armada-38x: " Florian Fainelli
@ 2017-01-03 16:14 ` Gregory CLEMENT
0 siblings, 0 replies; 22+ messages in thread
From: Gregory CLEMENT @ 2017-01-03 16:14 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, vivien.didelot, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Florian,
You should use the board name in the topic, ie:
"ARM: dts: armada-385-linksys: Utilize new DSA binding"
Thanks,
Gregory
On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa:
> Document new binding"). The legacy binding node is kept included, but is marked
> disabled.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/armada-385-linksys.dtsi | 52 ++++++++++++++++++++++++++++++-
> 1 file changed, 51 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
> index 8f0e508f64ae..20d5e8b00f2d 100644
> --- a/arch/arm/boot/dts/armada-385-linksys.dtsi
> +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
> @@ -103,8 +103,56 @@
> };
> };
>
> - mdio {
> + mdio@72004 {
> status = "okay";
> +
> + switch@0 {
> + compatible = "marvell,mv88e6095";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + label = "lan4";
> + };
> +
> + port@1 {
> + reg = <1>;
> + label = "lan3";
> + };
> +
> + port@2 {
> + reg = <2>;
> + label = "lan2";
> + };
> +
> + port@3 {
> + reg = <3>;
> + label = "lan1";
> + };
> +
> + port@4 {
> + reg = <4>;
> + label = "wan";
> + };
> +
> + port@5 {
> + reg = <5>;
> + label = "cpu";
> + ethernet = <ð2>;
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + };
> + };
> };
>
> sata@a8000 {
> @@ -261,6 +309,8 @@
> };
>
> dsa@0 {
> + status = "disabled";
> +
> compatible = "marvell,dsa";
> #address-cells = <2>;
> #size-cells = <0>;
> --
> 2.9.3
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/8] ARM: dts: Switch to new DSA binding
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
` (7 preceding siblings ...)
2017-01-02 2:22 ` [PATCH 8/8] ARM: dts: kirkwood-rd88f6281: " Florian Fainelli
@ 2017-01-03 16:19 ` Gregory CLEMENT
2017-01-03 16:32 ` Andrew Lunn
8 siblings, 1 reply; 22+ messages in thread
From: Gregory CLEMENT @ 2017-01-03 16:19 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, vivien.didelot, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Florian,
On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> Hi all,
>
> This patch series converts the in-tree users to utilize the new (relatively)
> DSA binding that was introduced with commit 8c5ad1d6179d ("net: dsa: Document
> new binding"). The legacy binding node is kept included, but is marked
> disabled.
>
> In about 2-3 releases we may consider removing the old DSA binding entirely
> from the kernel.
The series looks OK. However I would like to have a reviewed by from
Andrew who know well the mvebu platform and the DSA subsystem.
Also there's few fixes needed for the v2.
Thanks,
Gregory
>
> Thank you!
>
> Florian Fainelli (8):
> ARM: dts: armada-370-rd: Utilize new DSA binding
> ARM: dts: armada-38x: Utilize new DSA binding
> ARM: dts: armada-388-clearfog: Utilize new DSA binding
> ARM: dts: armada-xp-linksys-mamba: Utilize new DSA binding
> ARM: dts: kirkwood-dir665: Utilize new DSA binding
> ARM: dts: kirkwood-linksys-viper: Utilize new DSA binding
> ARM: dts: kirkwood-mv88f6281gtw-ge: Utilize new DSA binding
> ARM: dts: kirkwood-rd88f6281: Utilize new DSA binding
>
> arch/arm/boot/dts/armada-370-rd.dts | 44 +++++++++++++++++
> arch/arm/boot/dts/armada-385-linksys.dtsi | 52 ++++++++++++++++++++-
> arch/arm/boot/dts/armada-388-clearfog.dts | 65 ++++++++++++++++++++++++++
> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 53 +++++++++++++++++++++
> arch/arm/boot/dts/kirkwood-dir665.dts | 49 +++++++++++++++++++
> arch/arm/boot/dts/kirkwood-linksys-viper.dts | 49 +++++++++++++++++++
> arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 49 +++++++++++++++++++
> arch/arm/boot/dts/kirkwood-rd88f6281-z0.dts | 11 +++++
> arch/arm/boot/dts/kirkwood-rd88f6281.dtsi | 44 +++++++++++++++++
> 9 files changed, 415 insertions(+), 1 deletion(-)
>
> --
> 2.9.3
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/8] ARM: dts: Switch to new DSA binding
2017-01-03 16:19 ` [PATCH 0/8] ARM: dts: Switch to " Gregory CLEMENT
@ 2017-01-03 16:32 ` Andrew Lunn
0 siblings, 0 replies; 22+ messages in thread
From: Andrew Lunn @ 2017-01-03 16:32 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Florian Fainelli, linux-arm-kernel, vivien.didelot, Jason Cooper,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
> The series looks OK. However I would like to have a reviewed by from
> Andrew who know well the mvebu platform and the DSA subsystem.
Hi Gregory
Yes, i was planning on reviewing, and testing on at least three of
these platforms.
Since this is mvebu/arm-soc and not netdev, i may take a week or so
before i get around to it. netdev is too fast some times.
Andrew
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/8] ARM: dts: armada-370-rd: Utilize new DSA binding
2017-01-02 2:22 ` [PATCH 1/8] ARM: dts: armada-370-rd: Utilize " Florian Fainelli
@ 2017-01-03 16:36 ` Andrew Lunn
2017-01-04 17:30 ` Florian Fainelli
0 siblings, 1 reply; 22+ messages in thread
From: Andrew Lunn @ 2017-01-03 16:36 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, vivien.didelot, Jason Cooper, Gregory Clement,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
> +
> + switch: switch@10 {
> + compatible = "marvell,mv88e6085";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <16>;
Hummm, a device tree question. switch@10, reg = <16>. Is there an
implicit understanding that the 10 is hex?
Andrew
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
2017-01-02 2:22 ` [PATCH 3/8] ARM: dts: armada-388-clearfog: " Florian Fainelli
2017-01-02 8:59 ` Neil Armstrong
@ 2017-01-04 17:23 ` Gregory CLEMENT
2017-01-04 17:27 ` Florian Fainelli
1 sibling, 1 reply; 22+ messages in thread
From: Gregory CLEMENT @ 2017-01-04 17:23 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, vivien.didelot, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Florian,
On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
> dsa: Document new binding"). The legacy binding node is kept included, but is
> marked disabled.
>
I tested this patch on mvebu/dt (I needed to reduce the context to apply
the patch due to the changes made by Russell King on this file). I also
set the status of the old binding to "disable" (instead of "okay").
It seems to work with the limited test did:
ifconfig eth1 up
udhcpc -i lan1
iperf -c mylaptop
(same for lan4)
However is there a way to be sure that the new binding is used?
Gregory
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/armada-388-clearfog.dts | 65 +++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts
> index 71ce201c903e..35207aa1f4ec 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dts
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dts
> @@ -351,6 +351,8 @@
> };
>
> dsa@0 {
> + status = "okay";
> +
> compatible = "marvell,dsa";
> dsa,ethernet = <ð1>;
> dsa,mii-bus = <&mdio>;
> @@ -444,3 +446,66 @@
> status = "disabled";
> };
> };
> +
> +&mdio {
> + status = "okay";
> +
> + switch@4 {
> + compatible = "marvell,mv88e6085";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <4>;
> + pinctrl-0 = <&clearfog_dsa0_clk_pins &clearfog_dsa0_pins>;
> + pinctrl-names = "default";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + label = "lan5";
> + };
> +
> + port@1 {
> + reg = <1>;
> + label = "lan4";
> + };
> +
> + port@2 {
> + reg = <2>;
> + label = "lan3";
> + };
> +
> + port@3 {
> + reg = <3>;
> + label = "lan2";
> + };
> +
> + port@4 {
> + reg = <4>;
> + label = "lan1";
> + };
> +
> + port@5 {
> + reg = <5>;
> + label = "cpu";
> + ethernet = <ð1>;
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> +
> + port@6 {
> + /* 88E1512 external phy */
> + reg = <6>;
> + label = "lan6";
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + };
> + };
> +};
> --
> 2.9.3
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
2017-01-04 17:23 ` Gregory CLEMENT
@ 2017-01-04 17:27 ` Florian Fainelli
2017-01-04 17:38 ` Vivien Didelot
2017-01-05 12:55 ` Gregory CLEMENT
0 siblings, 2 replies; 22+ messages in thread
From: Florian Fainelli @ 2017-01-04 17:27 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: linux-arm-kernel, vivien.didelot, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
> Hi Florian,
>
> On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>> dsa: Document new binding"). The legacy binding node is kept included, but is
>> marked disabled.
>>
>
> I tested this patch on mvebu/dt (I needed to reduce the context to apply
> the patch due to the changes made by Russell King on this file). I also
> set the status of the old binding to "disable" (instead of "okay").
Yes, that needs fixing, thanks for mentioning that.
>
> It seems to work with the limited test did:
> ifconfig eth1 up
> udhcpc -i lan1
> iperf -c mylaptop
>
> (same for lan4)
>
> However is there a way to be sure that the new binding is used?
The best way is probably to make sure that your switch device appears
parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
Alternatively, if you see a message like:
DSA: switch 0 0 parsed
in your dmesg, that would also be indicative of using the new binding
and corresponding code.
Thanks a lot for trying that out!
--
Florian
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/8] ARM: dts: armada-370-rd: Utilize new DSA binding
2017-01-03 16:36 ` Andrew Lunn
@ 2017-01-04 17:30 ` Florian Fainelli
2017-01-05 9:41 ` Gregory CLEMENT
0 siblings, 1 reply; 22+ messages in thread
From: Florian Fainelli @ 2017-01-04 17:30 UTC (permalink / raw)
To: Andrew Lunn
Cc: linux-arm-kernel, vivien.didelot, Jason Cooper, Gregory Clement,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 01/03/2017 08:36 AM, Andrew Lunn wrote:
>> +
>> + switch: switch@10 {
>> + compatible = "marvell,mv88e6085";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <16>;
>
> Hummm, a device tree question. switch@10, reg = <16>. Is there an
> implicit understanding that the 10 is hex?
Most (if not all?) unit addresses are hexadecimal, which is why this was
chosen here, but I really don't mind changing that.
--
Florian
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
2017-01-04 17:27 ` Florian Fainelli
@ 2017-01-04 17:38 ` Vivien Didelot
2017-01-04 17:42 ` Andrew Lunn
2017-01-05 12:55 ` Gregory CLEMENT
1 sibling, 1 reply; 22+ messages in thread
From: Vivien Didelot @ 2017-01-04 17:38 UTC (permalink / raw)
To: Florian Fainelli, Gregory CLEMENT
Cc: linux-arm-kernel, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Florian, All,
Florian Fainelli <f.fainelli@gmail.com> writes:
>> However is there a way to be sure that the new binding is used?
>
> The best way is probably to make sure that your switch device appears
> parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
> Alternatively, if you see a message like:
>
> DSA: switch 0 0 parsed
>
> in your dmesg, that would also be indicative of using the new binding
> and corresponding code.
That makes me think that we should either remove, or use different
values for the version described in net/dsa/dsa.c:
char dsa_driver_version[] = "0.1";
Today this is absolutely useless and erroneous.
Thanks,
Vivien
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
2017-01-04 17:38 ` Vivien Didelot
@ 2017-01-04 17:42 ` Andrew Lunn
2017-01-04 17:48 ` Vivien Didelot
0 siblings, 1 reply; 22+ messages in thread
From: Andrew Lunn @ 2017-01-04 17:42 UTC (permalink / raw)
To: Vivien Didelot
Cc: Florian Fainelli, Gregory CLEMENT, linux-arm-kernel,
Jason Cooper, Sebastian Hesselbarth, Rob Herring, Mark Rutland,
Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
> That makes me think that we should either remove, or use different
> values for the version described in net/dsa/dsa.c:
>
> char dsa_driver_version[] = "0.1";
>
> Today this is absolutely useless and erroneous.
I think it has been useless for over 9 years.
Feel free to remove it.
Andrew
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
2017-01-04 17:42 ` Andrew Lunn
@ 2017-01-04 17:48 ` Vivien Didelot
0 siblings, 0 replies; 22+ messages in thread
From: Vivien Didelot @ 2017-01-04 17:48 UTC (permalink / raw)
To: Andrew Lunn
Cc: Florian Fainelli, Gregory CLEMENT, linux-arm-kernel,
Jason Cooper, Sebastian Hesselbarth, Rob Herring, Mark Rutland,
Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
>> That makes me think that we should either remove, or use different
>> values for the version described in net/dsa/dsa.c:
>>
>> char dsa_driver_version[] = "0.1";
>>
>> Today this is absolutely useless and erroneous.
>
> I think it has been useless for over 9 years.
Do we want to get rid of it, or do we want to have a string version per
DSA implementation? (old vs. new bindings).
I don't like the actual way to distinguish between the two (grep'ing
dmesg as Florian shown). Maybe a pr_info in dsa2.c would be enough to
inform about DSA "v2". What do you guys prefer?
Thanks,
Vivien
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/8] ARM: dts: armada-370-rd: Utilize new DSA binding
2017-01-04 17:30 ` Florian Fainelli
@ 2017-01-05 9:41 ` Gregory CLEMENT
0 siblings, 0 replies; 22+ messages in thread
From: Gregory CLEMENT @ 2017-01-05 9:41 UTC (permalink / raw)
To: Florian Fainelli
Cc: Andrew Lunn, linux-arm-kernel, vivien.didelot, Jason Cooper,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Florian,
On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 01/03/2017 08:36 AM, Andrew Lunn wrote:
>>> +
>>> + switch: switch@10 {
>>> + compatible = "marvell,mv88e6085";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + reg = <16>;
>>
>> Hummm, a device tree question. switch@10, reg = <16>. Is there an
>> implicit understanding that the 10 is hex?
>
> Most (if not all?) unit addresses are hexadecimal, which is why this was
> chosen here, but I really don't mind changing that.
And what about using:
reg = <0x10>;
Gregory
> --
> Florian
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
2017-01-04 17:27 ` Florian Fainelli
2017-01-04 17:38 ` Vivien Didelot
@ 2017-01-05 12:55 ` Gregory CLEMENT
1 sibling, 0 replies; 22+ messages in thread
From: Gregory CLEMENT @ 2017-01-05 12:55 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, vivien.didelot, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Florian,
On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
>> Hi Florian,
>>
>> On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>>> dsa: Document new binding"). The legacy binding node is kept included, but is
>>> marked disabled.
>>>
>>
>> I tested this patch on mvebu/dt (I needed to reduce the context to apply
>> the patch due to the changes made by Russell King on this file). I also
>> set the status of the old binding to "disable" (instead of "okay").
>
> Yes, that needs fixing, thanks for mentioning that.
>
>>
>> It seems to work with the limited test did:
>> ifconfig eth1 up
>> udhcpc -i lan1
>> iperf -c mylaptop
>>
>> (same for lan4)
>>
>> However is there a way to be sure that the new binding is used?
>
> The best way is probably to make sure that your switch device appears
> parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
> Alternatively, if you see a message like:
>
> DSA: switch 0 0 parsed
>
> in your dmesg, that would also be indicative of using the new binding
> and corresponding code.
So it's OK I had this message.
Gregory
>
> Thanks a lot for trying that out!
> --
> Florian
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2017-01-05 12:55 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
2017-01-02 2:22 ` [PATCH 1/8] ARM: dts: armada-370-rd: Utilize " Florian Fainelli
2017-01-03 16:36 ` Andrew Lunn
2017-01-04 17:30 ` Florian Fainelli
2017-01-05 9:41 ` Gregory CLEMENT
2017-01-02 2:22 ` [PATCH 2/8] ARM: dts: armada-38x: " Florian Fainelli
2017-01-03 16:14 ` Gregory CLEMENT
2017-01-02 2:22 ` [PATCH 3/8] ARM: dts: armada-388-clearfog: " Florian Fainelli
2017-01-02 8:59 ` Neil Armstrong
2017-01-04 17:23 ` Gregory CLEMENT
2017-01-04 17:27 ` Florian Fainelli
2017-01-04 17:38 ` Vivien Didelot
2017-01-04 17:42 ` Andrew Lunn
2017-01-04 17:48 ` Vivien Didelot
2017-01-05 12:55 ` Gregory CLEMENT
2017-01-02 2:22 ` [PATCH 4/8] ARM: dts: armada-xp-linksys-mamba: " Florian Fainelli
2017-01-02 2:22 ` [PATCH 5/8] ARM: dts: kirkwood-dir665: " Florian Fainelli
2017-01-02 2:22 ` [PATCH 6/8] ARM: dts: kirkwood-linksys-viper: " Florian Fainelli
2017-01-02 2:22 ` [PATCH 7/8] ARM: dts: kirkwood-mv88f6281gtw-ge: " Florian Fainelli
2017-01-02 2:22 ` [PATCH 8/8] ARM: dts: kirkwood-rd88f6281: " Florian Fainelli
2017-01-03 16:19 ` [PATCH 0/8] ARM: dts: Switch to " Gregory CLEMENT
2017-01-03 16:32 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).