From: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent
Date: Thu, 21 May 2015 07:39:52 +0200 [thread overview]
Message-ID: <0D9D5B5F-3FAB-4AC4-89DA-1001F522BD02@goldelico.com> (raw)
In-Reply-To: <20150520222053.GC28218@earth>
Am 21.05.2015 um 00:20 schrieb Sebastian Reichel <sre@kernel.org>:
> Hi,
>
> On Tue, May 19, 2015 at 10:28:39AM +0200, Dr. H. Nikolaus Schaller wrote:
>> Am 19.05.2015 um 09:13 schrieb Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>>> Changes since v1:
>>> =================
>>> 1. Patch 2: fix invalid member used for container_of().
>>> 2. Patch 2: Replace WARN with pr_warn() in __power_supply_register()
>>> if parent is missing.
>>>
>>>
>>> Description:
>>> ============
>>> This is an idea to fix issue in bq27x00 driver (and probably in others)
>>> reported by H. Nikolaus Schaller [0].
>>>
>>> The fixes are marked RFC/RFT because:
>>> 1. I do not have bq27x00-like device. I confirmed this and tested on
>>> modified drivers (max77693, ACPI AC). These drivers are not
>>> impacted by the issue but one can easily adjust them to reproduce
>>> the problem.
>>> 2. The first uevent coming from power_supply_register() is now
>>> different because it won't contain device properties. I am
>>> not sure how this impacts userspace.
>>>
>>> Comments are welcomed.
>>
>> appears to work! bq27000 is coming up now without hickups.
>>
>> What I can’t test is if the uevent is reasonable because we do not
>> have a specific rule triggered by it in our system.
>>
>> So from my side we are now happy with the solution.
>
> So you would be ok with the following added to the patches?
>
> Tested-By: Dr. H. Nikolaus Schaller <hns@goldelico.com>
Yes, please add.
BR,
Nikolaus
next prev parent reply other threads:[~2015-05-21 5:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 7:13 [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent Krzysztof Kozlowski
2015-05-19 7:13 ` [RFC/RFT v2 1/2] power_supply: Fix NULL pointer dereference during bq27x00_battery probe Krzysztof Kozlowski
2015-05-19 7:13 ` [RFC/RFT v2 2/2] power_supply: Fix possible NULL pointer dereference on early uevent Krzysztof Kozlowski
2015-05-19 8:28 ` [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent Dr. H. Nikolaus Schaller
2015-05-20 22:20 ` Sebastian Reichel
2015-05-21 5:39 ` Dr. H. Nikolaus Schaller [this message]
2015-05-21 18:03 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0D9D5B5F-3FAB-4AC4-89DA-1001F522BD02@goldelico.com \
--to=hns@goldelico.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).