From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>
Subject: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent
Date: Tue, 19 May 2015 16:13:00 +0900 [thread overview]
Message-ID: <1432019582-27612-1-git-send-email-k.kozlowski@samsung.com> (raw)
Hi,
Changes since v1:
=================
1. Patch 2: fix invalid member used for container_of().
2. Patch 2: Replace WARN with pr_warn() in __power_supply_register()
if parent is missing.
Description:
============
This is an idea to fix issue in bq27x00 driver (and probably in others)
reported by H. Nikolaus Schaller [0].
The fixes are marked RFC/RFT because:
1. I do not have bq27x00-like device. I confirmed this and tested on
modified drivers (max77693, ACPI AC). These drivers are not
impacted by the issue but one can easily adjust them to reproduce
the problem.
2. The first uevent coming from power_supply_register() is now
different because it won't contain device properties. I am
not sure how this impacts userspace.
Comments are welcomed.
[0] https://lkml.org/lkml/2015/5/18/152
Best regards,
Krzysztof
Krzysztof Kozlowski (2):
power_supply: Fix NULL pointer dereference during bq27x00_battery
probe
power_supply: Fix possible NULL pointer dereference on early uevent
drivers/power/power_supply_core.c | 61 +++++++++++++++++++++++++++++++++++----
include/linux/power_supply.h | 1 +
2 files changed, 56 insertions(+), 6 deletions(-)
--
1.9.1
next reply other threads:[~2015-05-19 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 7:13 Krzysztof Kozlowski [this message]
2015-05-19 7:13 ` [RFC/RFT v2 1/2] power_supply: Fix NULL pointer dereference during bq27x00_battery probe Krzysztof Kozlowski
2015-05-19 7:13 ` [RFC/RFT v2 2/2] power_supply: Fix possible NULL pointer dereference on early uevent Krzysztof Kozlowski
2015-05-19 8:28 ` [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent Dr. H. Nikolaus Schaller
2015-05-20 22:20 ` Sebastian Reichel
2015-05-21 5:39 ` Dr. H. Nikolaus Schaller
2015-05-21 18:03 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432019582-27612-1-git-send-email-k.kozlowski@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).