[PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs

[PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs

[Miaohe Lin]

Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
sizes"), we can use macro default_hstate to get the struct hstate which
we use by default. But init_hugetlbfs_fs() forgot to use it.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 fs/hugetlbfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 9b221b87fbea..88751e35e69d 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -1544,7 +1544,7 @@ static int __init init_hugetlbfs_fs(void)
 		goto out_free;
 
 	/* default hstate mount is required */
-	mnt = mount_one_hugetlbfs(&hstates[default_hstate_idx]);
+	mnt = mount_one_hugetlbfs(&default_hstate);
 	if (IS_ERR(mnt)) {
 		error = PTR_ERR(mnt);
 		goto out_unreg;
-- 
2.19.1

Re: [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs

[David Hildenbrand]

On 16.01.21 10:18, Miaohe Lin wrote:
> Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
> sizes"), we can use macro default_hstate to get the struct hstate which
> we use by default. But init_hugetlbfs_fs() forgot to use it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  fs/hugetlbfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 9b221b87fbea..88751e35e69d 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1544,7 +1544,7 @@ static int __init init_hugetlbfs_fs(void)
>  		goto out_free;
>  
>  	/* default hstate mount is required */
> -	mnt = mount_one_hugetlbfs(&hstates[default_hstate_idx]);
> +	mnt = mount_one_hugetlbfs(&default_hstate);
>  	if (IS_ERR(mnt)) {
>  		error = PTR_ERR(mnt);
>  		goto out_unreg;
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb

Re: [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs

[Mike Kravetz]

On 1/16/21 1:18 AM, Miaohe Lin wrote:
> Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
> sizes"), we can use macro default_hstate to get the struct hstate which
> we use by default. But init_hugetlbfs_fs() forgot to use it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz

> ---
>  fs/hugetlbfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 9b221b87fbea..88751e35e69d 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1544,7 +1544,7 @@ static int __init init_hugetlbfs_fs(void)
>  		goto out_free;
>  
>  	/* default hstate mount is required */
> -	mnt = mount_one_hugetlbfs(&hstates[default_hstate_idx]);
> +	mnt = mount_one_hugetlbfs(&default_hstate);
>  	if (IS_ERR(mnt)) {
>  		error = PTR_ERR(mnt);
>  		goto out_unreg;
> 

Re: [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs

[Mike Kravetz]

CC Andrew

On 1/19/21 9:53 AM, Mike Kravetz wrote:
> On 1/16/21 1:18 AM, Miaohe Lin wrote:
>> Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
>> sizes"), we can use macro default_hstate to get the struct hstate which
>> we use by default. But init_hugetlbfs_fs() forgot to use it.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> 
> Thanks,
> 
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
>