* [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs
@ 2021-01-16 9:18 Miaohe Lin
2021-01-18 9:57 ` David Hildenbrand
2021-01-19 17:53 ` Mike Kravetz
0 siblings, 2 replies; 4+ messages in thread
From: Miaohe Lin @ 2021-01-16 9:18 UTC (permalink / raw)
To: mike.kravetz; +Cc: linux-mm, linux-kernel, linmiaohe
Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
sizes"), we can use macro default_hstate to get the struct hstate which
we use by default. But init_hugetlbfs_fs() forgot to use it.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
fs/hugetlbfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 9b221b87fbea..88751e35e69d 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -1544,7 +1544,7 @@ static int __init init_hugetlbfs_fs(void)
goto out_free;
/* default hstate mount is required */
- mnt = mount_one_hugetlbfs(&hstates[default_hstate_idx]);
+ mnt = mount_one_hugetlbfs(&default_hstate);
if (IS_ERR(mnt)) {
error = PTR_ERR(mnt);
goto out_unreg;
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs
2021-01-16 9:18 [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs Miaohe Lin
@ 2021-01-18 9:57 ` David Hildenbrand
2021-01-19 17:53 ` Mike Kravetz
1 sibling, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2021-01-18 9:57 UTC (permalink / raw)
To: Miaohe Lin, mike.kravetz; +Cc: linux-mm, linux-kernel
On 16.01.21 10:18, Miaohe Lin wrote:
> Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
> sizes"), we can use macro default_hstate to get the struct hstate which
> we use by default. But init_hugetlbfs_fs() forgot to use it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> fs/hugetlbfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 9b221b87fbea..88751e35e69d 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1544,7 +1544,7 @@ static int __init init_hugetlbfs_fs(void)
> goto out_free;
>
> /* default hstate mount is required */
> - mnt = mount_one_hugetlbfs(&hstates[default_hstate_idx]);
> + mnt = mount_one_hugetlbfs(&default_hstate);
> if (IS_ERR(mnt)) {
> error = PTR_ERR(mnt);
> goto out_unreg;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs
2021-01-16 9:18 [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs Miaohe Lin
2021-01-18 9:57 ` David Hildenbrand
@ 2021-01-19 17:53 ` Mike Kravetz
2021-01-19 18:11 ` Mike Kravetz
1 sibling, 1 reply; 4+ messages in thread
From: Mike Kravetz @ 2021-01-19 17:53 UTC (permalink / raw)
To: Miaohe Lin; +Cc: linux-mm, linux-kernel
On 1/16/21 1:18 AM, Miaohe Lin wrote:
> Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
> sizes"), we can use macro default_hstate to get the struct hstate which
> we use by default. But init_hugetlbfs_fs() forgot to use it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
> ---
> fs/hugetlbfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 9b221b87fbea..88751e35e69d 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1544,7 +1544,7 @@ static int __init init_hugetlbfs_fs(void)
> goto out_free;
>
> /* default hstate mount is required */
> - mnt = mount_one_hugetlbfs(&hstates[default_hstate_idx]);
> + mnt = mount_one_hugetlbfs(&default_hstate);
> if (IS_ERR(mnt)) {
> error = PTR_ERR(mnt);
> goto out_unreg;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs
2021-01-19 17:53 ` Mike Kravetz
@ 2021-01-19 18:11 ` Mike Kravetz
0 siblings, 0 replies; 4+ messages in thread
From: Mike Kravetz @ 2021-01-19 18:11 UTC (permalink / raw)
To: Miaohe Lin; +Cc: linux-mm, linux-kernel, Andrew Morton
CC Andrew
On 1/19/21 9:53 AM, Mike Kravetz wrote:
> On 1/16/21 1:18 AM, Miaohe Lin wrote:
>> Since commit e5ff215941d5 ("hugetlb: multiple hstates for multiple page
>> sizes"), we can use macro default_hstate to get the struct hstate which
>> we use by default. But init_hugetlbfs_fs() forgot to use it.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>
> Thanks,
>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-19 19:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-16 9:18 [PATCH] hugetlbfs: Use helper macro default_hstate in init_hugetlbfs_fs Miaohe Lin
2021-01-18 9:57 ` David Hildenbrand
2021-01-19 17:53 ` Mike Kravetz
2021-01-19 18:11 ` Mike Kravetz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).