From: poza@codeaurora.org
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Keith Busch <keith.busch@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>, Wei Zhang <wzhang@fb.com>,
Timur Tabi <timur@codeaurora.org>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v13 6/6] PCI/DPC: Do not do recovery for hotplug enabled system
Date: Mon, 16 Apr 2018 22:45:19 +0530 [thread overview]
Message-ID: <0bed6fb09478349a95d9f6ad4449f31f@codeaurora.org> (raw)
In-Reply-To: <c236b732-ed65-9f94-7ae5-b1203dff2eb0@codeaurora.org>
On 2018-04-16 20:16, Sinan Kaya wrote:
> On 4/15/2018 11:17 PM, Bjorn Helgaas wrote:
>> It doesn't seem right to me that we handle both ERR_NONFATAL and
>> ERR_FATAL events differently if we happen to have DPC support in a
>> switch.
>>
>> Maybe we should consider triggering DPC only on ERR_FATAL? That would
>> keep DPC out of the ERR_NONFATAL cases.
>>
> From reliability perspective, it makes sense. DPC handles NONFATAL
> errors
> by bringing down the link. If error happened behind a switch and root
> port
> is handling DPC, we are impacting a lot of devices operation because of
> one
> faulty device.
>
> Keith, do you have any preference on this direction?
>
>> For ERR_FATAL, maybe we should bite the bullet and use
>> remove/re-enumerate for AER as well as for DPC. That would be painful
>> for higher-level software, but if we're willing to accept that pain
>> for new systems that support DPC, maybe life would be better overall
>> if it worked the same way on systems without DPC?
>
> Sure, we can go to this route as well.
ok so finally this is what is being proposed and so far Bjorn, Sinan and
myself agreed on following:
I need to move the stop and re-enumerate code into the AER path instead
of patch #6 for both DPC_FATAL and AER_FATAL error types.
Also, I should turn off DPC NON_FATAL error detection.
Keith, please confirm if you are okay with above proposal.
Regards,
Oza.
next prev parent reply other threads:[~2018-04-16 17:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 14:41 [PATCH v13 0/6] Address error and recovery for AER and DPC Oza Pawandeep
2018-04-09 14:41 ` [PATCH v13 1/6] PCI/AER: Rename error recovery to generic PCI naming Oza Pawandeep
2018-04-09 23:14 ` Keith Busch
2018-04-09 14:41 ` [PATCH v13 2/6] PCI/AER: Factor out error reporting from AER Oza Pawandeep
2018-04-09 23:15 ` Keith Busch
2018-04-10 11:36 ` kbuild test robot
2018-04-09 14:41 ` [PATCH v13 3/6] PCI/PORTDRV: Implement generic find service Oza Pawandeep
2018-04-09 23:15 ` Keith Busch
2018-04-09 14:41 ` [PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-04-09 23:29 ` Keith Busch
2018-04-09 23:51 ` Sinan Kaya
2018-04-10 0:05 ` Sinan Kaya
2018-04-09 14:41 ` [PATCH v13 5/6] PCI: Unify wait for link active into generic PCI Oza Pawandeep
2018-04-09 23:25 ` Keith Busch
2018-04-12 8:40 ` poza
2018-04-09 14:41 ` [PATCH v13 6/6] PCI/DPC: Do not do recovery for hotplug enabled system Oza Pawandeep
2018-04-10 21:03 ` Bjorn Helgaas
2018-04-12 1:41 ` Sinan Kaya
2018-04-12 14:06 ` Bjorn Helgaas
2018-04-12 14:34 ` Sinan Kaya
2018-04-12 14:39 ` Keith Busch
2018-04-12 15:02 ` Keith Busch
2018-04-12 16:27 ` Sinan Kaya
2018-04-12 17:09 ` Keith Busch
2018-04-12 17:41 ` Sinan Kaya
2018-04-14 15:53 ` Sinan Kaya
2018-04-16 3:17 ` Bjorn Helgaas
2018-04-16 5:33 ` poza
2018-04-16 5:51 ` poza
2018-04-16 14:01 ` Bjorn Helgaas
2018-04-16 14:46 ` Sinan Kaya
2018-04-16 17:15 ` poza [this message]
2018-04-16 3:16 ` [PATCH v13 0/6] Address error and recovery for AER and DPC Bjorn Helgaas
2018-04-16 3:53 ` Sinan Kaya
2018-04-16 6:03 ` poza
2018-04-16 13:27 ` Bjorn Helgaas
2018-04-16 14:12 ` poza
2018-04-16 14:30 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bed6fb09478349a95d9f6ad4449f31f@codeaurora.org \
--to=poza@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).