From: kbuild test robot <lkp@intel.com>
To: Oza Pawandeep <poza@codeaurora.org>
Cc: kbuild-all@01.org, Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>,
Keith Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>,
Sinan Kaya <okaya@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>,
Oza Pawandeep <poza@codeaurora.org>
Subject: Re: [PATCH v13 2/6] PCI/AER: Factor out error reporting from AER
Date: Tue, 10 Apr 2018 19:36:55 +0800 [thread overview]
Message-ID: <201804101900.QbANdYeR%fengguang.wu@intel.com> (raw)
In-Reply-To: <1523284914-2037-3-git-send-email-poza@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 2342 bytes --]
Hi Oza,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.16]
[cannot apply to pci/next linus/master next-20180410]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180410-045644
config: x86_64-randconfig-s4-04101607 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the linux-review/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180410-045644 HEAD db413d3e52b272ef8e6f03ff125e65468abd31e6 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/pci/pcie/err.o: In function `reset_link':
>> drivers/pci/pcie/err.c:197: undefined reference to `find_aer_service'
vim +197 drivers/pci/pcie/err.c
181
182 static pci_ers_result_t reset_link(struct pci_dev *dev)
183 {
184 struct pci_dev *udev;
185 pci_ers_result_t status;
186 struct pcie_port_service_driver *driver = NULL;
187
188 if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) {
189 /* Reset this port for all subordinates */
190 udev = dev;
191 } else {
192 /* Reset the upstream component (likely downstream port) */
193 udev = dev->bus->self;
194 }
195
196 /* Use the aer driver of the component firstly */
> 197 driver = find_aer_service(udev);
198
199 if (driver && driver->reset_link) {
200 status = driver->reset_link(udev);
201 } else if (udev->has_secondary_link) {
202 status = default_reset_link(udev);
203 } else {
204 pci_printk(KERN_DEBUG, dev,
205 "no link-reset support at upstream device %s\n",
206 pci_name(udev));
207 return PCI_ERS_RESULT_DISCONNECT;
208 }
209
210 if (status != PCI_ERS_RESULT_RECOVERED) {
211 pci_printk(KERN_DEBUG, dev,
212 "link reset at upstream device %s failed\n",
213 pci_name(udev));
214 return PCI_ERS_RESULT_DISCONNECT;
215 }
216
217 return status;
218 }
219
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34614 bytes --]
next prev parent reply other threads:[~2018-04-10 11:36 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 14:41 [PATCH v13 0/6] Address error and recovery for AER and DPC Oza Pawandeep
2018-04-09 14:41 ` [PATCH v13 1/6] PCI/AER: Rename error recovery to generic PCI naming Oza Pawandeep
2018-04-09 23:14 ` Keith Busch
2018-04-09 14:41 ` [PATCH v13 2/6] PCI/AER: Factor out error reporting from AER Oza Pawandeep
2018-04-09 23:15 ` Keith Busch
2018-04-10 11:36 ` kbuild test robot [this message]
2018-04-09 14:41 ` [PATCH v13 3/6] PCI/PORTDRV: Implement generic find service Oza Pawandeep
2018-04-09 23:15 ` Keith Busch
2018-04-09 14:41 ` [PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-04-09 23:29 ` Keith Busch
2018-04-09 23:51 ` Sinan Kaya
2018-04-10 0:05 ` Sinan Kaya
2018-04-09 14:41 ` [PATCH v13 5/6] PCI: Unify wait for link active into generic PCI Oza Pawandeep
2018-04-09 23:25 ` Keith Busch
2018-04-12 8:40 ` poza
2018-04-09 14:41 ` [PATCH v13 6/6] PCI/DPC: Do not do recovery for hotplug enabled system Oza Pawandeep
2018-04-10 21:03 ` Bjorn Helgaas
2018-04-12 1:41 ` Sinan Kaya
2018-04-12 14:06 ` Bjorn Helgaas
2018-04-12 14:34 ` Sinan Kaya
2018-04-12 14:39 ` Keith Busch
2018-04-12 15:02 ` Keith Busch
2018-04-12 16:27 ` Sinan Kaya
2018-04-12 17:09 ` Keith Busch
2018-04-12 17:41 ` Sinan Kaya
2018-04-14 15:53 ` Sinan Kaya
2018-04-16 3:17 ` Bjorn Helgaas
2018-04-16 5:33 ` poza
2018-04-16 5:51 ` poza
2018-04-16 14:01 ` Bjorn Helgaas
2018-04-16 14:46 ` Sinan Kaya
2018-04-16 17:15 ` poza
2018-04-16 3:16 ` [PATCH v13 0/6] Address error and recovery for AER and DPC Bjorn Helgaas
2018-04-16 3:53 ` Sinan Kaya
2018-04-16 6:03 ` poza
2018-04-16 13:27 ` Bjorn Helgaas
2018-04-16 14:12 ` poza
2018-04-16 14:30 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201804101900.QbANdYeR%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=poza@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).