* [PATCH] platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove
@ 2019-11-13 6:38 Chuhong Yuan
2019-11-20 16:22 ` Enric Balletbo i Serra
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-13 6:38 UTC (permalink / raw)
Cc: Benson Leung, Enric Balletbo i Serra, linux-kernel, Chuhong Yuan
The driver forgets to destroy workqueue in remove.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/platform/chrome/cros_usbpd_logger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
index 2430e8b82810..374cdd1e868a 100644
--- a/drivers/platform/chrome/cros_usbpd_logger.c
+++ b/drivers/platform/chrome/cros_usbpd_logger.c
@@ -224,6 +224,7 @@ static int cros_usbpd_logger_remove(struct platform_device *pd)
struct logger_data *logger = platform_get_drvdata(pd);
cancel_delayed_work_sync(&logger->log_work);
+ destroy_workqueue(logger->log_workqueue);
return 0;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove
2019-11-13 6:38 [PATCH] platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove Chuhong Yuan
@ 2019-11-20 16:22 ` Enric Balletbo i Serra
0 siblings, 0 replies; 2+ messages in thread
From: Enric Balletbo i Serra @ 2019-11-20 16:22 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Benson Leung, linux-kernel
On 13/11/19 7:38, Chuhong Yuan wrote:
> The driver forgets to destroy workqueue in remove.
> Add the missed call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Applied for 5.5
Thanks,
Enric
> ---
> drivers/platform/chrome/cros_usbpd_logger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
> index 2430e8b82810..374cdd1e868a 100644
> --- a/drivers/platform/chrome/cros_usbpd_logger.c
> +++ b/drivers/platform/chrome/cros_usbpd_logger.c
> @@ -224,6 +224,7 @@ static int cros_usbpd_logger_remove(struct platform_device *pd)
> struct logger_data *logger = platform_get_drvdata(pd);
>
> cancel_delayed_work_sync(&logger->log_work);
> + destroy_workqueue(logger->log_workqueue);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-20 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 6:38 [PATCH] platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove Chuhong Yuan
2019-11-20 16:22 ` Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).