[PATCH] platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove

[PATCH] platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove

[Chuhong Yuan]

The driver forgets to destroy workqueue in remove.
Add the missed call to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
 drivers/platform/chrome/cros_usbpd_logger.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
index 2430e8b82810..374cdd1e868a 100644
--- a/drivers/platform/chrome/cros_usbpd_logger.c
+++ b/drivers/platform/chrome/cros_usbpd_logger.c
@@ -224,6 +224,7 @@ static int cros_usbpd_logger_remove(struct platform_device *pd)
 	struct logger_data *logger = platform_get_drvdata(pd);
 
 	cancel_delayed_work_sync(&logger->log_work);
+	destroy_workqueue(logger->log_workqueue);
 
 	return 0;
 }
-- 
2.23.0

Re: [PATCH] platform/chrome: cros_usbpd_logger: add missed destroy_workqueue in remove

[Enric Balletbo i Serra]

On 13/11/19 7:38, Chuhong Yuan wrote:
> The driver forgets to destroy workqueue in remove.
> Add the missed call to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>

Applied for 5.5

Thanks,
 Enric

> ---
>  drivers/platform/chrome/cros_usbpd_logger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
> index 2430e8b82810..374cdd1e868a 100644
> --- a/drivers/platform/chrome/cros_usbpd_logger.c
> +++ b/drivers/platform/chrome/cros_usbpd_logger.c
> @@ -224,6 +224,7 @@ static int cros_usbpd_logger_remove(struct platform_device *pd)
>  	struct logger_data *logger = platform_get_drvdata(pd);
>  
>  	cancel_delayed_work_sync(&logger->log_work);
> +	destroy_workqueue(logger->log_workqueue);
>  
>  	return 0;
>  }
>