From: Pierre Morel <pmorel@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com,
thuth@redhat.com, imbrenda@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, wintera@linux.ibm.com, seiden@linux.ibm.com,
nrb@linux.ibm.com
Subject: Re: [PATCH v10 1/3] KVM: s390: ipte lock for SCA access should be contained in KVM
Date: Mon, 27 Jun 2022 15:29:13 +0200 [thread overview]
Message-ID: <0d90c2cb-e0e9-a112-1c85-9aa8fdd54311@linux.ibm.com> (raw)
In-Reply-To: <74a234eb-0705-3c42-214f-5cdc8b125c63@linux.ibm.com>
On 6/24/22 07:47, Janosch Frank wrote:
> On 6/20/22 14:54, Pierre Morel wrote:
>> We can check if SIIF is enabled by testing the sclp_info struct
>> instead of testing the sie control block eca variable.
>> sclp.has_ssif is the only requirement to set ECA_SII anyway
>> so we can go straight to the source for that.
>
>
> The subject and commit description don't fit together.
> You're doing two things in this patch and only describe one of them.
>
> I'd suggest something like this:
>
> KVM: s390: Cleanup ipte lock access and SIIF facility checks
>
> We can check if SIIF is enabled by testing the sclp_info struct instead
> of testing the sie control block eca variable as that facility is always
> enabled if available.
>
> Also let's cleanup all the ipte related struct member accesses which
> currently happen by referencing the KVM struct via the VCPU struct.
> Making the KVM struct the parameter to the ipte_* functions removes one
> level of indirection which makes the code more readable.
>
OK done.
>
> Other than that I'm happy with this patch.
Thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2022-06-27 13:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 12:54 [PATCH v10 0/3] s390x: KVM: CPU Topology Pierre Morel
2022-06-20 12:54 ` [PATCH v10 1/3] KVM: s390: ipte lock for SCA access should be contained in KVM Pierre Morel
2022-06-24 5:47 ` Janosch Frank
2022-06-27 13:29 ` Pierre Morel [this message]
2022-06-24 6:57 ` Nico Boehr
2022-06-27 13:28 ` Pierre Morel
2022-06-24 9:22 ` Claudio Imbrenda
2022-06-20 12:54 ` [PATCH v10 2/3] KVM: s390: guest support for topology function Pierre Morel
2022-06-24 6:22 ` Janosch Frank
2022-06-27 13:30 ` Pierre Morel
2022-06-24 6:56 ` Nico Boehr
2022-06-27 13:16 ` Pierre Morel
2022-06-28 14:38 ` Pierre Morel
2022-06-24 9:32 ` Claudio Imbrenda
2022-06-27 17:40 ` Pierre Morel
2022-06-24 15:09 ` Janis Schoetterl-Glausch
2022-06-27 14:36 ` Pierre Morel
2022-06-28 8:59 ` Janis Schoetterl-Glausch
2022-06-28 10:58 ` Pierre Morel
2022-06-28 12:18 ` Janis Schoetterl-Glausch
2022-06-28 14:13 ` Pierre Morel
2022-06-28 15:01 ` Janis Schoetterl-Glausch
2022-06-28 15:44 ` Pierre Morel
2022-06-28 10:59 ` Pierre Morel
2022-06-20 12:54 ` [PATCH v10 3/3] KVM: s390: resetting the Topology-Change-Report Pierre Morel
2022-06-24 6:50 ` Janosch Frank
2022-06-27 13:34 ` Pierre Morel
2022-06-28 16:41 ` Janis Schoetterl-Glausch
2022-06-28 17:27 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d90c2cb-e0e9-a112-1c85-9aa8fdd54311@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).