From: Pierre Morel <pmorel@linux.ibm.com>
To: Janis Schoetterl-Glausch <scgl@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
borntraeger@de.ibm.com, frankja@linux.ibm.com, cohuck@redhat.com,
david@redhat.com, thuth@redhat.com, imbrenda@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, wintera@linux.ibm.com,
seiden@linux.ibm.com, nrb@linux.ibm.com
Subject: Re: [PATCH v10 2/3] KVM: s390: guest support for topology function
Date: Tue, 28 Jun 2022 12:59:52 +0200 [thread overview]
Message-ID: <c5129b4a-b662-7643-2031-941da75e1e20@linux.ibm.com> (raw)
In-Reply-To: <207a01aa-d92c-4a17-7b2f-aed59da4ce09@linux.ibm.com>
On 6/28/22 10:59, Janis Schoetterl-Glausch wrote:
> On 6/20/22 14:54, Pierre Morel wrote:
>> We report a topology change to the guest for any CPU hotplug.
>>
>> The reporting to the guest is done using the Multiprocessor
>> Topology-Change-Report (MTCR) bit of the utility entry in the guest's
>> SCA which will be cleared during the interpretation of PTF.
>>
>> On every vCPU creation we set the MCTR bit to let the guest know the
>> next time he uses the PTF with command 2 instruction that the
>> topology changed and that he should use the STSI(15.1.x) instruction
>> to get the topology details.
>>
>> STSI(15.1.x) gives information on the CPU configuration topology.
>> Let's accept the interception of STSI with the function code 15 and
>> let the userland part of the hypervisor handle it when userland
>> support the CPU Topology facility.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>> arch/s390/include/asm/kvm_host.h | 11 ++++++++---
>> arch/s390/kvm/kvm-s390.c | 27 ++++++++++++++++++++++++++-
>> arch/s390/kvm/priv.c | 15 +++++++++++----
>> arch/s390/kvm/vsie.c | 3 +++
>> 4 files changed, 48 insertions(+), 8 deletions(-)
>>
> [...]
>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 8fcb56141689..95b96019ca8e 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -1691,6 +1691,25 @@ static int kvm_s390_get_cpu_model(struct kvm *kvm, struct kvm_device_attr *attr)
>> return ret;
>> }
>>
>> +/**
>> + * kvm_s390_sca_set_mtcr
>
> I wonder if there is a better name, kvm_s390_report_topology_change maybe?
OK, for me, with a good name I can suppress a comment.
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2022-06-28 10:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 12:54 [PATCH v10 0/3] s390x: KVM: CPU Topology Pierre Morel
2022-06-20 12:54 ` [PATCH v10 1/3] KVM: s390: ipte lock for SCA access should be contained in KVM Pierre Morel
2022-06-24 5:47 ` Janosch Frank
2022-06-27 13:29 ` Pierre Morel
2022-06-24 6:57 ` Nico Boehr
2022-06-27 13:28 ` Pierre Morel
2022-06-24 9:22 ` Claudio Imbrenda
2022-06-20 12:54 ` [PATCH v10 2/3] KVM: s390: guest support for topology function Pierre Morel
2022-06-24 6:22 ` Janosch Frank
2022-06-27 13:30 ` Pierre Morel
2022-06-24 6:56 ` Nico Boehr
2022-06-27 13:16 ` Pierre Morel
2022-06-28 14:38 ` Pierre Morel
2022-06-24 9:32 ` Claudio Imbrenda
2022-06-27 17:40 ` Pierre Morel
2022-06-24 15:09 ` Janis Schoetterl-Glausch
2022-06-27 14:36 ` Pierre Morel
2022-06-28 8:59 ` Janis Schoetterl-Glausch
2022-06-28 10:58 ` Pierre Morel
2022-06-28 12:18 ` Janis Schoetterl-Glausch
2022-06-28 14:13 ` Pierre Morel
2022-06-28 15:01 ` Janis Schoetterl-Glausch
2022-06-28 15:44 ` Pierre Morel
2022-06-28 10:59 ` Pierre Morel [this message]
2022-06-20 12:54 ` [PATCH v10 3/3] KVM: s390: resetting the Topology-Change-Report Pierre Morel
2022-06-24 6:50 ` Janosch Frank
2022-06-27 13:34 ` Pierre Morel
2022-06-28 16:41 ` Janis Schoetterl-Glausch
2022-06-28 17:27 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5129b4a-b662-7643-2031-941da75e1e20@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=scgl@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).