From: Nico Boehr <nrb@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
borntraeger@de.ibm.com, frankja@linux.ibm.com, cohuck@redhat.com,
david@redhat.com, thuth@redhat.com, imbrenda@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, pmorel@linux.ibm.com,
wintera@linux.ibm.com, seiden@linux.ibm.com
Subject: Re: [PATCH v10 2/3] KVM: s390: guest support for topology function
Date: Fri, 24 Jun 2022 08:56:44 +0200 [thread overview]
Message-ID: <165605380436.8840.11959073846437899088@localhost.localdomain> (raw)
In-Reply-To: <20220620125437.37122-3-pmorel@linux.ibm.com>
Quoting Pierre Morel (2022-06-20 14:54:36)
[...]
> diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_host.h
> index 766028d54a3e..bb54196d4ed6 100644
> --- a/arch/s390/include/asm/kvm_host.h
> +++ b/arch/s390/include/asm/kvm_host.h
[...]
> @@ -3403,6 +3426,8 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu)
> rc = kvm_s390_vcpu_setup(vcpu);
> if (rc)
> goto out_ucontrol_uninit;
> +
> + kvm_s390_sca_set_mtcr(vcpu->kvm);
We set the MTCR in the vcpu create. Does it also make sense to set it in kvm_arch_vcpu_destroy?
[...]
> diff --git a/arch/s390/kvm/priv.c b/arch/s390/kvm/priv.c
> index 12c464c7cddf..77a692238585 100644
> --- a/arch/s390/kvm/priv.c
> +++ b/arch/s390/kvm/priv.c
> @@ -873,10 +873,13 @@ static int handle_stsi(struct kvm_vcpu *vcpu)
[...]
> + case 15:
> + trace_kvm_s390_handle_stsi(vcpu, fc, sel1, sel2, operand2);
> + insert_stsi_usr_data(vcpu, operand2, ar, fc, sel1, sel2);
> + return -EREMOTE;
Maybe the API documentation should clearly note that once you turn on KVM_CAP_S390_CPU_TOPOLOGY, you will get exits to userspace for STSI 15.x.y, regardless of whether KVM_CAP_S390_USER_STSI is on or off.
Other than that, looks good, hence:
Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
next prev parent reply other threads:[~2022-06-24 6:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 12:54 [PATCH v10 0/3] s390x: KVM: CPU Topology Pierre Morel
2022-06-20 12:54 ` [PATCH v10 1/3] KVM: s390: ipte lock for SCA access should be contained in KVM Pierre Morel
2022-06-24 5:47 ` Janosch Frank
2022-06-27 13:29 ` Pierre Morel
2022-06-24 6:57 ` Nico Boehr
2022-06-27 13:28 ` Pierre Morel
2022-06-24 9:22 ` Claudio Imbrenda
2022-06-20 12:54 ` [PATCH v10 2/3] KVM: s390: guest support for topology function Pierre Morel
2022-06-24 6:22 ` Janosch Frank
2022-06-27 13:30 ` Pierre Morel
2022-06-24 6:56 ` Nico Boehr [this message]
2022-06-27 13:16 ` Pierre Morel
2022-06-28 14:38 ` Pierre Morel
2022-06-24 9:32 ` Claudio Imbrenda
2022-06-27 17:40 ` Pierre Morel
2022-06-24 15:09 ` Janis Schoetterl-Glausch
2022-06-27 14:36 ` Pierre Morel
2022-06-28 8:59 ` Janis Schoetterl-Glausch
2022-06-28 10:58 ` Pierre Morel
2022-06-28 12:18 ` Janis Schoetterl-Glausch
2022-06-28 14:13 ` Pierre Morel
2022-06-28 15:01 ` Janis Schoetterl-Glausch
2022-06-28 15:44 ` Pierre Morel
2022-06-28 10:59 ` Pierre Morel
2022-06-20 12:54 ` [PATCH v10 3/3] KVM: s390: resetting the Topology-Change-Report Pierre Morel
2022-06-24 6:50 ` Janosch Frank
2022-06-27 13:34 ` Pierre Morel
2022-06-28 16:41 ` Janis Schoetterl-Glausch
2022-06-28 17:27 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165605380436.8840.11959073846437899088@localhost.localdomain \
--to=nrb@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).