From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Amit Kucheria <amit.kucheria@linaro.org>, Andy Gross <agross@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH v2 00/13] qcom: dts: thermal cleanups
Date: Thu, 25 Apr 2019 15:06:59 +0200 [thread overview]
Message-ID: <0e2ffc33-1ffd-2eb2-e6a7-117b3f14c2e7@free.fr> (raw)
In-Reply-To: <CAHLCerPj6MQ0LeqUHM_91NOW1cP0z75DD7oBnR7Q3-8rpCmnww@mail.gmail.com>
On 25/04/2019 08:31, Amit Kucheria wrote:
> [PATCH 3/3] arm64: dts: msm8998: thermal: Restrict thermal zone name length to under 20
>
> The thermal core restricts names of thermal zones to under 20
> characters. Fix the names for a couple of msm8998 thermal zones.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index 062a93a12198..01757829d5f3 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -536,7 +536,7 @@
> };
> };
>
> - cluster0-mhm-thermal {
> + clust0-mhm-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
> @@ -551,7 +551,7 @@
> };
> };
>
> - cluster1-mhm-thermal {
> + clust1-mhm-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
Wouldn't it be better to drop the "-thermal" suffix than to chop characters
off from the actual description?
Or would it make sense to increase the 20-char limit to 24?
=> Probably impossible without breaking the user-space ABI, since
THERMAL_NAME_LENGTH is defined in include/uapi/linux/thermal.h
Anyway, for msm8998 patches, you have my
Tested-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Regards.
next prev parent reply other threads:[~2019-04-25 13:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 10:12 [PATCH v2 00/13] qcom: dts: thermal cleanups Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 01/13] arm64: dts: msm8998: thermal: split address space into two Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 02/13] arm64: dts: msm8998: efficiency is not valid property Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 03/13] arm64: dts: msm8916: thermal: Add sensor for modem Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 04/13] arm64: dts: msm8996: thermal: Add temperature sensors near major peripherals Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 05/13] arm64: dts: msm8998: thermal: Fix the cpu sensor numbers Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 06/13] arm64: dts: msm8998: thermal: Fix the gpu sensor number Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 07/13] arm64: dts: msm8998: thermal: GPU has two sensors, add the second Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 08/13] arm64: dts: msm8998: thermal: Add temperature sensors near major peripherals Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 09/13] arm64: dts: sdm845: " Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 10/13] arm64: dts: msm8998: thermal: Make trip names consistent Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 11/13] arm64: dts: msm8916: " Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 12/13] arm64: dts: msm8996: " Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 13/13] arm64: dts: msm8916: thermal: Convert camera trip type to hot Amit Kucheria
2019-04-02 13:58 ` [PATCH v2 00/13] qcom: dts: thermal cleanups Marc Gonzalez
2019-04-02 18:46 ` Amit Kucheria
2019-04-23 9:31 ` Marc Gonzalez
2019-04-23 12:56 ` Amit Kucheria
2019-04-23 13:10 ` Marc Gonzalez
2019-04-24 14:30 ` Marc Gonzalez
2019-04-25 6:31 ` Amit Kucheria
2019-04-25 11:25 ` Marc Gonzalez
2019-04-25 12:02 ` Marc Gonzalez
2019-04-25 13:06 ` Marc Gonzalez [this message]
2019-04-25 13:16 ` Amit Kucheria
2019-04-23 19:14 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e2ffc33-1ffd-2eb2-e6a7-117b3f14c2e7@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).