linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Andy Gross <agross@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	MSM <linux-arm-msm@vger.kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH v2 00/13] qcom: dts: thermal cleanups
Date: Thu, 25 Apr 2019 12:01:25 +0530	[thread overview]
Message-ID: <CAHLCerPj6MQ0LeqUHM_91NOW1cP0z75DD7oBnR7Q3-8rpCmnww@mail.gmail.com> (raw)
In-Reply-To: <8e53ea22-d248-8c63-bcda-15b502eb9699@free.fr>

[-- Attachment #1: Type: text/plain, Size: 3700 bytes --]

Marc, can you please test these 3 patches on top of my original series?

Andy, patches 1 and 2 fix problems that already exist upstream. They
were not introduced by my series.
Patch 3 fixes an issue with my series where the name of the thermal
zone was too long. You can choose to fold it into the patch titled
"arm64: dts: msm8998: thermal: Add temperature sensors near major
peripherals" or add it as a new patch with a Fixes tag.

On Wed, Apr 24, 2019 at 8:00 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> On 23/04/2019 15:10, Marc Gonzalez wrote:
>
> > Sure. I can give you a Tested-by once everything works on the MEDIABOX I have.
> >
> > You mention the 4 thermal_zone*/temp failures.
> >
> > What about the cluster0-mhm-thermal and cluster1-mhm-thermal failures?
>
> I have synced up with today's linux-next.

Thanks for the report. Can you add the attached couple of patches and retest?

> # dmesg | grep thermal
> Failed to build cluster0-mhm-thermal zone -22
> Failed to build cluster1-mhm-thermal zone -22

This one turned out to be a silly one, The name of the thermal zone is
restricted to under 20 characters. Fixed that with patch 3.

> # for F in $(find /sys/class/thermal/thermal_zone?/ /sys/class/thermal/thermal_zone??/ -type f); do echo $F; cat $F; done
> /sys/class/thermal/thermal_zone0/uevent
> /sys/class/thermal/thermal_zone0/trip_point_0_hyst
> 2000
> /sys/class/thermal/thermal_zone0/mode
> enabled
> /sys/class/thermal/thermal_zone0/power/runtime_active_time
> 0
> /sys/class/thermal/thermal_zone0/power/runtime_status
> unsupported

<snip>

> /sys/class/thermal/thermal_zone8/type
> gpu-thermal-bottom
> /sys/class/thermal/thermal_zone8/offset
> 0
> /sys/class/thermal/thermal_zone8/slope
> 1
> /sys/class/thermal/thermal_zone8/trip_point_0_type
> hot
> /sys/class/thermal/thermal_zone8/k_po
> 0
> /sys/class/thermal/thermal_zone8/integral_cutoff
> 0
> /sys/class/thermal/thermal_zone8/k_i
> 0
> /sys/class/thermal/thermal_zone8/k_pu
> 0
> /sys/class/thermal/thermal_zone8/temp
> cat: read error: Invalid argument

Patch 2 should fix this and thermal_zone9 below.

> /sys/class/thermal/thermal_zone8/trip_point_0_temp
> 90000
> /sys/class/thermal/thermal_zone9/uevent
> /sys/class/thermal/thermal_zone9/trip_point_0_hyst
> 2000
> /sys/class/thermal/thermal_zone9/passive
> 0
> /sys/class/thermal/thermal_zone9/mode
> disabled
> /sys/class/thermal/thermal_zone9/power/runtime_active_time
> 0
> /sys/class/thermal/thermal_zone9/power/runtime_status
> unsupported
> /sys/class/thermal/thermal_zone9/power/autosuspend_delay_ms
> cat: read error: Input/output error
> /sys/class/thermal/thermal_zone9/power/runtime_suspended_time
> 0
> /sys/class/thermal/thermal_zone9/power/control
> auto
> /sys/class/thermal/thermal_zone9/available_policies
> step_wise
> /sys/class/thermal/thermal_zone9/policy
> step_wise
> /sys/class/thermal/thermal_zone9/k_d
> 0
> /sys/class/thermal/thermal_zone9/sustainable_power
> 0
> /sys/class/thermal/thermal_zone9/type
> gpu-thermal-top
> /sys/class/thermal/thermal_zone9/offset
> 0
> /sys/class/thermal/thermal_zone9/slope

<snip>

> /sys/class/thermal/thermal_zone18/available_policies
> step_wise
> /sys/class/thermal/thermal_zone18/policy
> step_wise
> /sys/class/thermal/thermal_zone18/k_d
> 0
> /sys/class/thermal/thermal_zone18/sustainable_power
> 0
> /sys/class/thermal/thermal_zone18/type
> battery-thermal

This look wrong. TSENS shouldn't have board-specific thermal zones.

<snip>

> /sys/class/thermal/thermal_zone19/k_d
> 0
> /sys/class/thermal/thermal_zone19/sustainable_power
> 0
> /sys/class/thermal/thermal_zone19/type
> skin-thermal

And this too. See patch 1 to fix this existing issue (not introduced
by my series).

[-- Attachment #2: 0001-arm64-dts-msm8998-mtp-thermal-Remove-skin-and-batter.patch --]
[-- Type: text/x-patch, Size: 2034 bytes --]

From 94698e19b6329e98404ff9b9cc0c90a3062fa5e5 Mon Sep 17 00:00:00 2001
Message-Id: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556169637.git.amit.kucheria@linaro.org>
From: Amit Kucheria <amit.kucheria@linaro.org>
Date: Thu, 25 Apr 2019 01:22:50 +0530
Subject: [PATCH 1/2] arm64: dts: msm8998-mtp: thermal: Remove skin and battery
 thermal zones

The msm8998-mtp doesn't have TSENS-based sensors wired up for skin and
battery thermal zones. TSENS sensors should be common across all boards
using the SoC and shouldn't be board-specific as these entries.

They also show the following error when trying to read the temperature

   cat: read error: Invalid argument

Remove these board-specific erroneous thermal zones.

Fixes: 4449b6f248d9 ("arm64: dts: qcom: msm8998: Add tsens and thermal-zones")
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 38 -----------------------
 1 file changed, 38 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
index f0901067b043..60bdf7485f0e 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
@@ -15,44 +15,6 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	thermal-zones {
-		battery-thermal {
-			polling-delay-passive = <250>;
-			polling-delay = <1000>;
-
-			thermal-sensors = <&tsens0 0>;
-
-			trips {
-				battery_crit: trip0 {
-					temperature = <60000>;
-					hysteresis = <2000>;
-					type = "critical";
-				};
-			};
-		};
-
-		skin-thermal {
-			polling-delay-passive = <250>;
-			polling-delay = <1000>;
-
-			thermal-sensors = <&tsens1 5>;
-
-			trips {
-				skin_alert: trip0 {
-					temperature = <44000>;
-					hysteresis = <2000>;
-					type = "passive";
-				};
-
-				skip_crit: trip1 {
-					temperature = <70000>;
-					hysteresis = <2000>;
-					type = "critical";
-				};
-			};
-		};
-	};
-
 	vph_pwr: vph-pwr-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "vph_pwr";
-- 
2.17.1


[-- Attachment #3: 0002-arm64-dts-msm8998-thermal-Fix-number-of-supported-se.patch --]
[-- Type: text/x-patch, Size: 1275 bytes --]

From eda7da2d0098d6617671e67658226e3c5fb07045 Mon Sep 17 00:00:00 2001
Message-Id: <eda7da2d0098d6617671e67658226e3c5fb07045.1556169637.git.amit.kucheria@linaro.org>
In-Reply-To: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556169637.git.amit.kucheria@linaro.org>
References: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556169637.git.amit.kucheria@linaro.org>
From: Amit Kucheria <amit.kucheria@linaro.org>
Date: Thu, 25 Apr 2019 01:52:44 +0530
Subject: [PATCH 2/2] arm64: dts: msm8998: thermal: Fix number of supported
 sensors

msm8998 has 22 sensors connected in total, 14 on the 1st controller, 8
on the 2nd controller. Increase the number to allow sensors with ID 12
and 13 to be registered.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 998017d4d847..062a93a12198 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -745,7 +745,7 @@
 			reg = <0x10ab000 0x1000>, /* TM */
 			      <0x10aa000 0x1000>; /* SROT */
 
-			#qcom,sensors = <12>;
+			#qcom,sensors = <14>;
 			#thermal-sensor-cells = <1>;
 		};
 
-- 
2.17.1


[-- Attachment #4: 0003-arm64-dts-msm8998-thermal-Restrict-thermal-zone-name.patch --]
[-- Type: text/x-patch, Size: 1358 bytes --]

From 43ee011006562bac3091fbbe563df883460e98a6 Mon Sep 17 00:00:00 2001
Message-Id: <43ee011006562bac3091fbbe563df883460e98a6.1556173507.git.amit.kucheria@linaro.org>
In-Reply-To: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556173507.git.amit.kucheria@linaro.org>
References: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556173507.git.amit.kucheria@linaro.org>
From: Amit Kucheria <amit.kucheria@linaro.org>
Date: Thu, 25 Apr 2019 11:53:27 +0530
Subject: [PATCH 3/3] arm64: dts: msm8998: thermal: Restrict thermal zone name
 length to under 20

The thermal core restricts names of thermal zones to under 20
characters. Fix the names for a couple of msm8998 thermal zones.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 062a93a12198..01757829d5f3 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -536,7 +536,7 @@
 			};
 		};
 
-		cluster0-mhm-thermal {
+		clust0-mhm-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
@@ -551,7 +551,7 @@
 			};
 		};
 
-		cluster1-mhm-thermal {
+		clust1-mhm-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-- 
2.17.1


  reply	other threads:[~2019-04-25  6:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 10:12 [PATCH v2 00/13] qcom: dts: thermal cleanups Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 01/13] arm64: dts: msm8998: thermal: split address space into two Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 02/13] arm64: dts: msm8998: efficiency is not valid property Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 03/13] arm64: dts: msm8916: thermal: Add sensor for modem Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 04/13] arm64: dts: msm8996: thermal: Add temperature sensors near major peripherals Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 05/13] arm64: dts: msm8998: thermal: Fix the cpu sensor numbers Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 06/13] arm64: dts: msm8998: thermal: Fix the gpu sensor number Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 07/13] arm64: dts: msm8998: thermal: GPU has two sensors, add the second Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 08/13] arm64: dts: msm8998: thermal: Add temperature sensors near major peripherals Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 09/13] arm64: dts: sdm845: " Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 10/13] arm64: dts: msm8998: thermal: Make trip names consistent Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 11/13] arm64: dts: msm8916: " Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 12/13] arm64: dts: msm8996: " Amit Kucheria
2019-03-29 10:12 ` [PATCH v2 13/13] arm64: dts: msm8916: thermal: Convert camera trip type to hot Amit Kucheria
2019-04-02 13:58 ` [PATCH v2 00/13] qcom: dts: thermal cleanups Marc Gonzalez
2019-04-02 18:46   ` Amit Kucheria
2019-04-23  9:31     ` Marc Gonzalez
2019-04-23 12:56       ` Amit Kucheria
2019-04-23 13:10         ` Marc Gonzalez
2019-04-24 14:30           ` Marc Gonzalez
2019-04-25  6:31             ` Amit Kucheria [this message]
2019-04-25 11:25               ` Marc Gonzalez
2019-04-25 12:02               ` Marc Gonzalez
2019-04-25 13:06               ` Marc Gonzalez
2019-04-25 13:16                 ` Amit Kucheria
2019-04-23 19:14         ` Andy Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHLCerPj6MQ0LeqUHM_91NOW1cP0z75DD7oBnR7Q3-8rpCmnww@mail.gmail.com \
    --to=amit.kucheria@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=sibis@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).