From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Jung Daehwan <dh10.jung@samsung.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Howard Yen <howardyen@google.com>,
Jack Pham <jackp@codeaurora.org>, Puma Hsu <pumahsu@google.com>,
"J . Avila" <elavila@google.com>,
sc.suh@samsung.com,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH v4 5/5] usb: host: add xhci-exynos driver
Date: Thu, 28 Apr 2022 15:28:49 +0300 [thread overview]
Message-ID: <0f84e8d4-451f-693a-d098-517dc6235a0f@linux.intel.com> (raw)
In-Reply-To: <20220428030319.GA139938@ubuntu>
On 28.4.2022 6.03, Jung Daehwan wrote:
> On Wed, Apr 27, 2022 at 07:25:21PM +0300, Mathias Nyman wrote:
>> On 26.4.2022 12.18, Daehwan Jung wrote:
>>> This driver is for Samsung Exynos xhci host conroller. It uses xhci-plat
>>> driver mainly and extends some functions by xhci hooks and overrides.
>>>
>>> It supports USB Audio offload with Co-processor. It only cares DCBAA,
>>> Device Context, Transfer Ring, Event Ring, and ERST. They are allocated
>>> on specific address with xhci hooks. Co-processor could use them directly
>>> without xhci driver after then.
>>>
>>> Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
>>
>> I have to agree with Krzysztof's comments, this is an odd driver stub.
>>
>> Perhaps open up a bit how the Exynos offloading works so we can figure out
>> in more detail what the hardware needs from software.
>>
>> (...)
>
>>> +static int xhci_alloc_segments_for_ring_uram(struct xhci_hcd *xhci,
>>> + struct xhci_segment **first, struct xhci_segment **last,
>>> + unsigned int num_segs, unsigned int cycle_state,
>>> + enum xhci_ring_type type, unsigned int max_packet, gfp_t flags,
>>> + u32 endpoint_type)
>>> +{
>>> + struct xhci_segment *prev;
>>> + bool chain_links = false;
>>> +
>>> + while (num_segs > 0) {
>>> + struct xhci_segment *next = NULL;
>>> +
>>> + if (!next) {
>>> + prev = *first;
>>> + while (prev) {
>>> + next = prev->next;
>>> + xhci_segment_free(xhci, prev);
>>> + prev = next;
>>> + }
>>> + return -ENOMEM;
>>
>> This always return -ENOMEM
>
> Yes. it's right to return error here.
>
Still don't think that is the case.
So if the num_segs value passed to a function named
xhci_alloc_segments_for_ring_uram() is anything else than 0, it will
automatically return -ENOMEM?
>>
>> Also this whole function never allocates or remaps any memory.
>
> This fuctions is for link segments. Right below function(xhci_ring_alloc_uram)
> allocates.
Still doesn't allocate any ring segments.
Below function only allocates memory for the
ring structure that contains pointers to segments.
>
>>
>>> + }
>>> + xhci_link_segments(prev, next, type, chain_links);
>>> +
>>> + prev = next;
>>> + num_segs--;
>>> + }
>>> + xhci_link_segments(prev, *first, type, chain_links);
>>> + *last = prev;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static struct xhci_ring *xhci_ring_alloc_uram(struct xhci_hcd *xhci,
>>> + unsigned int num_segs, unsigned int cycle_state,
>>> + enum xhci_ring_type type, unsigned int max_packet, gfp_t flags,
>>> + u32 endpoint_type)
>>> +{
>>> + struct xhci_ring *ring;
>>> + int ret;
>>> + struct device *dev = xhci_to_hcd(xhci)->self.sysdev;
>>> +
>>> + ring = kzalloc_node(sizeof(*ring), flags, dev_to_node(dev));
>>> + if (!ring)
>>> + return NULL;
>>> +
>>> + ring->num_segs = num_segs;
>>> + ring->bounce_buf_len = max_packet;
>>> + INIT_LIST_HEAD(&ring->td_list);
>>> + ring->type = type;
>>> + if (num_segs == 0)
>>> + return ring;
>>> +
>>> + ret = xhci_alloc_segments_for_ring_uram(xhci, &ring->first_seg,
>>> + &ring->last_seg, num_segs, cycle_state, type,
>>> + max_packet, flags, endpoint_type);
>>> + if (ret)
>>> + goto fail;
>>> +
>>> + /* Only event ring does not use link TRB */
>>> + if (type != TYPE_EVENT) {
>>> + /* See section 4.9.2.1 and 6.4.4.1 */
>>> + ring->last_seg->trbs[TRBS_PER_SEGMENT - 1].link.control |=
>>> + cpu_to_le32(LINK_TOGGLE);
>>
>> No memory was allocated for trbs
>
> Allcation function for trbs are missed. It's done by ioremap.
> I will add it on next submission. Thanks for the comment.
>
>>
>> A lot of this code seems to exists just to avoid xhci driver from allocating
>> dma capable memory, we can refactor the existing xhci_mem_init() and move
>> dcbaa and event ring allocation and other code to their own overridable
>> functions.
>>
>> This way we can probably get rid of a lot of the code in this series.
>
> Yes right. I think it's proper. Do you agree with it or have better way
> to do it?
Could be, but I don't have a good picture of how this Exynos audio offloading
works, so it's hard to guess.
Thanks
-Mathias
next prev parent reply other threads:[~2022-04-28 12:27 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220426092019epcas2p2ef5dfde273edaaadc2ff74414f1b2c7a@epcas2p2.samsung.com>
2022-04-26 9:18 ` [PATCH v4 0/5] add xhci-exynos driver Daehwan Jung
[not found] ` <CGME20220426092021epcas2p4071f2b7621558a015579131990486a3c@epcas2p4.samsung.com>
2022-04-26 9:18 ` [PATCH v4 1/5] usb: host: export symbols for xhci-exynos to use xhci hooks Daehwan Jung
2022-04-26 9:54 ` Greg Kroah-Hartman
2022-04-26 10:27 ` Jung Daehwan
2022-04-26 10:31 ` Greg Kroah-Hartman
2022-04-26 18:40 ` Greg Kroah-Hartman
2022-04-28 3:30 ` Jung Daehwan
2022-04-26 16:02 ` kernel test robot
[not found] ` <CGME20220426092021epcas2p1a8d41039d9b3226f4e00f7d4bded833a@epcas2p1.samsung.com>
2022-04-26 9:18 ` [PATCH v4 2/5] usb: host: add xhci hooks for xhci-exynos Daehwan Jung
2022-04-26 10:19 ` Greg Kroah-Hartman
2022-04-27 9:06 ` Jung Daehwan
2022-04-27 9:19 ` Greg Kroah-Hartman
2022-04-28 3:23 ` Jung Daehwan
2022-04-28 5:30 ` Greg Kroah-Hartman
[not found] ` <CGME20220426092022epcas2p2da47c0c20feba6c96037e125289475f9@epcas2p2.samsung.com>
2022-04-26 9:18 ` [PATCH v4 3/5] usb: host: xhci-plat: support override of hc driver Daehwan Jung
2022-04-26 10:20 ` Greg Kroah-Hartman
2022-04-27 9:07 ` Jung Daehwan
[not found] ` <CGME20220426092022epcas2p2c016c83b21e41c7bcd4bdfbb95e464c0@epcas2p2.samsung.com>
2022-04-26 9:18 ` [PATCH v4 4/5] usb: host: add some to xhci overrides for xhci-exynos Daehwan Jung
2022-04-26 10:23 ` Greg Kroah-Hartman
2022-04-27 9:19 ` Jung Daehwan
2022-04-27 9:37 ` Greg Kroah-Hartman
[not found] ` <CGME20220426092023epcas2p32946c087135ca4b7e63b03915060c55d@epcas2p3.samsung.com>
2022-04-26 9:18 ` [PATCH v4 5/5] usb: host: add xhci-exynos driver Daehwan Jung
2022-04-26 10:20 ` Greg Kroah-Hartman
2022-04-28 3:26 ` Jung Daehwan
2022-04-26 10:21 ` Greg Kroah-Hartman
2022-04-27 9:24 ` Jung Daehwan
2022-04-27 9:37 ` Greg Kroah-Hartman
2022-04-26 12:59 ` Krzysztof Kozlowski
2022-04-28 1:29 ` Jung Daehwan
2022-04-28 5:19 ` Krzysztof Kozlowski
2022-04-28 6:36 ` Jung Daehwan
2022-04-28 6:45 ` Greg Kroah-Hartman
2022-04-28 7:45 ` Jung Daehwan
2022-04-28 7:31 ` Krzysztof Kozlowski
2022-04-28 7:53 ` Jung Daehwan
2022-04-28 8:26 ` Krzysztof Kozlowski
2022-04-26 17:55 ` kernel test robot
2022-04-27 16:25 ` Mathias Nyman
2022-04-28 3:03 ` Jung Daehwan
2022-04-28 12:28 ` Mathias Nyman [this message]
2022-05-03 8:41 ` Jung Daehwan
2022-04-28 5:15 ` Jung Daehwan
2022-04-26 10:19 ` [PATCH v4 0/5] " Greg Kroah-Hartman
2022-04-26 12:46 ` Krzysztof Kozlowski
2022-04-27 9:49 ` Jung Daehwan
2022-04-27 18:24 ` Krzysztof Kozlowski
2022-04-28 3:19 ` Jung Daehwan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f84e8d4-451f-693a-d098-517dc6235a0f@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=dh10.jung@samsung.com \
--cc=elavila@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=howardyen@google.com \
--cc=jackp@codeaurora.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pumahsu@google.com \
--cc=sc.suh@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).