From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Tim Chang <jia-wei.chang@mediatek.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, fan.chen@mediatek.com,
louis.yu@mediatek.com, roger.lu@mediatek.com,
Allen-yy.Lin@mediatek.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
hsinyi@google.com,
Jia-Wei Chang <jia-wei.chang@mediatek.corp-partner.google.com>
Subject: Re: [PATCH 3/4] cpufreq: mediatek: clean up cpufreq driver
Date: Mon, 7 Mar 2022 20:02:39 +0100 [thread overview]
Message-ID: <0fa44005-158b-74ee-f4ff-f2694ffce38a@canonical.com> (raw)
In-Reply-To: <20220307122151.11666-4-jia-wei.chang@mediatek.com>
On 07/03/2022 13:21, Tim Chang wrote:
> cleanup of naming, print log and comments.
>
> Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.corp-partner.google.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 487 ++++++++++++++---------------
> 1 file changed, 233 insertions(+), 254 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index 8e9d706d8081..3f00c7eb01f1 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -1,7 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (c) 2015 Linaro Ltd.
> - * Author: Pi-Cheng Chen <pi-cheng.chen@linaro.org>
> + * Copyright (C) 2022 MediaTek Inc.
Removal of authorship and existing copyrights does not fit into "clean
up". Please explain this thoroughly.
> */
>
> #include <linux/clk.h>
> @@ -22,7 +21,7 @@
> #define VOLT_TOL (10000)
>
> /*
> - * The struct mtk_cpu_dvfs_info holds necessary information for doing CPU DVFS
> + * The struct mtk_cpufreq_drv holds necessary information for doing CPU DVFS
> * on each CPU power/clock domain of Mediatek SoCs. Each CPU cluster in
> * Mediatek SoCs has two voltage inputs, Vproc and Vsram. In some cases the two
> * voltage inputs need to be controlled under a hardware limitation:
> @@ -32,7 +31,7 @@
> * needs to be switched to another stable PLL clock temporarily until
> * the original PLL becomes stable at target frequency.
> */
> -struct mtk_cpu_dvfs_info {
> +struct mtk_cpufreq_drv {
> struct cpumask cpus;
> struct device *cpu_dev;
> struct regulator *proc_reg;
> @@ -40,45 +39,45 @@ struct mtk_cpu_dvfs_info {
> struct clk *cpu_clk;
> struct clk *inter_clk;
> struct list_head list_head;
> - int intermediate_voltage;
> + int inter_voltage;
> bool need_voltage_tracking;
> - int old_vproc;
> - struct mutex lock; /* avoid notify and policy race condition */
> + int old_voltage;
> + struct mutex lock; /* avoid notify and policy race condition */
> struct notifier_block opp_nb;
> int opp_cpu;
> unsigned long opp_freq;
> };
>
> -static LIST_HEAD(dvfs_info_list);
> +static LIST_HEAD(drv_list);
>
> -static struct mtk_cpu_dvfs_info *mtk_cpu_dvfs_info_lookup(int cpu)
> +static struct mtk_cpufreq_drv *mtk_cpufreq_drv_lookup(int cpu)
> {
> - struct mtk_cpu_dvfs_info *info;
> + struct mtk_cpufreq_drv *drv;
>
> - list_for_each_entry(info, &dvfs_info_list, list_head) {
> - if (cpumask_test_cpu(cpu, &info->cpus))
> - return info;
> + list_for_each_entry(drv, &drv_list, list_head) {
> + if (cpumask_test_cpu(cpu, &drv->cpus))
> + return drv;> }
>
> return NULL;
> }
>
> -static int mtk_cpufreq_voltage_tracking(struct mtk_cpu_dvfs_info *info,
> - int new_vproc)
> +static int mtk_cpufreq_voltage_tracking(struct mtk_cpufreq_drv *drv,
> + int new_voltage)
> {
> - struct regulator *proc_reg = info->proc_reg;
> - struct regulator *sram_reg = info->sram_reg;
> - int old_vproc, old_vsram, new_vsram, vsram, vproc, ret;
> -
> - old_vproc = regulator_get_voltage(proc_reg);
> - if (old_vproc < 0) {
> - pr_err("%s: invalid Vproc value: %d\n", __func__, old_vproc);
> - return old_vproc;
> + struct regulator *proc_reg = drv->proc_reg;
> + struct regulator *sram_reg = drv->sram_reg;
> + int old_voltage, old_vsram, new_vsram, vsram, voltage, ret;
> +
> + old_voltage = regulator_get_voltage(proc_reg);
> + if (old_voltage < 0) {
> + pr_err("%s: invalid vproc value: %d\n", __func__, old_voltage);
> + return old_voltage;
Several different changes in one commit. Please read the document
"Submitting patches".
(...)
> -MODULE_AUTHOR("Pi-Cheng Chen <pi-cheng.chen@linaro.org>");
> +MODULE_AUTHOR("Jia-Wei Chang <jia-wei.chang@mediatek.com>");
Ekhm, why? He was not the author?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-07 19:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 12:21 [PATCH 0/4] cpufreq: mediatek: introduce mtk cpufreq Tim Chang
2022-03-07 12:21 ` [PATCH 1/4] dt-bindings: cpufreq: mediatek: transform cpufreq-mediatek into yaml Tim Chang
2022-03-07 18:57 ` Krzysztof Kozlowski
2022-03-24 9:38 ` Jia-Wei Chang
2022-03-24 10:33 ` Krzysztof Kozlowski
2022-04-01 13:26 ` Jia-Wei Chang
2022-04-01 16:32 ` Krzysztof Kozlowski
2022-04-06 8:42 ` Jia-Wei Chang
2022-04-08 3:14 ` Rex-BC Chen
2022-03-07 12:21 ` [PATCH 2/4] dt-bindings: cpufreq: mediatek: add mt8186 cpufreq dt-bindings Tim Chang
2022-03-07 18:59 ` Krzysztof Kozlowski
2022-03-24 9:42 ` Jia-Wei Chang
2022-03-24 10:35 ` Krzysztof Kozlowski
2022-04-01 13:32 ` Jia-Wei Chang
2022-03-10 20:44 ` Rob Herring
2022-04-06 12:49 ` Jia-Wei Chang
2022-03-07 12:21 ` [PATCH 3/4] cpufreq: mediatek: clean up cpufreq driver Tim Chang
2022-03-07 19:02 ` Krzysztof Kozlowski [this message]
2022-03-24 9:47 ` Jia-Wei Chang
2022-03-08 4:40 ` Viresh Kumar
2022-03-07 12:21 ` [PATCH 4/4] cpufreq: mediatek: add platform data and clean up voltage tracking logic Tim Chang
2022-03-07 19:03 ` Krzysztof Kozlowski
2022-03-24 9:49 ` Jia-Wei Chang
2022-03-08 4:36 ` [PATCH 0/4] cpufreq: mediatek: introduce mtk cpufreq Viresh Kumar
2022-04-08 3:55 ` Rex-BC Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fa44005-158b-74ee-f4ff-f2694ffce38a@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=Allen-yy.Lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=hsinyi@google.com \
--cc=jia-wei.chang@mediatek.com \
--cc=jia-wei.chang@mediatek.corp-partner.google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=louis.yu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).