From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Tim Chang <jia-wei.chang@mediatek.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <fan.chen@mediatek.com>,
<louis.yu@mediatek.com>, <roger.lu@mediatek.com>,
<Allen-yy.Lin@mediatek.com>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<hsinyi@google.com>
Subject: Re: [PATCH 0/4] cpufreq: mediatek: introduce mtk cpufreq
Date: Fri, 8 Apr 2022 11:55:03 +0800 [thread overview]
Message-ID: <a48c74e447c233799a497702fe90cfa126eb952a.camel@mediatek.com> (raw)
In-Reply-To: <20220308043615.uamxqylo3mvw4rhs@vireshk-i7>
On Tue, 2022-03-08 at 10:06 +0530, Viresh Kumar wrote:
> On 07-03-22, 20:21, Tim Chang wrote:
> > CPUFREQ is DVFS driver used for power saving by scaling clock
> > frequency
> > and supply voltage of CPUs. This module cooperates with CCI DEVFREQ
> > for
> > certain Mediatek SoCs.
>
> Both subject and this log talks as if you are adding a new cpufreq
> driver, while what you are doing is just cleanup mostly. This isn't
> how it should be done.
>
> You need to be very explicit with what you are doing and make that
> change in a separate patch. The cover letter should tell what you are
> doing and why.
>
Hello Viresh,
Thanks for your suggestion.
Indeed, the subject is not proper for this series.
I will help to upstream next version and fix the issue because of
resource issues.
Thanks.
BRs,
Rex
prev parent reply other threads:[~2022-04-08 3:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 12:21 [PATCH 0/4] cpufreq: mediatek: introduce mtk cpufreq Tim Chang
2022-03-07 12:21 ` [PATCH 1/4] dt-bindings: cpufreq: mediatek: transform cpufreq-mediatek into yaml Tim Chang
2022-03-07 18:57 ` Krzysztof Kozlowski
2022-03-24 9:38 ` Jia-Wei Chang
2022-03-24 10:33 ` Krzysztof Kozlowski
2022-04-01 13:26 ` Jia-Wei Chang
2022-04-01 16:32 ` Krzysztof Kozlowski
2022-04-06 8:42 ` Jia-Wei Chang
2022-04-08 3:14 ` Rex-BC Chen
2022-03-07 12:21 ` [PATCH 2/4] dt-bindings: cpufreq: mediatek: add mt8186 cpufreq dt-bindings Tim Chang
2022-03-07 18:59 ` Krzysztof Kozlowski
2022-03-24 9:42 ` Jia-Wei Chang
2022-03-24 10:35 ` Krzysztof Kozlowski
2022-04-01 13:32 ` Jia-Wei Chang
2022-03-10 20:44 ` Rob Herring
2022-04-06 12:49 ` Jia-Wei Chang
2022-03-07 12:21 ` [PATCH 3/4] cpufreq: mediatek: clean up cpufreq driver Tim Chang
2022-03-07 19:02 ` Krzysztof Kozlowski
2022-03-24 9:47 ` Jia-Wei Chang
2022-03-08 4:40 ` Viresh Kumar
2022-03-07 12:21 ` [PATCH 4/4] cpufreq: mediatek: add platform data and clean up voltage tracking logic Tim Chang
2022-03-07 19:03 ` Krzysztof Kozlowski
2022-03-24 9:49 ` Jia-Wei Chang
2022-03-08 4:36 ` [PATCH 0/4] cpufreq: mediatek: introduce mtk cpufreq Viresh Kumar
2022-04-08 3:55 ` Rex-BC Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a48c74e447c233799a497702fe90cfa126eb952a.camel@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Allen-yy.Lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=hsinyi@google.com \
--cc=jia-wei.chang@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=louis.yu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).