From: Bart Van Assche <bvanassche@acm.org>
To: "Asutosh Das (asd)" <quic_asutoshd@quicinc.com>,
John Garry <john.garry@huawei.com>,
Can Guo <quic_cang@quicinc.com>,
stanley.chu@mediatek.com, adrian.hunter@intel.com,
alim.akhtar@samsung.com, avri.altman@wdc.com, beanhuo@micron.com,
quic_nguyenb@quicinc.com, quic_ziqichen@quicinc.com,
linux-scsi@vger.kernel.org, kernel-team@android.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Daejun Park <daejun7.park@samsung.com>,
Jinyoung Choi <j-young.choi@samsung.com>,
Kiwoong Kim <kwmad.kim@samsung.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support
Date: Thu, 28 Jul 2022 13:29:24 -0700 [thread overview]
Message-ID: <10288041-8c3d-7e3a-9049-10b9fcd8baed@acm.org> (raw)
In-Reply-To: <ea33dee8-673c-0716-1640-28df7c983ca7@quicinc.com>
On 7/28/22 12:15, Asutosh Das (asd) wrote:
> Hello John,
>
> On 7/28/2022 12:10 PM, John Garry wrote:
>> On 19/07/2022 08:01, Can Guo wrote:
>>> +
>>> + hba->nr_queues[HCTX_TYPE_DEFAULT] = num_possible_cpus();
>>> + hba->nr_queues[HCTX_TYPE_READ] = 0;
>>> + hba->nr_queues[HCTX_TYPE_POLL] = 1;
>>> +
>>> + for (i = 0; i < HCTX_MAX_TYPES; i++)
>>> + host->nr_hw_queues += hba->nr_queues[i];
>>> +
>>> + host->can_queue = hba->nutrs;
>>> + host->cmd_per_lun = hba->nutrs;
>>> +
>>> + /* One more reserved for dev_cmd_queue */
>>> + hba->nr_hw_queues = host->nr_hw_queues + 1;
>>> +
>>
>> So this would mean that the host can accept .can_queue * .nr_hw_queues
>> numbers of requests simultaneously - is that true?
>
> That would mean that .can_queue * .nr_hw_queues numbers of request may
> be queued to the host.
> Please can you elaborate if you see an issue.
Hi Asutosh,
The `host_tagset` flag has been introduced by John and Hannes some time
ago. See also commit bdb01301f3ea ("scsi: Add host and host template
flag 'host_tagset'"). This flag supports sharing tags across hardware
queues and could be used to support UFSHCI 4.0 controllers that do not
support the EXT_IID feature.
In order not to complicate the implementation further, I propose to fall
back to the UFSHCI 3.0 compatibility mode for UFSHCI 4.0 controllers
that do not support the EXT_IID feature.
To answer John's question: the maximum number of outstanding commands is
16 * hba->nutrs if EXT_IID is supported (EXT_IID is a four bits field).
If the hardware queue index is encoded in the EXT_IID field, hba->nutrs
is the number of commands per hardware queue.
Thanks,
Bart.
next prev parent reply other threads:[~2022-07-28 20:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1658214120-22772-1-git-send-email-quic_cang@quicinc.com>
2022-07-19 7:01 ` [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support Can Guo
2022-07-19 23:01 ` Bart Van Assche
2022-07-19 23:07 ` Bart Van Assche
2022-07-20 17:34 ` Asutosh Das (asd)
2022-07-20 7:57 ` kernel test robot
2022-07-20 11:41 ` kernel test robot
2022-07-20 16:36 ` kernel test robot
2022-07-22 7:31 ` Avri Altman
2022-07-22 17:35 ` Asutosh Das (asd)
2022-07-22 19:37 ` Avri Altman
2022-07-22 20:14 ` Asutosh Das (asd)
2022-07-22 20:22 ` Avri Altman
2022-07-22 21:05 ` Asutosh Das (asd)
2022-07-22 17:58 ` Bart Van Assche
2022-07-26 6:48 ` Can Guo
2022-07-22 14:42 ` Avri Altman
2022-07-23 14:59 ` Avri Altman
2022-07-26 2:55 ` Can Guo
2022-07-23 15:26 ` Avri Altman
2022-07-24 3:14 ` Bart Van Assche
2022-07-25 16:24 ` Asutosh Das (asd)
2022-07-23 20:22 ` Avri Altman
2022-07-25 16:26 ` Asutosh Das (asd)
2022-07-25 19:50 ` Avri Altman
2022-07-25 20:24 ` Asutosh Das (asd)
2022-07-23 21:23 ` Avri Altman
2022-07-24 3:15 ` Bart Van Assche
2022-07-25 16:35 ` Asutosh Das (asd)
2022-07-26 22:47 ` Bart Van Assche
2022-07-24 4:07 ` Avri Altman
2022-07-25 16:38 ` Asutosh Das (asd)
2022-07-26 6:35 ` Can Guo
2022-07-26 9:46 ` Avri Altman
2022-07-24 4:32 ` Avri Altman
2022-07-26 6:21 ` Can Guo
2022-07-24 7:21 ` Avri Altman
2022-07-24 21:54 ` Bean Huo
2022-07-25 17:35 ` Asutosh Das (asd)
2022-07-25 9:16 ` Dan Carpenter
2022-07-28 19:10 ` John Garry
2022-07-28 19:15 ` Asutosh Das (asd)
2022-07-28 20:29 ` Bart Van Assche [this message]
2022-07-28 21:07 ` Asutosh Das (asd)
2022-07-29 16:43 ` Asutosh Das (asd)
2022-07-29 18:59 ` Bart Van Assche
2022-07-28 19:38 ` Bart Van Assche
2022-07-28 20:00 ` Asutosh Das (asd)
2022-07-19 7:01 ` [PATCH 2/2] scsi: ufs-qcom: Implement three CMQ related vops Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10288041-8c3d-7e3a-9049-10b9fcd8baed@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=daejun7.park@samsung.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=kernel-team@android.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).