linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@fenrus.demon.nl>
To: Jaroslav Kysela <perex@suse.cz>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA update [6/10] - 2002/07/20
Date: 29 Sep 2002 21:12:23 +0200	[thread overview]
Message-ID: <1033326744.2419.9.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.33.0209292050390.591-100000@pnote.perex-int.cz>

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

On Sun, 2002-09-29 at 20:51, Jaroslav Kysela wrote:
> +	sgbuf = snd_magic_cast(snd_pcm_sgbuf_t, substream->dma_private, return -EINVAL);

hummmm magic casts?? why ?

> +		ptr = snd_malloc_pci_pages(sgbuf->pci, PAGE_SIZE, &addr);

what is wrong with the PCI DMA API that makes ALSA wants a private
interface/implementation ?

>  EXPORT_SYMBOL(snd_wrapper_kmalloc);
>  EXPORT_SYMBOL(snd_wrapper_kfree);
> +EXPORT_SYMBOL(snd_wrapper_vmalloc);
> +EXPORT_SYMBOL(snd_wrapper_vfree);

why do you need a wrapper for vfree? 




[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2002-09-29 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-29 18:51 [PATCH] ALSA update [6/10] - 2002/07/20 Jaroslav Kysela
2002-09-29 19:12 ` Arjan van de Ven [this message]
2002-09-29 19:28   ` Jaroslav Kysela
2002-09-29 19:52     ` Jeff Garzik
2002-09-29 20:34       ` Jaroslav Kysela
2002-09-29 21:19         ` Alan Cox
2002-09-30  0:53         ` David S. Miller
2002-09-30 12:54           ` Alan Cox
2002-09-30 16:17             ` Jaroslav Kysela
2002-09-30 20:33             ` David S. Miller
2002-09-30  0:22   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1033326744.2419.9.camel@localhost.localdomain \
    --to=arjanv@fenrus.demon.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).