From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "David S. Miller" <davem@redhat.com>
Cc: perex@suse.cz, jgarzik@pobox.com, linux-kernel@vger.kernel.org,
alan@redhat.com
Subject: Re: [PATCH] ALSA update [6/10] - 2002/07/20
Date: 30 Sep 2002 13:54:11 +0100 [thread overview]
Message-ID: <1033390451.16337.33.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20020929.175311.97852433.davem@redhat.com>
On Mon, 2002-09-30 at 01:53, David S. Miller wrote:
> From: Jaroslav Kysela <perex@suse.cz>
> Date: Sun, 29 Sep 2002 22:34:51 +0200 (CEST)
>
> - if (hwdev == NULL || ((u32)hwdev->dma_mask != 0xffffffff))
> + if (hwdev == NULL || (u32)hwdev->dma_mask <= 0x00ffffff)
> gfp |= GFP_DMA;
>
> So alan, why is this really broken?
>
> EISA/ISA DMA is defined as using a hwdev of NULL or requiring
> <16MB address, he is preserving GFP_DMA in those cases.
Firstly the DMA mask on x86 can't be below 24bits, we don't support
allocation from a smaller zone. Secondly what about PCI for 25-31bits -
there we do need to force gfp_dma to have any chance of getting the
right pages
Giving the page allocator a mask argument does sound a lot nicer
next prev parent reply other threads:[~2002-09-30 12:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 18:51 [PATCH] ALSA update [6/10] - 2002/07/20 Jaroslav Kysela
2002-09-29 19:12 ` Arjan van de Ven
2002-09-29 19:28 ` Jaroslav Kysela
2002-09-29 19:52 ` Jeff Garzik
2002-09-29 20:34 ` Jaroslav Kysela
2002-09-29 21:19 ` Alan Cox
2002-09-30 0:53 ` David S. Miller
2002-09-30 12:54 ` Alan Cox [this message]
2002-09-30 16:17 ` Jaroslav Kysela
2002-09-30 20:33 ` David S. Miller
2002-09-30 0:22 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1033390451.16337.33.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).