From: "David S. Miller" <davem@redhat.com>
To: perex@suse.cz
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org, alan@redhat.com
Subject: Re: [PATCH] ALSA update [6/10] - 2002/07/20
Date: Sun, 29 Sep 2002 17:53:11 -0700 (PDT) [thread overview]
Message-ID: <20020929.175311.97852433.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0209292230500.591-100000@pnote.perex-int.cz>
From: Jaroslav Kysela <perex@suse.cz>
Date: Sun, 29 Sep 2002 22:34:51 +0200 (CEST)
- if (hwdev == NULL || ((u32)hwdev->dma_mask != 0xffffffff))
+ if (hwdev == NULL || (u32)hwdev->dma_mask <= 0x00ffffff)
gfp |= GFP_DMA;
So alan, why is this really broken?
EISA/ISA DMA is defined as using a hwdev of NULL or requiring
<16MB address, he is preserving GFP_DMA in those cases.
The only problem I have with the patch is that it probably isn't
that hard to let the page allocator take some MASK arg (defaults
to all 1's) to implement this in 2.5.x
next prev parent reply other threads:[~2002-09-30 0:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 18:51 [PATCH] ALSA update [6/10] - 2002/07/20 Jaroslav Kysela
2002-09-29 19:12 ` Arjan van de Ven
2002-09-29 19:28 ` Jaroslav Kysela
2002-09-29 19:52 ` Jeff Garzik
2002-09-29 20:34 ` Jaroslav Kysela
2002-09-29 21:19 ` Alan Cox
2002-09-30 0:53 ` David S. Miller [this message]
2002-09-30 12:54 ` Alan Cox
2002-09-30 16:17 ` Jaroslav Kysela
2002-09-30 20:33 ` David S. Miller
2002-09-30 0:22 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020929.175311.97852433.davem@redhat.com \
--to=davem@redhat.com \
--cc=alan@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).