From: James Bottomley <James.Bottomley@steeleye.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Intel Alder IOAPIC fix
Date: 12 Jan 2004 19:45:50 -0500 [thread overview]
Message-ID: <1073954751.4178.98.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.58.0401121452340.2031@evo.osdl.org>
OK, with the patch below (to insert_resource) I know get the IO APIC
successfully inserted under the reserved fixmap resources:
/proc/iomem still looks very odd:
fec00000-fec08fff : reserved
fec01000-fec013ff : 0000:00:0f.0
fffffc00-ffffffff : 0000:00:0f.0
fffffc00-ffffffff : 0000:00:0f.0
fffffc00-ffffffff : 0000:00:0f.0
fffffc00-ffffffff : 0000:00:0f.0
fffffc00-ffffffff : 0000:00:0f.0
ffe80000-ffffffff : reserved
unfortunately, because BARs 1-5 cover the same region.
I also think insert_resource needs to be fixed to insert these resources
*under* the reserved resource, since it's larger than they are.
I can make these changes and send them to you, if you think this is the
correct thing to do?
James
===== kernel/resource.c 1.18 vs edited =====
--- 1.18/kernel/resource.c Wed Nov 19 01:40:49 2003
+++ edited/kernel/resource.c Mon Jan 12 18:34:00 2004
@@ -318,6 +318,7 @@
struct resource *first, *next;
write_lock(&resource_lock);
+ begin:
first = __request_resource(parent, new);
if (!first)
goto out;
@@ -331,8 +332,10 @@
break;
/* existing resource overlaps end of new resource */
- if (next->end > new->end)
- goto out;
+ if (next->end > new->end) {
+ parent = next;
+ goto begin;
+ }
result = 0;
next prev parent reply other threads:[~2004-01-13 0:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 2:55 [PATCH] Intel Alder IOAPIC fix James Bottomley
2004-01-12 21:24 ` Linus Torvalds
2004-01-12 22:13 ` James Bottomley
2004-01-12 23:04 ` James Bottomley
2004-01-12 23:04 ` Linus Torvalds
2004-01-13 0:25 ` James Bottomley
2004-01-13 0:45 ` James Bottomley [this message]
2004-01-13 0:25 ` Linus Torvalds
2004-01-13 16:52 ` James Bottomley
2004-01-15 5:18 ` Eric W. Biederman
2004-01-15 16:58 ` James Bottomley
2004-01-15 19:26 ` Eric W. Biederman
2004-01-15 19:54 ` James Bottomley
2004-01-16 5:32 ` Eric W. Biederman
2004-01-17 15:18 ` James Bottomley
2004-01-17 19:43 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1073954751.4178.98.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).