From: Linus Torvalds <torvalds@osdl.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Intel Alder IOAPIC fix
Date: Mon, 12 Jan 2004 15:04:58 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0401121452340.2031@evo.osdl.org> (raw)
In-Reply-To: <1073948641.4178.76.camel@mulgrave>
On Mon, 12 Jan 2004, James Bottomley wrote:
>
> So BAR0 is actually the location of the second I/O APIC's mapped address
> range (which we've already covered with a fixmap from the MP TABLE).
> I've no idea what the other four BARs all with addresses at 0xfffffc00
> are doing.
>
> The only way to prevent the current code (in arch/i386/pci/i386.c) from
> reassigning this range seems to be to set the resource start to zero.
Ok. What I think we should do is to have a special quirk for chips like
this that just _force_ the BAR values into the resource allocation table,
and ignore things like the existing BIOS-marked allocations - because
obviously the BIOS-marked ones are going to overlap.
This is where that "insert_resource()" thing comes in. Something like this
might just work as a quirk:
adler_quirk(struct pci_dev *dev)
{
int i;
for (i = 0; i < 6; i++) {
if (!pci_resource_start(dev, i))
continue;
if (!pci_resource_len(dev, i))
continue;
insert_resource(&iomem_resource, dev->resource + i);
}
}
and then make sure that the PCI layer doesn't try to re-allocate the
resource some other way (I forget - maybe it already notices when the
resource has already been inserted into the resource tree - otherwise you
might need to add the code that says "if this resource is already
inserted, don't try to reallocate it").
Linus
next prev parent reply other threads:[~2004-01-12 23:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 2:55 [PATCH] Intel Alder IOAPIC fix James Bottomley
2004-01-12 21:24 ` Linus Torvalds
2004-01-12 22:13 ` James Bottomley
2004-01-12 23:04 ` James Bottomley
2004-01-12 23:04 ` Linus Torvalds [this message]
2004-01-13 0:25 ` James Bottomley
2004-01-13 0:45 ` James Bottomley
2004-01-13 0:25 ` Linus Torvalds
2004-01-13 16:52 ` James Bottomley
2004-01-15 5:18 ` Eric W. Biederman
2004-01-15 16:58 ` James Bottomley
2004-01-15 19:26 ` Eric W. Biederman
2004-01-15 19:54 ` James Bottomley
2004-01-16 5:32 ` Eric W. Biederman
2004-01-17 15:18 ` James Bottomley
2004-01-17 19:43 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0401121452340.2031@evo.osdl.org \
--to=torvalds@osdl.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).