From: James Bottomley <James.Bottomley@steeleye.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Intel Alder IOAPIC fix
Date: 15 Jan 2004 11:58:10 -0500 [thread overview]
Message-ID: <1074185897.1868.118.camel@mulgrave> (raw)
In-Reply-To: <m1smihg56u.fsf@ebiederm.dsl.xmission.com>
On Thu, 2004-01-15 at 00:18, Eric W. Biederman wrote:
> James Bottomley <James.Bottomley@steeleye.com> writes:
>
> > On Mon, 2004-01-12 at 19:25, Linus Torvalds wrote:
> > > I think BARs 1-5 don't exist at all. Being set to all ones is common for
> > > "unused" (it ends up being a normal result of a lazy probe - you set all
> > > bits to 1 to check for the size of the region, and if you decide not to
> > > map it and leave it there, you'll get the above behaviour).
> > >
> > > I suspect only BAR0 is actually real.
> >
> > OK, I cleaned up the patch to forcibly insert BAR0 and clear BARs 1-5
> > (it still requires changes to insert_resource to work, though).
>
> When I looked at the ia64 code that uses insert_resource (and I admit I am
> reading between the lines a little) it seems to come along after potentially
> allocating some resources behind some kind of bridge and then realize a bridge
> is there.
Ah, that explains why it's expecting to find the new resource covering
the old one.
> Which is totally something different from this case where we just want
> to ignore the BIOS, because we know better. I have seen a number of
> boxes that reserver the area where apics or ioapics live. So I think
> we need an IORESOURCE_TENTATIVE thing. This is the third flavor of
> thing that has shown up, lately.
>
> Want me to code up a patch?
Well, I'm not sure there's a need for it. It seems to me that all
insert_resource is supposed to be doing is saying "I've got this
resource here that should have been placed into the tree...please do it
now".
The ia64 I forgot this bridge, and the Alder IO-APIC this PCI BAR is
actually the IO-APIC and thus part of the reserved BIOS area look to be
similar aspects of the same problem.
The only difference (which is what I needed the patch for) was that the
Alder resource needs to go underneath the bios reserved area.
How are you proposing that IORESOURCE_TENTATIVE should work?
James
next prev parent reply other threads:[~2004-01-15 16:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 2:55 [PATCH] Intel Alder IOAPIC fix James Bottomley
2004-01-12 21:24 ` Linus Torvalds
2004-01-12 22:13 ` James Bottomley
2004-01-12 23:04 ` James Bottomley
2004-01-12 23:04 ` Linus Torvalds
2004-01-13 0:25 ` James Bottomley
2004-01-13 0:45 ` James Bottomley
2004-01-13 0:25 ` Linus Torvalds
2004-01-13 16:52 ` James Bottomley
2004-01-15 5:18 ` Eric W. Biederman
2004-01-15 16:58 ` James Bottomley [this message]
2004-01-15 19:26 ` Eric W. Biederman
2004-01-15 19:54 ` James Bottomley
2004-01-16 5:32 ` Eric W. Biederman
2004-01-17 15:18 ` James Bottomley
2004-01-17 19:43 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1074185897.1868.118.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).