From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: jgarzik@pobox.com
Subject: Re: [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c
Date: Fri, 07 Jan 2005 15:46:05 +0000 [thread overview]
Message-ID: <1105111759.17166.350.camel@localhost.localdomain> (raw)
In-Reply-To: <200501070309.j0739IG6007753@hera.kernel.org>
On Llu, 2004-12-27 at 20:18, Linux Kernel Mailing List wrote:
> ChangeSet 1.1938.455.1, 2004/12/27 15:18:56-05:00, penguin@muskoka.com
>
> [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c
>
> The 8390 driver had been fixed for leaking information in short packets
> prior to skb_padto() existing. This change gets rid of the scratch area on
> the stack and makes it use skb_padto(). Thanks to Mark Smith for bringing
> this to my attention.
>
> Signed-off-by: Paul Gortmaker <p_gortmaker@yahoo.com>
> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
This was done because it benchmarked materially faster than the
skb_padto version you just reverted. Its only 64 bytes on the stack and
its cached.
ie the old 8390 code was quite intentional and done because it commonly
occurs on very old machines where clock count matters. Because of its
commonness I actually hand optimised this one when I did the original
fixes to avoid doing extra memory allocations.
Summary: Please revert.
Alan
next parent reply other threads:[~2005-01-07 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200501070309.j0739IG6007753@hera.kernel.org>
2005-01-07 15:46 ` Alan Cox [this message]
[not found] <41DED9FA.7080106@pobox.com>
2005-01-08 8:33 ` [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c] Paul Gortmaker
2005-01-08 15:45 ` Alan Cox
2005-01-10 2:41 ` [PATCH] 2.6.9 Use skb_padto() in drivers/net/8390.c Paul Gortmaker
2005-01-10 18:28 ` Alan Cox
2005-02-19 5:20 ` Jeff Garzik
2005-02-19 14:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105111759.17166.350.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).