From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andi Kleen <ak@suse.de>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] page table iterators
Date: Fri, 18 Feb 2005 09:49:37 +1100 [thread overview]
Message-ID: <1108680578.5665.14.camel@gaston> (raw)
In-Reply-To: <20050217194336.GA8314@wotan.suse.de>
On Thu, 2005-02-17 at 20:43 +0100, Andi Kleen wrote:
> On Fri, Feb 18, 2005 at 01:03:35AM +1100, Nick Piggin wrote:
> > I am pretty surprised myself that I was able to consolidate
> > all "page table range" functions into a single type of iterator
> > (well, there are a couple of variations, but it's not too bad).
>
> I started a similar project - but it uses the existing loops,
> just using {pte,pmd,pud,pgd}_next. The idea is to optimize
> page table walking by keeping some state in the struct page
> of the page table page that says whether an entry is set
> or not. To make this work I switched everything to indexes
> instead of pointers.
>
> Main problem are some nasty include loops.
I though about both ways yesterday, and in the end, I prefer Nick stuff,
at least for now. It gives us also more flexibility to change gory
implementation details in the future. I still have to run it through a
bit of torture testing though.
Ben.
next prev parent reply other threads:[~2005-02-17 22:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 13:53 [PATCH 1/2] optimise copy page range Nick Piggin
2005-02-17 14:03 ` [PATCH 2/2] page table iterators Nick Piggin
2005-02-17 15:56 ` Linus Torvalds
2005-02-17 16:13 ` Nick Piggin
2005-02-17 19:43 ` Andi Kleen
2005-02-17 22:49 ` Benjamin Herrenschmidt [this message]
2005-02-17 23:03 ` Andi Kleen
2005-02-17 23:21 ` Benjamin Herrenschmidt
2005-02-17 23:34 ` Andi Kleen
2005-02-17 23:30 ` David S. Miller
2005-02-17 23:57 ` Andi Kleen
2005-02-20 12:35 ` Nick Piggin
2005-02-21 6:35 ` Hugh Dickins
2005-02-21 6:40 ` Andrew Morton
2005-02-21 7:09 ` Benjamin Herrenschmidt
2005-02-21 8:09 ` Nick Piggin
2005-02-21 9:04 ` Nick Piggin
2005-02-22 9:54 ` Nick Piggin
2005-02-23 2:06 ` Hugh Dickins
2005-02-23 4:31 ` David S. Miller
2005-02-23 4:49 ` Nick Piggin
2005-02-23 4:57 ` David S. Miller
2005-02-23 5:23 ` Nick Piggin
2005-02-23 23:52 ` Nick Piggin
2005-02-24 0:00 ` David S. Miller
2005-02-24 5:12 ` Hugh Dickins
2005-02-24 5:59 ` Nick Piggin
2005-02-24 11:58 ` Hugh Dickins
2005-02-24 19:33 ` David S. Miller
2005-02-25 10:44 ` Andi Kleen
2005-02-24 21:59 ` Nick Piggin
2005-02-24 22:32 ` Hugh Dickins
2005-02-24 22:52 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1108680578.5665.14.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).