From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: Hugh Dickins <hugh@veritas.com>,
ak@suse.de, benh@kernel.crashing.org, torvalds@osdl.org,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] page table iterators
Date: Wed, 23 Feb 2005 15:49:30 +1100 [thread overview]
Message-ID: <1109134170.5177.9.camel@npiggin-nld.site> (raw)
In-Reply-To: <20050222203115.49f79f42.davem@davemloft.net>
On Tue, 2005-02-22 at 20:31 -0800, David S. Miller wrote:
> On Wed, 23 Feb 2005 02:06:28 +0000 (GMT)
> Hugh Dickins <hugh@veritas.com> wrote:
>
> > I've not seen Dave's bitmap walking functions (for clearing?),
> > would they fit in better with my way?
>
Hugh: I'll have more of a look through your patch when I get
some time... to be honest I'm not too worried either way, so
long as one or the other gets in.
Very trivial point, but I'm not sure that I like the name
p?d_limit... maybe p?d_span or _span_end... hmm, they're not
really pleasing either.
You _are_ repeating a bit of mindless loop accounting in every
page table walk, and it isn't completely clear to me that it is
giving you much more flexibility (than for_each_*). But my loops
_are_ a bit contorted.
> This is what Nick is referring to:
>
[snip]
> It's easy to toy with the sparc64 optimization on other platforms,
> just add the necessary hacks to pmd_set and pgd_set, allocation
> of pmd and pgd tables
David: just an implementation detail that I had meant to bring
up earlier - would it feel like less of a hack to put these in
pmd_populate and pgd_populate?
Nick
next prev parent reply other threads:[~2005-02-23 4:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 13:53 [PATCH 1/2] optimise copy page range Nick Piggin
2005-02-17 14:03 ` [PATCH 2/2] page table iterators Nick Piggin
2005-02-17 15:56 ` Linus Torvalds
2005-02-17 16:13 ` Nick Piggin
2005-02-17 19:43 ` Andi Kleen
2005-02-17 22:49 ` Benjamin Herrenschmidt
2005-02-17 23:03 ` Andi Kleen
2005-02-17 23:21 ` Benjamin Herrenschmidt
2005-02-17 23:34 ` Andi Kleen
2005-02-17 23:30 ` David S. Miller
2005-02-17 23:57 ` Andi Kleen
2005-02-20 12:35 ` Nick Piggin
2005-02-21 6:35 ` Hugh Dickins
2005-02-21 6:40 ` Andrew Morton
2005-02-21 7:09 ` Benjamin Herrenschmidt
2005-02-21 8:09 ` Nick Piggin
2005-02-21 9:04 ` Nick Piggin
2005-02-22 9:54 ` Nick Piggin
2005-02-23 2:06 ` Hugh Dickins
2005-02-23 4:31 ` David S. Miller
2005-02-23 4:49 ` Nick Piggin [this message]
2005-02-23 4:57 ` David S. Miller
2005-02-23 5:23 ` Nick Piggin
2005-02-23 23:52 ` Nick Piggin
2005-02-24 0:00 ` David S. Miller
2005-02-24 5:12 ` Hugh Dickins
2005-02-24 5:59 ` Nick Piggin
2005-02-24 11:58 ` Hugh Dickins
2005-02-24 19:33 ` David S. Miller
2005-02-25 10:44 ` Andi Kleen
2005-02-24 21:59 ` Nick Piggin
2005-02-24 22:32 ` Hugh Dickins
2005-02-24 22:52 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109134170.5177.9.camel@npiggin-nld.site \
--to=nickpiggin@yahoo.com.au \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).