linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree
Date: Thu, 19 Jan 2006 16:21:59 +1100	[thread overview]
Message-ID: <1137648119.30084.94.camel@localhost.localdomain> (raw)
In-Reply-To: <200601190052.k0J0qmKC009977@shell0.pdx.osdl.net>

On Wed, 2006-01-18 at 16:52 -0800, akpm@osdl.org wrote:
> -                       memcpy(&current->saved_sigmask, &sigsaved, sizeof(sigsaved));
> +                       memcpy(&current->saved_sigmask, &sigsaved,
> +                                       sizeof(sigsaved));

I still object to this.

You justified it on the basis that some people have editors which will
wrap the original version onto a second line and make it look ugly...
yet your 'fix' is to wrap it onto a second line and make it look ugly
for _all_ of us, not just for those using crap editors. I really don't
see the overall benefit.

-- 
dwmw2


       reply	other threads:[~2006-01-19  5:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200601190052.k0J0qmKC009977@shell0.pdx.osdl.net>
2006-01-19  5:21 ` David Woodhouse [this message]
2006-01-19  6:17   ` - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree Stephen Rothwell
2006-01-19  6:24     ` David Woodhouse
2006-01-19  6:30     ` Andrew Morton
2006-01-19  6:40       ` David Woodhouse
2006-01-19  6:36     ` David S. Miller
2006-01-19  6:47       ` Trond Myklebust
2006-01-19  7:02         ` Andrew Morton
2006-01-19  7:18           ` David Woodhouse
2006-01-19  8:09           ` David S. Miller
2006-01-19 15:51       ` James Morris
2006-01-20  2:17       ` Stephen Rothwell
2006-01-19  9:58     ` Alan Cox
2006-01-19 15:59       ` Jens Axboe
2006-01-20  8:33         ` David Woodhouse
2006-01-20  8:44           ` Andrew Morton
2006-01-20  8:59             ` David Woodhouse
2006-01-20 10:01               ` Eric Dumazet
2006-01-23  5:25                 ` David Woodhouse
2006-01-20 23:44               ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1137648119.30084.94.camel@localhost.localdomain \
    --to=dwmw2@infradead.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).