From: Andrew Morton <akpm@osdl.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: axboe@suse.de, alan@lxorguk.ukuu.org.uk, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org
Subject: Re: - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree
Date: Fri, 20 Jan 2006 00:44:56 -0800 [thread overview]
Message-ID: <20060120004456.190f451b.akpm@osdl.org> (raw)
In-Reply-To: <1137745995.30084.201.camel@localhost.localdomain>
David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Thu, 2006-01-19 at 16:59 +0100, Jens Axboe wrote:
> > I think the CodingStyle suggestion of 80 chars is just fine. I try to
> > stay within that, and I mostly succeed. The occasional over-the-line is
> > far better than advocation >> 80 chars per line imho.
>
> I agree. It's that "occasional over-the-line" which Andrew is mucking
> about with in the patch which started this thread; the case where it
> makes _sense_ to let it go over 80 characters rather than wrapping it.
>
Oh crap. The damn thing wraps into column _1_ and gets tangled up with
ifdef statements, function definitions and other things which _should_ go
in column one.
It .looks. .like. .crap. to many other people, and saying random stupid
wrong things doesn't alter that very simple fact.
next prev parent reply other threads:[~2006-01-20 8:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200601190052.k0J0qmKC009977@shell0.pdx.osdl.net>
2006-01-19 5:21 ` - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree David Woodhouse
2006-01-19 6:17 ` Stephen Rothwell
2006-01-19 6:24 ` David Woodhouse
2006-01-19 6:30 ` Andrew Morton
2006-01-19 6:40 ` David Woodhouse
2006-01-19 6:36 ` David S. Miller
2006-01-19 6:47 ` Trond Myklebust
2006-01-19 7:02 ` Andrew Morton
2006-01-19 7:18 ` David Woodhouse
2006-01-19 8:09 ` David S. Miller
2006-01-19 15:51 ` James Morris
2006-01-20 2:17 ` Stephen Rothwell
2006-01-19 9:58 ` Alan Cox
2006-01-19 15:59 ` Jens Axboe
2006-01-20 8:33 ` David Woodhouse
2006-01-20 8:44 ` Andrew Morton [this message]
2006-01-20 8:59 ` David Woodhouse
2006-01-20 10:01 ` Eric Dumazet
2006-01-23 5:25 ` David Woodhouse
2006-01-20 23:44 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060120004456.190f451b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).