From: David Woodhouse <dwmw2@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: axboe@suse.de, alan@lxorguk.ukuu.org.uk, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org
Subject: Re: - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree
Date: Fri, 20 Jan 2006 21:59:54 +1300 [thread overview]
Message-ID: <1137747595.30084.215.camel@localhost.localdomain> (raw)
In-Reply-To: <20060120004456.190f451b.akpm@osdl.org>
On Fri, 2006-01-20 at 00:44 -0800, Andrew Morton wrote:
> Oh crap. The damn thing wraps into column _1_ and gets tangled up with
> ifdef statements, function definitions and other things which _should_ go
> in column one.
It does that only for people with editors which wrap stuff like that
into column 1. Those people (which includes myself on some occasions)
are _used_ to seeing stuff like that in column 1, so it's natural. And
it's text which is of little importance; not something which has much
relevance to the code flow.
> It .looks. .like. .crap. to many other people, and saying random stupid
> wrong things doesn't alter that very simple fact.
No, it looks like crap for _some_ people. And making it look like crap
for _everyone_, which is what your patch does, doesn't alter that fact
either.
It's a simple memcpy(dest, src, len), and the length is almost entirely
superfluous -- we could almost get away with '*dest = *src' here. It
lives on a single line and is messy any other way, and you want to muck
about with it just because there are some poor sods out there for whom
it would look _slightly_ better if you make it look like crap for the
rest of us.
I'm not advocating a blanket removal of the 80-character limit;
important things should always be within 80 columns. But this is fluff;
leave it where it is, please.
--
dwmw2
next prev parent reply other threads:[~2006-01-20 8:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200601190052.k0J0qmKC009977@shell0.pdx.osdl.net>
2006-01-19 5:21 ` - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree David Woodhouse
2006-01-19 6:17 ` Stephen Rothwell
2006-01-19 6:24 ` David Woodhouse
2006-01-19 6:30 ` Andrew Morton
2006-01-19 6:40 ` David Woodhouse
2006-01-19 6:36 ` David S. Miller
2006-01-19 6:47 ` Trond Myklebust
2006-01-19 7:02 ` Andrew Morton
2006-01-19 7:18 ` David Woodhouse
2006-01-19 8:09 ` David S. Miller
2006-01-19 15:51 ` James Morris
2006-01-20 2:17 ` Stephen Rothwell
2006-01-19 9:58 ` Alan Cox
2006-01-19 15:59 ` Jens Axboe
2006-01-20 8:33 ` David Woodhouse
2006-01-20 8:44 ` Andrew Morton
2006-01-20 8:59 ` David Woodhouse [this message]
2006-01-20 10:01 ` Eric Dumazet
2006-01-23 5:25 ` David Woodhouse
2006-01-20 23:44 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137747595.30084.215.camel@localhost.localdomain \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).