[RFC][PATCH 4/6] slim: secfs patch

[RFC][PATCH 4/6] slim: secfs patch

[Kylene Jo Hall]

This patch provides the securityfs used by SLIM.

Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
--- 
 security/slim/slm_secfs.c |   67 ++++++++++++++++++++++++++++++++++++
 1 files changed, 67 insertions(+)

--- linux-2.6.18/security/slim/slm_secfs.c	1969-12-31 18:00:00.000000000 -0600
+++ linux-2.6.18-rc1-dbg/security/slim/slm_secfs.c	2006-07-21 15:36:12.000000000 -0500
@@ -0,0 +1,67 @@
+/*
+ * SLIM securityfs support: debugging control files
+ *
+ * Copyright (C) 2005, 2006 IBM Corporation
+ * Author: Mimi Zohar <zohar@us.ibm.com>
+ *	   Kylene Hall <kjhall@us.ibm.com>
+ *
+ *      This program is free software; you can redistribute it and/or modify
+ *      it under the terms of the GNU General Public License as published by
+ *      the Free Software Foundation, version 2 of the License.
+ */
+
+#include <asm/uaccess.h>
+#include <linux/config.h>
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/security.h>
+#include <linux/debugfs.h>
+#include "slim.h"
+
+static struct dentry *slim_sec_dir, *slim_level;
+
+static ssize_t slm_read_level(struct file *file, char __user *buf,
+			      size_t buflen, loff_t *ppos)
+{
+	struct slm_tsec_data *cur_tsec = current->security;
+	ssize_t len;
+	char data[28]; 
+	if (is_kernel_thread(current))
+		len = snprintf(data, sizeof(data), "KERNEL\n");
+	else if (!cur_tsec)
+		len = snprintf(data, sizeof(data), "UNKNOWN\n");
+	else {
+		if (cur_tsec->iac_wx != cur_tsec->iac_r)
+			len = snprintf(data, sizeof(data), "GUARD wx:%s r:%s\n",
+				      slm_iac_str[cur_tsec->iac_wx],
+				      slm_iac_str[cur_tsec->iac_r]);
+		else
+			len = snprintf(data, sizeof(data), "%s\n",
+				      slm_iac_str[cur_tsec->iac_wx]);
+	}
+	return simple_read_from_buffer(buf, buflen, ppos, data, len);
+}
+
+static struct file_operations slm_level_ops = {
+	.read = slm_read_level,
+};
+
+int __init slm_init_secfs(void)
+{
+	slim_sec_dir = securityfs_create_dir("slim", NULL);
+	if (!slim_sec_dir || IS_ERR(slim_sec_dir))
+		return -EFAULT;
+	slim_level = securityfs_create_file("level", S_IRUGO,
+					    slim_sec_dir, NULL, &slm_level_ops);
+	if (!slim_level || IS_ERR(slim_level)) {
+		securityfs_remove(slim_sec_dir);
+		return -EFAULT;
+	}
+	return 0;
+}
+
+void __exit slm_cleanup_secfs(void)
+{
+	securityfs_remove(slim_level);
+	securityfs_remove(slim_sec_dir);
+}

Re: [RFC][PATCH 4/6] slim: secfs patch

[Dave Hansen]

On Fri, 2006-07-14 at 10:24 -0700, Kylene Jo Hall wrote:
> 
> +static ssize_t slm_read_level(struct file *file, char __user *buf,
> +                             size_t buflen, loff_t *ppos)
> +{
> +       struct slm_tsec_data *cur_tsec = current->security;
> +       ssize_t len;
> +       char *page = (char *)__get_free_page(GFP_KERNEL); 

Do you really need a page here?  Why not just use kmalloc()?

-- Dave

[RFC][PATCH 4/6] slim: secfs patch

[Kylene Jo Hall]

This patch provides the securityfs used by SLIM.

Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
--- 
 security/slim/slm_secfs.c |   73 ++++++++++++++++++++++++++++++++++++
 1 files changed, 73 insertions(+)

--- linux-2.6.17/security/slim/slm_secfs.c	1969-12-31 16:00:00.000000000 -0800
+++ linux-2.6.17/security/slim/slm_secfs.c	2006-07-13 16:28:17.000000000 -0700
@@ -0,0 +1,73 @@
+/*
+ * SLIM securityfs support: debugging control files
+ *
+ * Copyright (C) 2005, 2006 IBM Corporation
+ * Author: Mimi Zohar <zohar@us.ibm.com>
+ *	   Kylene Hall <kjhall@us.ibm.com>
+ *
+ *      This program is free software; you can redistribute it and/or modify
+ *      it under the terms of the GNU General Public License as published by
+ *      the Free Software Foundation, version 2 of the License.
+ */
+
+#include <asm/uaccess.h>
+#include <linux/config.h>
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/security.h>
+#include <linux/debugfs.h>
+#include "slim.h"
+
+static struct dentry *slim_sec_dir, *slim_level;
+
+static ssize_t slm_read_level(struct file *file, char __user *buf,
+			      size_t buflen, loff_t *ppos)
+{
+	struct slm_tsec_data *cur_tsec = current->security;
+	ssize_t len;
+	char *page = (char *)__get_free_page(GFP_KERNEL);
+	
+	if (!page)
+		return -ENOMEM;
+
+	if (is_kernel_thread(current))
+		len = sprintf(page, "level: KERNEL\n");
+	else if (!cur_tsec)
+		len = sprintf(page, "level: UNKNOWN\n");
+	else {
+		if (cur_tsec->iac_wx != cur_tsec->iac_r)
+			len = sprintf(page, "level: GUARD wx:%s r:%s\n",
+				      slm_iac_str[cur_tsec->iac_wx],
+				      slm_iac_str[cur_tsec->iac_r]);
+		else
+			len = sprintf(page, "level: %s\n",
+				      slm_iac_str[cur_tsec->iac_wx]);
+	}
+	len = simple_read_from_buffer(buf, buflen, ppos, page, len);
+	free_page((unsigned long)page);
+	return len;
+}
+
+static struct file_operations slm_level_ops = {
+	.read = slm_read_level,
+};
+
+int __init slm_init_secfs(void)
+{
+	slim_sec_dir = securityfs_create_dir("slim", NULL);
+	if (!slim_sec_dir || IS_ERR(slim_sec_dir))
+		return -EFAULT;
+	slim_level = securityfs_create_file("level", S_IRUGO,
+					    slim_sec_dir, NULL, &slm_level_ops);
+	if (!slim_level || IS_ERR(slim_level)) {
+		securityfs_remove(slim_sec_dir);
+		return -EFAULT;
+	}
+	return 0;
+}
+
+void __exit slm_cleanup_secfs(void)
+{
+	securityfs_remove(slim_level);
+	securityfs_remove(slim_sec_dir);
+}