linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>, catalin.marinas@arm.com
Cc: dhowells@redhat.com, akpm@linux-foundation.org, sam@ravnborg.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] FRV: Move to arch/frv/include/asm/
Date: Thu, 09 Apr 2009 22:51:37 +0100	[thread overview]
Message-ID: <12327.1239313897@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0904091412060.4583@localhost.localdomain>

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> Ahh. I've never used stg. It seems to have some bad defaults.
> 
> Also, depending on exactly what "stg" does, it is entirely possible that 
> adding that
> 
> 	[diff]
> 		renames
> 
> to your .gitconfig won't help: those kinds of default configuration values 
> are (very much on purpose) ignored for certain low-level git commands, 
> exactly so that you can do reliable scripting without having to worry 
> about some user-specific config files.

That affects 'stg show' but not 'stg mail'.


It looks like 'stg mail' is generating the stats with git-apply on the results
of a diff:

	def diffstat(files = None, rev1 = 'HEAD', rev2 = None):
	    """Return the diffstat between rev1 and rev2."""
	    return GRun('apply', '--stat', '--summary'
			).raw_input(diff(files, rev1, rev2)).raw_output()

which seems to mean that I can't reduce them from the:

 arch/frv/include/asm/Kbuild              |    5 
 arch/frv/include/asm/atomic.h            |  198 +++++++++++
 arch/frv/include/asm/auxvec.h            |    4 
 arch/frv/include/asm/ax88796.h           |   22 +
 arch/frv/include/asm/bitops.h            |  412 +++++++++++++++++++++++
 arch/frv/include/asm/bug.h               |   53 +++
 ...
 include/asm-frv/Kbuild                   |    5 
 include/asm-frv/atomic.h                 |  198 -----------
 include/asm-frv/auxvec.h                 |    4 
 include/asm-frv/ax88796.h                |   22 -
 include/asm-frv/bitops.h                 |  412 -----------------------
 include/asm-frv/bug.h                    |   53 ---
 ...

to the:

 {include/asm-frv => arch/frv/include/asm}/Kbuild   |    0
 {include/asm-frv => arch/frv/include/asm}/atomic.h |    0
 {include/asm-frv => arch/frv/include/asm}/auxvec.h |    0
 .../asm-frv => arch/frv/include/asm}/ax88796.h     |    0
 {include/asm-frv => arch/frv/include/asm}/bitops.h |    0
 {include/asm-frv => arch/frv/include/asm}/bug.h    |    0

though it is using git-diff-tree to generate the rest of the patch, which I
can affect with the diff options, it would appear.

Is there a way to get git-diff to produce just the stats and summary and not
the body of the patch?

David

  parent reply	other threads:[~2009-04-09 21:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-09 16:32 [PATCH 1/2] FRV: Use <asm-generic/pgtable.h> in NOMMU mode David Howells
2009-04-09 16:33 ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 17:51   ` Linus Torvalds
2009-04-09 18:04     ` Linus Torvalds
2009-04-09 18:13     ` Al Viro
2009-04-09 18:26       ` Linus Torvalds
2009-04-09 18:39         ` Al Viro
2009-04-09 18:28       ` patch(1) and git -M output (Re: [PATCH 2/2] FRV: Move to arch/frv/include/asm/) Al Viro
2009-04-09 22:06         ` Andreas Gruenbacher
2009-04-09 23:21           ` Al Viro
2009-04-09 21:05   ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 21:18     ` Linus Torvalds
2009-04-09 21:23       ` Randy Dunlap
2009-04-09 21:51     ` David Howells [this message]
2009-04-09 22:00       ` Linus Torvalds
2009-04-09 23:24       ` Fix for StGIT David Howells
2009-04-09 23:21 [PATCH 1/2] FRV: Use <asm-generic/pgtable.h> in NOMMU mode David Howells
2009-04-09 23:21 ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 23:31   ` Linus Torvalds
2009-04-09 23:38   ` David Howells
2009-04-09 23:49     ` Linus Torvalds
2009-04-10  1:06     ` David Howells
2009-04-10  1:13       ` Linus Torvalds
2009-04-09 23:25 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12327.1239313897@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).