From: Randy Dunlap <randy.dunlap@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
akpm@linux-foundation.org, sam@ravnborg.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] FRV: Move to arch/frv/include/asm/
Date: Thu, 09 Apr 2009 14:23:56 -0700 [thread overview]
Message-ID: <49DE676C.6030802@oracle.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0904091412060.4583@localhost.localdomain>
Linus Torvalds wrote:
>
> On Thu, 9 Apr 2009, David Howells wrote:
>> I should've used:
>>
>> stg mail -diff-opts=-M
>>
>> it would appear. I wonder if this should be the default.
>
> Ahh. I've never used stg. It seems to have some bad defaults.
>
> Also, depending on exactly what "stg" does, it is entirely possible that
> adding that
>
> [diff]
> renames
>
> to your .gitconfig won't help: those kinds of default configuration values
> are (very much on purpose) ignored for certain low-level git commands,
> exactly so that you can do reliable scripting without having to worry
> about some user-specific config files.
>
>> Note that
>>
>> git-diff -M HEAD^ HEAD
>>
>> does not make output that looks like yours. It's missing the:
>>
>> {include/asm-frv => arch/frv/include/asm}/Kbuild | 0
>> {include/asm-frv => arch/frv/include/asm}/atomic.h | 0
>
> Those come from "--summary", which summarizes file creation, deletion and
> movement. Almost always combined with "--stat", but apparently the
> "--stat" part is again in that "stg mail" script.
David: Documentation/SubmittingPatches:/git diff/ =>
'Please use "git diff -M --stat --summary" to generate the diffstat:
the -M enables rename detection, and the summary enables a summary of
new/deleted or renamed files.'
--
~Randy
next prev parent reply other threads:[~2009-04-09 21:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 16:32 [PATCH 1/2] FRV: Use <asm-generic/pgtable.h> in NOMMU mode David Howells
2009-04-09 16:33 ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 17:51 ` Linus Torvalds
2009-04-09 18:04 ` Linus Torvalds
2009-04-09 18:13 ` Al Viro
2009-04-09 18:26 ` Linus Torvalds
2009-04-09 18:39 ` Al Viro
2009-04-09 18:28 ` patch(1) and git -M output (Re: [PATCH 2/2] FRV: Move to arch/frv/include/asm/) Al Viro
2009-04-09 22:06 ` Andreas Gruenbacher
2009-04-09 23:21 ` Al Viro
2009-04-09 21:05 ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 21:18 ` Linus Torvalds
2009-04-09 21:23 ` Randy Dunlap [this message]
2009-04-09 21:51 ` David Howells
2009-04-09 22:00 ` Linus Torvalds
2009-04-09 23:24 ` Fix for StGIT David Howells
2009-04-09 23:21 [PATCH 1/2] FRV: Use <asm-generic/pgtable.h> in NOMMU mode David Howells
2009-04-09 23:21 ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 23:31 ` Linus Torvalds
2009-04-09 23:38 ` David Howells
2009-04-09 23:49 ` Linus Torvalds
2009-04-10 1:06 ` David Howells
2009-04-10 1:13 ` Linus Torvalds
2009-04-09 23:25 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DE676C.6030802@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).