From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: David Howells <dhowells@redhat.com>,
akpm@linux-foundation.org, sam@ravnborg.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] FRV: Move to arch/frv/include/asm/
Date: Thu, 9 Apr 2009 11:26:49 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0904091120560.4583@localhost.localdomain> (raw)
In-Reply-To: <20090409181328.GD26366@ZenIV.linux.org.uk>
On Thu, 9 Apr 2009, Al Viro wrote:
>
> We can teach patch(1) to handle those - apparently agruen has resurrected
> development lately (git://git.savannah.gnu.org/patch.git), so it might
> be possible without usual latency problems...
I think a lot of SCM's parse diffs internally, so people are still going
to have to live with legacy patches.
The reason for doing diff parsing internally is that it's much easier to
handle the error cases, or even just see what files were modified
successfully.
If you executee an external "patch" command, it's really quite nasty to
parse the whole "what happened" stuff both for the "everything applied
fine" _and_ for the "oops, the patch failed in the middle" case.
Doing diff parsing and application is also generally quite easy - at least
compared to _generating_ them. In many ways it's easier to just handle the
diff yourself than it is to try to parse the end result of running "patch"
externally.
So I would not be at all surprised if many SCM's use an external "diff" to
generate patches (that has none of the complexities of the error cases),
but don't use an external "patch" to apply them.
Linus
next prev parent reply other threads:[~2009-04-09 18:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 16:32 [PATCH 1/2] FRV: Use <asm-generic/pgtable.h> in NOMMU mode David Howells
2009-04-09 16:33 ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 17:51 ` Linus Torvalds
2009-04-09 18:04 ` Linus Torvalds
2009-04-09 18:13 ` Al Viro
2009-04-09 18:26 ` Linus Torvalds [this message]
2009-04-09 18:39 ` Al Viro
2009-04-09 18:28 ` patch(1) and git -M output (Re: [PATCH 2/2] FRV: Move to arch/frv/include/asm/) Al Viro
2009-04-09 22:06 ` Andreas Gruenbacher
2009-04-09 23:21 ` Al Viro
2009-04-09 21:05 ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 21:18 ` Linus Torvalds
2009-04-09 21:23 ` Randy Dunlap
2009-04-09 21:51 ` David Howells
2009-04-09 22:00 ` Linus Torvalds
2009-04-09 23:24 ` Fix for StGIT David Howells
2009-04-09 23:21 [PATCH 1/2] FRV: Use <asm-generic/pgtable.h> in NOMMU mode David Howells
2009-04-09 23:21 ` [PATCH 2/2] FRV: Move to arch/frv/include/asm/ David Howells
2009-04-09 23:31 ` Linus Torvalds
2009-04-09 23:38 ` David Howells
2009-04-09 23:49 ` Linus Torvalds
2009-04-10 1:06 ` David Howells
2009-04-10 1:13 ` Linus Torvalds
2009-04-09 23:25 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0904091120560.4583@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).