Re: [git pull -tip] headers_check fixes for other architectures

From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	hskinnemoen@atmel.com, cooloney@kernel.org, tony.luck@intel.com,
	ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx,
	chris@zankel.net, LKML <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.de>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [git pull -tip] headers_check fixes for other architectures
Date: Mon, 02 Feb 2009 00:03:12 +0530	[thread overview]
Message-ID: <1233513192.16925.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20090201164915.GA29264@elte.hu>

On Sun, 2009-02-01 at 17:49 +0100, Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > > These patches fixes 41 headers_check warnings as shown in first email.
> > 
> > Pulled into tip/core/header-fixes, thanks Jaswinder!
> 
> These are the remaining ones on x86:
> 
>      17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h
>      12 /dev/shm/tip/usr/include/linux/soundcard.h
>       6 /dev/shm/tip/usr/include/asm/setup.h
>       3 /dev/shm/tip/usr/include/linux/nubus.h
>       2 /dev/shm/tip/usr/include/linux/in6.h
>       1 /dev/shm/tip/usr/include/mtd/jffs2-user.h
>       1 /dev/shm/tip/usr/include/linux/socket.h
>       1 /dev/shm/tip/usr/include/linux/coda_psdev.h
>       1 /dev/shm/tip/usr/include/asm/prctl.h
> 
> They are all of the "extern's make no sense in userspace" type. What was the 
> verdict, are they worth touching, or should we turn off this warning in 
> 'make headers_check'?
> 

I have the patches in queue which fixes above warnings except:

 12 /dev/shm/tip/usr/include/linux/soundcard.h
 1 /dev/shm/tip/usr/include/mtd/jffs2-user.h

Because these two files are using userspace functions.

--
JSR