From: Ingo Molnar <mingo@elte.hu>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>, Sam Ravnborg <sam@ravnborg.org>,
Andrew Morton <akpm@linux-foundation.org>,
hskinnemoen@atmel.com, cooloney@kernel.org, ralf@linux-mips.org,
dhowells@redhat.com, matthew@wil.cx, chris@zankel.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull -tip] headers_check fixes for other architectures
Date: Fri, 6 Feb 2009 15:58:06 +0100 [thread overview]
Message-ID: <20090206145806.GI18368@elte.hu> (raw)
In-Reply-To: <20090206145119.GB13758@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Fri, Feb 06, 2009 at 08:04:20PM +0530, Jaswinder Singh Rajput wrote:
> > On Fri, 2009-02-06 at 14:21 +0000, Russell King - ARM Linux wrote:
> > > On Fri, Feb 06, 2009 at 07:48:42PM +0530, Jaswinder Singh Rajput wrote:
> > > > diff --git a/include/linux/types.h b/include/linux/types.h
> > > > index 712ca53..c30973a 100644
> > > > --- a/include/linux/types.h
> > > > +++ b/include/linux/types.h
> > > > @@ -1,6 +1,7 @@
> > > > #ifndef _LINUX_TYPES_H
> > > > #define _LINUX_TYPES_H
> > > >
> > > > +#ifndef __ASSEMBLY__
> > > > #ifdef __KERNEL__
> > > >
> > > > #define DECLARE_BITMAP(name,bits) \
> > > > @@ -212,5 +213,5 @@ struct ustat {
> > > > };
> > > >
> > > > #endif /* __KERNEL__ */
> > > > -
> > > > +#endif /* __ASSEMBLY__ */
> > > > #endif /* _LINUX_TYPES_H */
> > >
> > > So no point including this file in assembly with this patch - the ifndef
> > > disables the entire file.
> >
> > Truth Table of linux/types.h :
> >
> > If Assembly then N
> > otherwise Y
> >
> > what your table says.
>
> If the entire file is not suitable for assembly, don't include the file
> in assembly files. Nice and simple, and no need to add additional ifdefs.
Well types.h easily gets included in other files though, which might be
partially suited for assembly - and have !__ASSEMBLY__ portions that rely on
a types.h include.
So making this file an invariant in .S files does not sound like a bad idea
to me. Is there any downside?
Ingo
next prev parent reply other threads:[~2009-02-06 14:58 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 7:10 [git pull -tip] headers_check fixes for other architectures Jaswinder Singh Rajput
2009-01-31 16:44 ` Ingo Molnar
2009-02-01 6:30 ` Jaswinder Singh Rajput
2009-02-01 10:39 ` Ingo Molnar
2009-02-01 16:49 ` Ingo Molnar
2009-02-01 17:06 ` Russell King - ARM Linux
2009-02-01 17:20 ` Russell King - ARM Linux
2009-02-01 17:31 ` Jaswinder Singh Rajput
2009-02-01 18:33 ` Jaswinder Singh Rajput
2009-02-02 17:11 ` Mike Frysinger
2009-02-02 18:08 ` Ingo Molnar
2009-02-02 18:29 ` Mike Frysinger
2009-02-02 18:48 ` Ingo Molnar
2009-02-05 17:55 ` Tony Luck
2009-02-05 19:06 ` Linus Torvalds
2009-02-05 19:19 ` Ingo Molnar
2009-02-06 2:06 ` Jaswinder Singh Rajput
2009-02-06 2:14 ` Mike Frysinger
2009-02-06 2:20 ` Ingo Molnar
2009-02-06 14:18 ` Jaswinder Singh Rajput
2009-02-06 14:21 ` Russell King - ARM Linux
2009-02-06 14:34 ` Jaswinder Singh Rajput
2009-02-06 14:51 ` Russell King - ARM Linux
2009-02-06 14:58 ` Ingo Molnar [this message]
2009-02-06 15:00 ` Jaswinder Singh Rajput
2009-02-06 15:10 ` Russell King - ARM Linux
2009-02-06 15:56 ` Ingo Molnar
2009-02-06 16:02 ` Russell King - ARM Linux
2009-02-06 17:24 ` Sam Ravnborg
2009-02-06 17:40 ` Ingo Molnar
2009-02-06 18:11 ` Jaswinder Singh Rajput
2009-02-06 18:42 ` Sam Ravnborg
2009-02-06 19:31 ` Jaswinder Singh Rajput
2009-02-08 5:50 ` Jaswinder Singh Rajput
2009-02-09 12:23 ` Ingo Molnar
2009-02-06 8:19 ` [linux-next][PATCH] revert headers_check fix: ia64, fpu.h KOSAKI Motohiro
2009-02-06 8:53 ` Jaswinder Singh Rajput
2009-02-06 9:11 ` KOSAKI Motohiro
2009-02-06 14:55 ` Ingo Molnar
2009-02-06 15:29 ` Jaswinder Singh Rajput
2009-02-06 15:33 ` Russell King - ARM Linux
2009-02-06 15:45 ` Ingo Molnar
2009-02-06 15:49 ` Russell King - ARM Linux
2009-02-06 16:01 ` Ingo Molnar
2009-02-06 15:48 ` Jaswinder Singh Rajput
2009-02-06 15:55 ` Russell King - ARM Linux
2009-02-06 16:12 ` Ingo Molnar
2009-02-06 16:23 ` Russell King - ARM Linux
2009-02-06 16:33 ` Ingo Molnar
2009-02-06 16:38 ` Russell King - ARM Linux
2009-02-06 17:14 ` Ingo Molnar
2009-02-06 17:22 ` Russell King - ARM Linux
2009-02-06 17:32 ` Sam Ravnborg
2009-02-06 17:41 ` Ingo Molnar
2009-02-06 18:53 ` Luck, Tony
2009-02-06 13:42 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206145806.GI18368@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=cooloney@kernel.org \
--cc=dhowells@redhat.com \
--cc=hskinnemoen@atmel.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matthew@wil.cx \
--cc=ralf@linux-mips.org \
--cc=sam@ravnborg.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).