Re: [git pull -tip] headers_check fixes for other architectures

From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Tony Luck <tony.luck@intel.com>, Sam Ravnborg <sam@ravnborg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	hskinnemoen@atmel.com, cooloney@kernel.org, ralf@linux-mips.org,
	dhowells@redhat.com, matthew@wil.cx, chris@zankel.net,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull -tip] headers_check fixes for other architectures
Date: Fri, 06 Feb 2009 20:30:07 +0530	[thread overview]
Message-ID: <1233932407.3209.18.camel@localhost.localdomain> (raw)
In-Reply-To: <20090206145119.GB13758@n2100.arm.linux.org.uk>

On Fri, 2009-02-06 at 14:51 +0000, Russell King - ARM Linux wrote:
> > > 
> > > So no point including this file in assembly with this patch - the ifndef
> > > disables the entire file.
> > 
> > Truth Table of linux/types.h :
> > 
> > If Assembly then N
> > otherwise Y
> > 
> > what your table says.
> 
> If the entire file is not suitable for assembly, don't include the file
> in assembly files.  Nice and simple, and no need to add additional ifdefs.

Ahh, so your truth table says:

If Assembly then make different header files
If C then make another header files

Do not you think your truth table is complex and very difficult to
handle and maintain ?

Can we make things simple and easier.

Thanks,
--
JSR