linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Salman Qazi <sqazi@google.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, svaidy@linux.vnet.ibm.com,
	linux-pm@lists.linux-foundation.org, arjan@infradead.org,
	csadler@google.com, ranjitm@google.com, kenchen@google.com,
	dawnchen@google.com
Subject: Re: [PATCH 0/3] [idled]: Idle Cycle Injector for power capping
Date: Mon, 19 Apr 2010 21:01:41 +0200	[thread overview]
Message-ID: <1271703701.1676.235.camel@laptop> (raw)
In-Reply-To: <h2u4352991a1004191020q8200399oc8e9f7d8dee934bf@mail.gmail.com>

On Mon, 2010-04-19 at 10:20 -0700, Salman Qazi wrote:
> On Thu, Apr 15, 2010 at 12:51 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Tue, 2010-04-13 at 17:08 -0700, Salman wrote:
> >> As we discussed earlier this year, Google has an implementation that it
> >> would like to share.  I have finally gotten around to porting it to
> >> v2.6.33 and cleaning up the interfaces.  It is provided in the following
> >> messages for your review.  I realize that when we first discussed this
> >> idea, a lot of ideas were presented for enhancing it.  Thanks alot for
> >> your suggestions.  I haven't gotten around to implementing any of them.
> >
> > .33 is way too old to submit patches against.
> 
> Will bump up the version when I refresh the change.
> 
> >
> > That said, I really really dislike this approach, I would much rather
> > see it tie in with power aware scheduling.
> 
> I think I can see your point:  there is potentially better information
> about the power consumption of the CPU beyond the time it was busy.
> But please clarify: is your complaint the lack of use of this
> information or are you arguing for a deeper integration into the
> scheduler (I.e. implementing it as part of the scheduler rather than
> an independent thread) or both?

Right, so the IBM folks who were looking at power aware scheduling were
working on an interface to quantify the amount of power to save.

But their approach, was an extension of the regular power aware
load-balancer, which basically groups tasks onto sockets so that whole
sockets can go idle.

However Arjan explained to me that your approach, which idles the whole
machine, has the advantage that also memory banks can go into idle mode
and save power.

Still in the interest to cut back on power-saving interfaces it would be
nice to see if there is anything we can do to merge these things, but I
really haven't thought much about that yet.


  reply	other threads:[~2010-04-19 19:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-14  0:08 [PATCH 0/3] [idled]: Idle Cycle Injector for power capping Salman
2010-04-14  0:08 ` [PATCH 1/3] [kidled]: introduce kidled Salman
2010-04-14  9:49   ` Andi Kleen
2010-04-14 15:41     ` Salman Qazi
2010-04-15  7:46       ` Peter Zijlstra
2010-04-14  0:08 ` [PATCH 2/3] [kidled]: Add eager injection Salman
2010-04-14  0:08 ` [PATCH 3/3] [kidled]: Introduce power capping priority and LB awareness Salman
2010-04-15  7:51 ` [PATCH 0/3] [idled]: Idle Cycle Injector for power capping Peter Zijlstra
2010-04-17 17:08   ` tytso
2010-04-17 17:57     ` Arjan van de Ven
2010-04-17 19:51     ` Peter Zijlstra
2010-04-19 17:20   ` Salman Qazi
2010-04-19 19:01     ` Peter Zijlstra [this message]
2010-04-20  1:00       ` Arjan van de Ven
2010-04-20  5:00         ` Vaidyanathan Srinivasan
2010-04-20  4:50       ` Vaidyanathan Srinivasan
2010-04-20 17:52         ` Salman Qazi
2010-04-21  5:08           ` Arjan van de Ven
2010-04-22  1:32   ` Mike Chan
2010-04-22  8:21     ` Peter Zijlstra
2010-04-22 19:02     ` Vaidyanathan Srinivasan
2010-04-17 16:40 ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271703701.1676.235.camel@laptop \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=csadler@google.com \
    --cc=dawnchen@google.com \
    --cc=kenchen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=ranjitm@google.com \
    --cc=sqazi@google.com \
    --cc=svaidy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).