From: Gilad Ben-Yossef <gilad@benyossef.com>
To: linux-kernel@vger.kernel.org
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
Christoph Lameter <cl@linux.com>,
Chris Metcalf <cmetcalf@tilera.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
Matt Mackall <mpm@selenic.com>,
Sasha Levin <levinsasha928@gmail.com>,
Rik van Riel <riel@redhat.com>, Andi Kleen <andi@firstfloor.org>,
Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Avi Kivity <avi@redhat.com>,
Michal Nazarewicz <mina86@mina86.com>,
Kosaki Motohiro <kosaki.motohiro@gmail.com>,
Milton Miller <miltonm@bga.com>
Subject: [v7 8/8] mm: add vmstat counters for tracking PCP drains
Date: Thu, 26 Jan 2012 12:02:01 +0200 [thread overview]
Message-ID: <1327572121-13673-9-git-send-email-gilad@benyossef.com> (raw)
In-Reply-To: <1327572121-13673-1-git-send-email-gilad@benyossef.com>
This patch introduces two new vmstat counters for testing purposes:
pcp_global_drain that counts the number of times a per-cpu pages
global drain was requested and pcp_global_ipi_saved that counts
the number of times the number of CPUs with per-cpu pages in any
zone were less then 1/2 of the number of online CPUs.
The patch purpose is to show the usefulness of only sending an IPI
asking to drain per-cpu pages to CPUs that actually have them
instead of a blind global IPI. It is probably not useful by itself.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
CC: Christoph Lameter <cl@linux.com>
CC: Chris Metcalf <cmetcalf@tilera.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: linux-mm@kvack.org
CC: Pekka Enberg <penberg@kernel.org>
CC: Matt Mackall <mpm@selenic.com>
CC: Sasha Levin <levinsasha928@gmail.com>
CC: Rik van Riel <riel@redhat.com>
CC: Andi Kleen <andi@firstfloor.org>
CC: Mel Gorman <mel@csn.ul.ie>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Alexander Viro <viro@zeniv.linux.org.uk>
CC: Avi Kivity <avi@redhat.com>
CC: Michal Nazarewicz <mina86@mina86.com>
CC: Kosaki Motohiro <kosaki.motohiro@gmail.com>
CC: Milton Miller <miltonm@bga.com>
---
include/linux/vm_event_item.h | 1 +
mm/page_alloc.c | 5 +++++
mm/vmstat.c | 2 ++
3 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index 03b90cd..3657f6f 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -58,6 +58,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
THP_COLLAPSE_ALLOC_FAILED,
THP_SPLIT,
#endif
+ PCP_GLOBAL_DRAIN, PCP_GLOBAL_IPI_SAVED,
NR_VM_EVENT_ITEMS
};
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 4135983..1aa9031 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1195,6 +1195,11 @@ void drain_all_pages(void)
cpumask_clear_cpu(cpu, &cpus_with_pcps);
}
on_each_cpu_mask(&cpus_with_pcps, drain_local_pages, NULL, 1);
+
+ count_vm_event(PCP_GLOBAL_DRAIN);
+ if (cpumask_weight(&cpus_with_pcps) <
+ (cpumask_weight(cpu_online_mask) / 2))
+ count_vm_event(PCP_GLOBAL_IPI_SAVED);
}
#ifdef CONFIG_HIBERNATION
diff --git a/mm/vmstat.c b/mm/vmstat.c
index f600557..3ee5f99 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -786,6 +786,8 @@ const char * const vmstat_text[] = {
"thp_collapse_alloc_failed",
"thp_split",
#endif
+ "pcp_global_drain",
+ "pcp_global_ipi_saved"
#endif /* CONFIG_VM_EVENTS_COUNTERS */
};
--
1.7.0.4
next prev parent reply other threads:[~2012-01-26 10:03 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 10:01 [v7 0/8] Reduce cross CPU IPI interference Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 1/8] smp: introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2012-01-29 12:24 ` Gilad Ben-Yossef
2012-01-30 21:52 ` Andrew Morton
2012-01-31 6:33 ` Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 2/8] arm: move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 3/8] tile: move tile to use " Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 4/8] smp: add func to IPI cpus based on parameter func Gilad Ben-Yossef
2012-01-27 23:57 ` Andrew Morton
2012-01-29 12:04 ` Gilad Ben-Yossef
2012-01-26 10:01 ` [v7 5/8] slub: only IPI CPUs that have per cpu obj to flush Gilad Ben-Yossef
2012-01-26 15:09 ` Christoph Lameter
2012-01-26 10:01 ` [v7 6/8] fs: only send IPI to invalidate LRU BH when needed Gilad Ben-Yossef
2012-01-26 10:02 ` [v7 7/8] mm: only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2012-01-26 15:13 ` Christoph Lameter
2012-01-28 0:12 ` Andrew Morton
2012-01-29 12:18 ` Gilad Ben-Yossef
2012-01-30 21:49 ` Andrew Morton
2012-01-31 6:32 ` Gilad Ben-Yossef
2012-01-30 14:59 ` Mel Gorman
2012-01-30 15:14 ` Gilad Ben-Yossef
2012-01-30 15:44 ` Mel Gorman
2012-01-26 10:02 ` Gilad Ben-Yossef [this message]
2012-01-26 15:19 ` [v7 0/8] Reduce cross CPU IPI interference Peter Zijlstra
2012-01-29 8:25 ` Gilad Ben-Yossef
2012-02-01 17:04 ` Frederic Weisbecker
2012-02-02 8:46 ` Gilad Ben-Yossef
2012-02-02 15:41 ` Chris Metcalf
2012-02-05 11:46 ` Gilad Ben-Yossef
2012-02-10 18:39 ` Peter Zijlstra
2012-02-10 20:13 ` Gilad Ben-Yossef
2012-02-10 20:29 ` Peter Zijlstra
2012-02-10 20:39 ` Gilad Ben-Yossef
2012-02-10 18:33 ` Peter Zijlstra
2012-02-10 20:33 ` Gilad Ben-Yossef
2012-02-15 21:50 ` Chris Metcalf
2012-02-15 22:15 ` Christoph Lameter
2012-02-15 23:44 ` Chris Metcalf
2012-02-21 1:34 ` Frederic Weisbecker
2012-03-01 18:27 ` Chris Metcalf
2012-02-10 18:38 ` Peter Zijlstra
2012-02-10 20:24 ` Gilad Ben-Yossef
2012-02-15 15:11 ` Peter Zijlstra
2012-02-15 15:19 ` Gilad Ben-Yossef
2012-02-15 21:51 ` Chris Metcalf
2012-02-02 16:24 ` Frederic Weisbecker
2012-02-02 16:29 ` Christoph Lameter
2012-02-09 15:52 ` Frederic Weisbecker
2012-02-09 15:59 ` Chris Metcalf
2012-02-09 18:11 ` Frederic Weisbecker
2012-02-09 16:26 ` Christoph Lameter
2012-02-09 18:32 ` Frederic Weisbecker
2012-02-01 17:35 ` Peter Zijlstra
2012-02-01 17:57 ` Peter Zijlstra
2012-02-02 9:42 ` Gilad Ben-Yossef
2012-02-01 18:40 ` Paul E. McKenney
2012-02-01 20:06 ` Christoph Lameter
2012-02-01 20:13 ` Paul E. McKenney
2012-02-02 9:34 ` Avi Kivity
2012-02-02 15:34 ` Paul E. McKenney
2012-02-02 16:14 ` Avi Kivity
2012-02-02 17:01 ` Paul E. McKenney
2012-02-02 17:23 ` Avi Kivity
2012-02-02 17:51 ` Paul E. McKenney
2012-02-05 12:16 ` Avi Kivity
2012-02-05 16:59 ` Paul E. McKenney
2012-02-09 15:22 ` Frederic Weisbecker
2012-02-09 16:05 ` Avi Kivity
2012-02-09 18:22 ` Frederic Weisbecker
2012-02-09 23:41 ` Paul E. McKenney
2012-02-10 1:39 ` Frederic Weisbecker
2012-02-14 13:18 ` Avi Kivity
2012-02-21 0:02 ` Frederic Weisbecker
2012-02-02 17:25 ` Christoph Lameter
2012-02-05 12:06 ` Gilad Ben-Yossef
2012-02-06 18:19 ` Christoph Lameter
2012-02-09 15:37 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327572121-13673-9-git-send-email-gilad@benyossef.com \
--to=gilad@benyossef.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@gmail.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=miltonm@bga.com \
--cc=mina86@mina86.com \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=riel@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).