* [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
@ 2012-01-31 7:11 Devendra.Naga
2012-01-31 7:37 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Devendra.Naga @ 2012-01-31 7:11 UTC (permalink / raw)
To: Larry.Finger, chaoming_li, linville, paul.gortmaker, joe,
linux-wireless, netdev, linux-kernel
Cc: Devendra.Naga
From: "Devendra.Naga" <devendra.aaru@gmail.com>
in _rtl92c_phy_calculate_bit_shift everytime the right shifted bitmask
is AND with 1 and compared against 1. i.e.
if ((bitmask >> i) & 0x1 == 1)
break;
which in the if condition is anyway becomes a 1 or 0.
Signed-off-by: Devendra.Naga <devendra.aaru@gmail.com>
---
drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
index 22e998d..a76b223 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
@@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
u32 i;
for (i = 0; i <= 31; i++) {
- if (((bitmask >> i) & 0x1) == 1)
+ if ((bitmask >> i) & 0x1)
break;
}
return i;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
2012-01-31 7:11 [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1 Devendra.Naga
@ 2012-01-31 7:37 ` Joe Perches
2012-02-08 19:57 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2012-01-31 7:37 UTC (permalink / raw)
To: Devendra.Naga
Cc: Larry.Finger, chaoming_li, linville, paul.gortmaker,
linux-wireless, netdev, linux-kernel
On Tue, 2012-01-31 at 02:11 -0500, Devendra.Naga wrote:
> From: "Devendra.Naga" <devendra.aaru@gmail.com>
[]
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
[]
> @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
> u32 i;
>
> for (i = 0; i <= 31; i++) {
> - if (((bitmask >> i) & 0x1) == 1)
> + if ((bitmask >> i) & 0x1)
> break;
> }
> return i;
Perhaps this is simpler and faster:
{
u32 rtn = (u32)ffs((int)bitmask);
if (rtn)
return rtn - 1;
return 32;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
2012-01-31 7:37 ` Joe Perches
@ 2012-02-08 19:57 ` John W. Linville
0 siblings, 0 replies; 3+ messages in thread
From: John W. Linville @ 2012-02-08 19:57 UTC (permalink / raw)
To: Joe Perches
Cc: Devendra.Naga, Larry.Finger, chaoming_li, paul.gortmaker,
linux-wireless, netdev, linux-kernel
On Mon, Jan 30, 2012 at 11:37:20PM -0800, Joe Perches wrote:
> On Tue, 2012-01-31 at 02:11 -0500, Devendra.Naga wrote:
> > From: "Devendra.Naga" <devendra.aaru@gmail.com>
> []
> > diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> []
> > @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
> > u32 i;
> >
> > for (i = 0; i <= 31; i++) {
> > - if (((bitmask >> i) & 0x1) == 1)
> > + if ((bitmask >> i) & 0x1)
> > break;
> > }
> > return i;
>
> Perhaps this is simpler and faster:
>
> {
> u32 rtn = (u32)ffs((int)bitmask);
> if (rtn)
> return rtn - 1;
> return 32;
> }
Are you planning to revise your patch based on Joe's suggestion?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-08 20:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-31 7:11 [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1 Devendra.Naga
2012-01-31 7:37 ` Joe Perches
2012-02-08 19:57 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).