From: Shuah Khan <shuahkhan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: shuahkhan@gmail.com, Geon Si Jeong <gshark.jeong@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Daniel Jeong <daniel.jeong@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip
Date: Sat, 31 Mar 2012 21:37:23 -0600 [thread overview]
Message-ID: <1333251443.5466.3.camel@lorien2> (raw)
In-Reply-To: <20120330114122.be769e8a.akpm@linux-foundation.org>
On Fri, 2012-03-30 at 11:41 -0700, Andrew Morton wrote:
> On Fri, 30 Mar 2012 15:38:28 +0900
> Geon Si Jeong <gshark.jeong@gmail.com> wrote:
>
> > It is a simple driver for LM3556 Chip(Texas Instruments)
> > LM3556 :
> > The LM3556 is a 4 MHz fixed-frequency synchronous boost
> > converter plus 1.5A constant current driver for a high-current white LED.
> > Datasheet: www.national.com/ds/LM/LM3556.pdf
>
> It needs this to build on x86_64:
>
> --- a/drivers/leds/leds-lm3556.c~leds-add-led-driver-for-lm3556-chip-fix-2
> +++ a/drivers/leds/leds-lm3556.c
> @@ -11,6 +11,7 @@
> #include <linux/delay.h>
> #include <linux/i2c.h>
> #include <linux/leds.h>
> +#include <linux/module.h>
> #include <linux/slab.h>
> #include <linux/platform_device.h>
> #include <linux/types.h>
>
>
> And here are some fixes for problems which were detected by checkpatch.
> Please use checkpatch. Please review and test this change:
>
> --- a/drivers/leds/leds-lm3556.c~leds-add-led-driver-for-lm3556-chip-checkpatch-fixes
> +++ a/drivers/leds/leds-lm3556.c
> @@ -141,7 +141,7 @@ static struct indicator indicator_patter
> };
>
> /* i2c access*/
> -int lm3556_read_reg(struct i2c_client *client, u8 reg, u8 * val)
> +int lm3556_read_reg(struct i2c_client *client, u8 reg, u8 *val)
> {
> int ret;
> struct lm3556_chip_data *chip = i2c_get_clientdata(client);
> @@ -317,12 +317,15 @@ static ssize_t lm3556_indicator_pattern_
> const char *buf, size_t size)
> {
> char *after;
> - ssize_t ret = -EINVAL;
> + ssize_t ret;
> struct i2c_client *client = container_of(dev->parent,
> struct i2c_client, dev);
> - unsigned long state = simple_strtoul(buf, &after, 10);
> + unsigned long state;
> size_t count = after - buf;
>
> + ret = kstrtoul(buf, 10, &state);
> + if (ret)
> + goto out;
> if (isspace(*after))
> count++;
after is used without initialization. Please note that simple_strtoul()
initializes after. Don't think this will work.
-- Shuah
>
> @@ -336,6 +339,7 @@ static ssize_t lm3556_indicator_pattern_
> lm3556_write_reg(client, REG_INDIC_PERIOD,
> indicator_pattern[state].period_cnt);
> }
> +out:
> return ret;
> }
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2012-04-01 3:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 6:38 [PATCH 0/1] leds: Add LED driver for lm3556 chip Geon Si Jeong
2012-03-30 6:38 ` [PATCH 1/1] " Geon Si Jeong
2012-03-30 18:26 ` Andrew Morton
2012-03-30 18:41 ` Andrew Morton
2012-04-01 3:37 ` Shuah Khan [this message]
2012-04-06 23:28 ` Andrew Morton
2012-03-30 18:56 ` Wolfram Sang
2012-03-31 21:09 ` Mark Brown
2012-04-03 22:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333251443.5466.3.camel@lorien2 \
--to=shuahkhan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.jeong@ti.com \
--cc=gshark.jeong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).