From: Andrew Morton <akpm@linux-foundation.org>
To: shuahkhan@gmail.com
Cc: Geon Si Jeong <gshark.jeong@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Daniel Jeong <daniel.jeong@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip
Date: Fri, 6 Apr 2012 16:28:35 -0700 [thread overview]
Message-ID: <20120406162835.d6fc1cac.akpm@linux-foundation.org> (raw)
In-Reply-To: <1333251443.5466.3.camel@lorien2>
On Sat, 31 Mar 2012 21:37:23 -0600
Shuah Khan <shuahkhan@gmail.com> wrote:
> > + ret = kstrtoul(buf, 10, &state);
> > + if (ret)
> > + goto out;
> > if (isspace(*after))
> > count++;
>
> after is used without initialization. Please note that simple_strtoul()
> initializes after. Don't think this will work.
I didn't try very hard ;)
I think I'll drop the whole patch. According to my notes,
- Wolfram's comments should be addressed
- Move the header file out of include/linux/
- Consider using the regmap API
next prev parent reply other threads:[~2012-04-06 23:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 6:38 [PATCH 0/1] leds: Add LED driver for lm3556 chip Geon Si Jeong
2012-03-30 6:38 ` [PATCH 1/1] " Geon Si Jeong
2012-03-30 18:26 ` Andrew Morton
2012-03-30 18:41 ` Andrew Morton
2012-04-01 3:37 ` Shuah Khan
2012-04-06 23:28 ` Andrew Morton [this message]
2012-03-30 18:56 ` Wolfram Sang
2012-03-31 21:09 ` Mark Brown
2012-04-03 22:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120406162835.d6fc1cac.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daniel.jeong@ti.com \
--cc=gshark.jeong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).