From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Geon Si Jeong <gshark.jeong@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Daniel Jeong <daniel.jeong@ti.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip
Date: Sat, 31 Mar 2012 22:09:13 +0100 [thread overview]
Message-ID: <20120331210913.GA19965@sirena.org.uk> (raw)
In-Reply-To: <20120330185634.GB3384@pengutronix.de>
On Fri, Mar 30, 2012 at 08:56:34PM +0200, Wolfram Sang wrote:
> On Fri, Mar 30, 2012 at 03:38:28PM +0900, Geon Si Jeong wrote:
> > +EXPORT_SYMBOL_GPL(lm3556_write_bits);
> Seeing all these functions it may be worth converting to REGMAP.
> Then you already have regmap_update_bits and the like.
Plus cache and debug infrastructure if that's useful.
> > +static ssize_t lm3556_indicator_pattern_store(struct device *dev,
> > + struct device_attribute *devAttr,
> > + const char *buf, size_t size)
> > +static DEVICE_ATTR(pattern, 0644, NULL, lm3556_indicator_pattern_store);
> I don't know the LED subsytsem very well. Is it that specific to the chip so we
> need a DEVICE_ATTR? Or can this be generalized in the core?
Alternatively some documentation indicating what the userspace ABI is
might help someone identify if there's a relevant feature more easily :)
If it's periodic blinking then there's definitely a core feature for
that.
> > + chip = kzalloc(sizeof(struct lm3556_chip_data), GFP_KERNEL);
devm_kzalloc()
next prev parent reply other threads:[~2012-03-31 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 6:38 [PATCH 0/1] leds: Add LED driver for lm3556 chip Geon Si Jeong
2012-03-30 6:38 ` [PATCH 1/1] " Geon Si Jeong
2012-03-30 18:26 ` Andrew Morton
2012-03-30 18:41 ` Andrew Morton
2012-04-01 3:37 ` Shuah Khan
2012-04-06 23:28 ` Andrew Morton
2012-03-30 18:56 ` Wolfram Sang
2012-03-31 21:09 ` Mark Brown [this message]
2012-04-03 22:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120331210913.GA19965@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.jeong@ti.com \
--cc=gshark.jeong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).