[PATCH 00/12] Fix use of version.h

[PATCH 00/12] Fix use of version.h

[Marcos Paulo de Souza]

Hi list,

After run "make versioncheck", the output of the tool show some places that we 
need to include the header version.h, and some places that we need to remove.

This patch set aims to fix all issues of using version.h.

This is my first patch set, so if I forgot something, please let me know :)

Marcos Paulo de Souza (12):
  drivers: block: mtip32xx: mtip32xx.h: Remove unnneeded include of
    version.h
  drivers: gpu: drm: gma500: mdfld_dsi_output.h: Remove not unneeded
    include of version.h
  drivers: media: dvb: ddbridge: ddbridge-code: Remove unneeded include
    of version.h
  drivers: media: radio: radio-keene.c: Remove unneeded include of
    version.h
  drivers: media: video: adp1653.c: Remove unneeded include of
    version.h
  drivers: media: video: tlg2300: pd-video.c: Include version.h header
  drivers: media: video: tm6000: tm6000.h: Include version.h header
  drivers: staging: media: as102: as102fe.c: Remove include of
    version.h
  drivers: staging: media: as102: as102_usb_drv.h: Remove include of
    version.h
  drivers: staging: media: easycap: easycap_ioctl: Include version.h
    header
  drivers: staging: rtl8172: Remove unneeded include of version.h
  drivers: staging: vme: devices: Remove unneeded include version.h

 drivers/block/mtip32xx/mtip32xx.h             |    1 -
 drivers/gpu/drm/gma500/mdfld_dsi_output.h     |    1 -
 drivers/media/dvb/ddbridge/ddbridge-core.c    |    1 -
 drivers/media/radio/radio-keene.c             |    1 -
 drivers/media/video/adp1653.c                 |    1 -
 drivers/media/video/tlg2300/pd-video.c        |    1 +
 drivers/media/video/tm6000/tm6000.h           |   13 +++++++------
 drivers/staging/media/as102/as102_fe.c        |    2 --
 drivers/staging/media/as102/as102_usb_drv.h   |    2 --
 drivers/staging/media/easycap/easycap_ioctl.c |    1 +
 drivers/staging/rtl8712/osdep_service.h       |    1 -
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c |    1 -
 drivers/staging/vme/devices/vme_pio2_core.c   |    1 -
 drivers/staging/vme/devices/vme_pio2_gpio.c   |    1 -
 14 files changed, 9 insertions(+), 19 deletions(-)

-- 
1.7.7.6

[PATCH 01/12] drivers: block: mtip32xx: mtip32xx.h: Remove unnneeded include of version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" points that the include of version.h
in the drivers/block/mtip32xx/mtip32xx.h is unneeded. If we take a look
at the file, we can agree to remove it.

c: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/block/mtip32xx/mtip32xx.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.h b/drivers/block/mtip32xx/mtip32xx.h
index 4ef5833..6f0b60f 100644
--- a/drivers/block/mtip32xx/mtip32xx.h
+++ b/drivers/block/mtip32xx/mtip32xx.h
@@ -26,7 +26,6 @@
 #include <linux/ata.h>
 #include <linux/interrupt.h>
 #include <linux/genhd.h>
-#include <linux/version.h>
 
 /* Offset of Subsystem Device ID in pci confoguration space */
 #define PCI_SUBSYSTEM_DEVICEID	0x2E
-- 
1.7.7.6

[PATCH 02/12] drivers: gpu: drm: gma500: mdfld_dsi_output.h: Remove not unneeded include of version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" points a incorrect include of
version.h in the drivers/gpu/drm/gma500/mdfld_dsi_output.h:

drivers/gpu/drm/gma500/mdfld_dsi_output.h: 32 linux/version.h not needed.

If we take a look in the file, we can agree to remove it.

Cc: David Airlie <airlied@linux.ie>
Cc: <dri-devel@lists.freedesktop.org>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/gpu/drm/gma500/mdfld_dsi_output.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.h b/drivers/gpu/drm/gma500/mdfld_dsi_output.h
index 21071ce..36eb074 100644
--- a/drivers/gpu/drm/gma500/mdfld_dsi_output.h
+++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.h
@@ -29,7 +29,6 @@
 #define __MDFLD_DSI_OUTPUT_H__
 
 #include <linux/backlight.h>
-#include <linux/version.h>
 #include <drm/drmP.h>
 #include <drm/drm.h>
 #include <drm/drm_crtc.h>
-- 
1.7.7.6

[PATCH 03/12] drivers: media: dvb: ddbridge: ddbridge-code: Remove unneeded include of version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that the file
drivers/media/dvb/ddbridge/ddbridge-code.c has a incorrect include of
version.h:

linux/drivers/media/dvb/ddbridge/ddbridge-core.c: 34 linux/version.h not
needed.

After take a look in the code, we can agree to remove it.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: <linux-media@vger.kernel.org>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/media/dvb/ddbridge/ddbridge-core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/ddbridge/ddbridge-core.c b/drivers/media/dvb/ddbridge/ddbridge-core.c
index d88c4aa..115777e 100644
--- a/drivers/media/dvb/ddbridge/ddbridge-core.c
+++ b/drivers/media/dvb/ddbridge/ddbridge-core.c
@@ -31,7 +31,6 @@
 #include <linux/pci.h>
 #include <linux/pci_ids.h>
 #include <linux/timer.h>
-#include <linux/version.h>
 #include <linux/i2c.h>
 #include <linux/swab.h>
 #include <linux/vmalloc.h>
-- 
1.7.7.6

[PATCH 04/12] drivers: media: radio: radio-keene.c: Remove unneeded include of version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/media/radio/radio-keene.c: 31 linux/version.h not needed.

After take a look in the code, we can agree to remove it.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: <linux-media@vger.kernel.org>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/media/radio/radio-keene.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/media/radio/radio-keene.c b/drivers/media/radio/radio-keene.c
index 55bd1d2..26a2b7a 100644
--- a/drivers/media/radio/radio-keene.c
+++ b/drivers/media/radio/radio-keene.c
@@ -28,7 +28,6 @@
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-event.h>
 #include <linux/usb.h>
-#include <linux/version.h>
 #include <linux/mutex.h>
 
 /* driver and module definitions */
-- 
1.7.7.6

[PATCH 05/12] drivers: media: video: adp1653.c: Remove unneeded include of version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/media/video/adp1653.c: 37 linux/version.h not needed.

After we take a look at the code, we can afree to remove it.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: <linux-media@vger.kernel.org>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/media/video/adp1653.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/adp1653.c b/drivers/media/video/adp1653.c
index 5b045b4..24afc99 100644
--- a/drivers/media/video/adp1653.c
+++ b/drivers/media/video/adp1653.c
@@ -34,7 +34,6 @@
 #include <linux/module.h>
 #include <linux/i2c.h>
 #include <linux/slab.h>
-#include <linux/version.h>
 #include <media/adp1653.h>
 #include <media/v4l2-device.h>
 
-- 
1.7.7.6

[PATCH 06/12] drivers: media: video: tlg2300: pd-video.c: Include version.h header

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h

If we take a look at the code, we can see that this file uses the macro
KERNEL_VERSION. So, we need this include.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Huang Shijie <shijie8@gmail.com>
Cc: Kang Yong <kangyong@telegent.com>
Cc: Zhang Xiaobing <xbzhang@telegent.com>
Cc: <linux-media@vger.kernel.org>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/media/video/tlg2300/pd-video.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
index a794ae6..069db9a 100644
--- a/drivers/media/video/tlg2300/pd-video.c
+++ b/drivers/media/video/tlg2300/pd-video.c
@@ -5,6 +5,7 @@
 #include <linux/mm.h>
 #include <linux/sched.h>
 #include <linux/slab.h>
+#include <linux/version.h>
 
 #include <media/v4l2-ioctl.h>
 #include <media/v4l2-dev.h>
-- 
1.7.7.6

[PATCH 07/12] drivers: media: video: tm6000: tm6000.h: Include version.h header

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/media/video/tm6000/tm6000.h: 401: need linux/version.h

If we take a look at the code, we can see the use of the macro
KERNEL_VERSION. So, we need this include.

In this patch too, the headers of the file were reordered in alphabetic
order. No functional changes here.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: <linux-media@vger.kernel.org >
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/media/video/tm6000/tm6000.h |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/media/video/tm6000/tm6000.h b/drivers/media/video/tm6000/tm6000.h
index 27ba659..e984cf2 100644
--- a/drivers/media/video/tm6000/tm6000.h
+++ b/drivers/media/video/tm6000/tm6000.h
@@ -20,18 +20,19 @@
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-#include <linux/videodev2.h>
-#include <media/v4l2-common.h>
-#include <media/videobuf-vmalloc.h>
-#include "tm6000-usb-isoc.h"
+#include <linux/dvb/frontend.h>
 #include <linux/i2c.h>
 #include <linux/mutex.h>
+#include <linux/version.h>
+#include <linux/videodev2.h>
+#include <media/videobuf-vmalloc.h>
+#include <media/v4l2-common.h>
 #include <media/v4l2-device.h>
 
-#include <linux/dvb/frontend.h>
+#include "dmxdev.h"
 #include "dvb_demux.h"
 #include "dvb_frontend.h"
-#include "dmxdev.h"
+#include "tm6000-usb-isoc.h"
 
 #define TM6000_VERSION KERNEL_VERSION(0, 0, 2)
 
-- 
1.7.7.6

[PATCH 08/12] drivers: staging: media: as102: as102fe.c: Remove include of version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/staging/media/as102/as102_fe.c: 20 linux/version.h not needed.

If we take a look at the code, we can agree to remove this include.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-media@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/staging/media/as102/as102_fe.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/as102/as102_fe.c b/drivers/staging/media/as102/as102_fe.c
index 5917657..9ce8c9d 100644
--- a/drivers/staging/media/as102/as102_fe.c
+++ b/drivers/staging/media/as102/as102_fe.c
@@ -17,8 +17,6 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
-#include <linux/version.h>
-
 #include "as102_drv.h"
 #include "as10x_types.h"
 #include "as10x_cmd.h"
-- 
1.7.7.6

[PATCH 09/12] drivers: staging: media: as102: as102_usb_drv.h: Remove include of version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/staging/media/as102/as102_usb_drv.h: 20 linux/version.h not
needed.

If we take a look at the code, we can agree to remove it.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-media@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org >
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/staging/media/as102/as102_usb_drv.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/as102/as102_usb_drv.h b/drivers/staging/media/as102/as102_usb_drv.h
index fc2884a..1ad1ec5 100644
--- a/drivers/staging/media/as102/as102_usb_drv.h
+++ b/drivers/staging/media/as102/as102_usb_drv.h
@@ -17,8 +17,6 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
-#include <linux/version.h>
-
 #ifndef _AS102_USB_DRV_H_
 #define _AS102_USB_DRV_H_
 
-- 
1.7.7.6

[PATCH 10/12] drivers: staging: media: easycap: easycap_ioctl: Include version.h header

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/staging/media/easycap/easycap_ioctl.c: 2442: need
linux/version.h

If we take a look at the code, we will see the macro KERNEL_VERSION be
used. So, we need this include.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-media@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org >
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/staging/media/easycap/easycap_ioctl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/media/easycap/easycap_ioctl.c b/drivers/staging/media/easycap/easycap_ioctl.c
index 9413b37..3cee3cd 100644
--- a/drivers/staging/media/easycap/easycap_ioctl.c
+++ b/drivers/staging/media/easycap/easycap_ioctl.c
@@ -26,6 +26,7 @@
 /*****************************************************************************/
 
 #include "easycap.h"
+#include <linux/version.h>
 
 /*--------------------------------------------------------------------------*/
 /*
-- 
1.7.7.6

[PATCH 11/12] drivers: staging: rtl8172: Remove unneeded include of version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/staging/rtl8712/osdep_service.h: 32 linux/version.h not needed.
drivers/staging/rtl8712/rtl871x_ioctl_linux.c: 46 linux/version.h not needed.

If we take a look at these files, we will agree to remove it.

Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/staging/rtl8712/osdep_service.h       |    1 -
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h
index 9ba6033..cabf774 100644
--- a/drivers/staging/rtl8712/osdep_service.h
+++ b/drivers/staging/rtl8712/osdep_service.h
@@ -29,7 +29,6 @@
 #define _SUCCESS	1
 #define _FAIL		0
 
-#include <linux/version.h>
 #include <linux/spinlock.h>
 
 #include <linux/interrupt.h>
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index ef35bc2..a44d539 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -43,7 +43,6 @@
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
-#include <linux/version.h>
 #include <linux/io.h>
 #include <linux/semaphore.h>
 #include <net/iw_handler.h>
-- 
1.7.7.6

[PATCH 12/12] drivers: staging: vme: devices: Remove unneeded include version.h

[Marcos Paulo de Souza]

The output of "make versioncheck" told us that:

drivers/staging/vme/devices/vme_pio2_core.c: 13 linux/version.h not needed.
drivers/staging/vme/devices/vme_pio2_gpio.c: 13 linux/version.h not needed.

If we take a look at these files, we will agree to remove it.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/staging/vme/devices/vme_pio2_core.c |    1 -
 drivers/staging/vme/devices/vme_pio2_gpio.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c
index 573c800..dd8012f 100644
--- a/drivers/staging/vme/devices/vme_pio2_core.c
+++ b/drivers/staging/vme/devices/vme_pio2_core.c
@@ -10,7 +10,6 @@
  * option) any later version.
  */
 
-#include <linux/version.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/types.h>
diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
index 8584849..5313c2e 100644
--- a/drivers/staging/vme/devices/vme_pio2_gpio.c
+++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
@@ -10,7 +10,6 @@
  * option) any later version.
  */
 
-#include <linux/version.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/types.h>
-- 
1.7.7.6

Re: [PATCH 11/12] drivers: staging: rtl8172: Remove unneeded include of version.h

[Larry Finger]

On 04/17/2012 11:30 PM, Marcos Paulo de Souza wrote:
> The output of "make versioncheck" told us that:
>
> drivers/staging/rtl8712/osdep_service.h: 32 linux/version.h not needed.
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c: 46 linux/version.h not needed.
>
> If we take a look at these files, we will agree to remove it.
>
> Cc: Larry Finger<Larry.Finger@lwfinger.net>
> Cc: Florian Schilhabel<florian.c.schilhabel@googlemail.com>
> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org>
> Cc:<devel@driverdev.osuosl.org>
> Signed-off-by: Marcos Paulo de Souza<marcos.souza.org@gmail.com>
> ---
>   drivers/staging/rtl8712/osdep_service.h       |    1 -
>   drivers/staging/rtl8712/rtl871x_ioctl_linux.c |    1 -
>   2 files changed, 0 insertions(+), 2 deletions(-)

ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>


>
> diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h
> index 9ba6033..cabf774 100644
> --- a/drivers/staging/rtl8712/osdep_service.h
> +++ b/drivers/staging/rtl8712/osdep_service.h
> @@ -29,7 +29,6 @@
>   #define _SUCCESS	1
>   #define _FAIL		0
>
> -#include<linux/version.h>
>   #include<linux/spinlock.h>
>
>   #include<linux/interrupt.h>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index ef35bc2..a44d539 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -43,7 +43,6 @@
>   #include<linux/module.h>
>   #include<linux/kernel.h>
>   #include<linux/init.h>
> -#include<linux/version.h>
>   #include<linux/io.h>
>   #include<linux/semaphore.h>
>   #include<net/iw_handler.h>

Re: [PATCH 06/12] drivers: media: video: tlg2300: pd-video.c: Include version.h header

[Mauro Carvalho Chehab]

Em 18-04-2012 01:30, Marcos Paulo de Souza escreveu:
> The output of "make versioncheck" told us that:
> 
> drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
> 
> If we take a look at the code, we can see that this file uses the macro
> KERNEL_VERSION. So, we need this include.

Nack. The right fix here is just the opposite: to remove the KERNEL_VERSION()
call. The V4L2 core now fills it automatically, so drivers shouldn't touch on
cap->version anymore. See the enclosed patch.

> 
> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> Cc: Huang Shijie <shijie8@gmail.com>
> Cc: Kang Yong <kangyong@telegent.com>
> Cc: Zhang Xiaobing <xbzhang@telegent.com>
> Cc: <linux-media@vger.kernel.org>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
>  drivers/media/video/tlg2300/pd-video.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
> index a794ae6..069db9a 100644
> --- a/drivers/media/video/tlg2300/pd-video.c
> +++ b/drivers/media/video/tlg2300/pd-video.c
> @@ -5,6 +5,7 @@
>  #include <linux/mm.h>
>  #include <linux/sched.h>
>  #include <linux/slab.h>
> +#include <linux/version.h>
>  
>  #include <media/v4l2-ioctl.h>
>  #include <media/v4l2-dev.h>

commit f8bf305b7103857708cd22b504a70ea4a08022fc
Author: Mauro Carvalho Chehab <mchehab@redhat.com>
Date:   Thu Apr 19 16:35:27 2012 -0300

    tlg2300: Remove usage of KERNEL_VERSION()
    
    As reported by Marcos:
    
    On 04-18-2012 01:30, Marcos Paulo de Souza wrote:
    > The output of "make versioncheck" told us that:
    >
    > drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
    >
    > If we take a look at the code, we can see that this file uses the macro
    > KERNEL_VERSION.
    
    The V4L2 core now fills it automatically, so drivers shouldn't touch on
    cap->version anymore.
    
    Reported by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
index a794ae6..bfbf9e5 100644
--- a/drivers/media/video/tlg2300/pd-video.c
+++ b/drivers/media/video/tlg2300/pd-video.c
@@ -150,7 +150,6 @@ static int vidioc_querycap(struct file *file, void *fh,
 	strcpy(cap->driver, "tele-video");
 	strcpy(cap->card, "Telegent Poseidon");
 	usb_make_path(p->udev, cap->bus_info, sizeof(cap->bus_info));
-	cap->version = KERNEL_VERSION(0, 0, 1);
 	cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_TUNER |
 				V4L2_CAP_AUDIO | V4L2_CAP_STREAMING |
 				V4L2_CAP_READWRITE | V4L2_CAP_VBI_CAPTURE;

Re: [PATCH 06/12] drivers: media: video: tlg2300: pd-video.c: Include version.h header

[Marcos Souza]

Em 19 de abril de 2012 16:39, Mauro Carvalho Chehab
<mchehab@redhat.com> escreveu:
> Em 18-04-2012 01:30, Marcos Paulo de Souza escreveu:
>> The output of "make versioncheck" told us that:
>>
>> drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
>>
>> If we take a look at the code, we can see that this file uses the macro
>> KERNEL_VERSION. So, we need this include.
>
> Nack. The right fix here is just the opposite: to remove the KERNEL_VERSION()
> call. The V4L2 core now fills it automatically, so drivers shouldn't touch on
> cap->version anymore. See the enclosed patch.
>
>>
>> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
>> Cc: Huang Shijie <shijie8@gmail.com>
>> Cc: Kang Yong <kangyong@telegent.com>
>> Cc: Zhang Xiaobing <xbzhang@telegent.com>
>> Cc: <linux-media@vger.kernel.org>
>> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>> ---
>>  drivers/media/video/tlg2300/pd-video.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
>> index a794ae6..069db9a 100644
>> --- a/drivers/media/video/tlg2300/pd-video.c
>> +++ b/drivers/media/video/tlg2300/pd-video.c
>> @@ -5,6 +5,7 @@
>>  #include <linux/mm.h>
>>  #include <linux/sched.h>
>>  #include <linux/slab.h>
>> +#include <linux/version.h>
>>
>>  #include <media/v4l2-ioctl.h>
>>  #include <media/v4l2-dev.h>
>
> commit f8bf305b7103857708cd22b504a70ea4a08022fc
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date:   Thu Apr 19 16:35:27 2012 -0300
>
>    tlg2300: Remove usage of KERNEL_VERSION()
>
>    As reported by Marcos:
>
>    On 04-18-2012 01:30, Marcos Paulo de Souza wrote:
>    > The output of "make versioncheck" told us that:
>    >
>    > drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
>    >
>    > If we take a look at the code, we can see that this file uses the macro
>    > KERNEL_VERSION.
>
>    The V4L2 core now fills it automatically, so drivers shouldn't touch on
>    cap->version anymore.
>
>    Reported by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
> index a794ae6..bfbf9e5 100644
> --- a/drivers/media/video/tlg2300/pd-video.c
> +++ b/drivers/media/video/tlg2300/pd-video.c
> @@ -150,7 +150,6 @@ static int vidioc_querycap(struct file *file, void *fh,
>        strcpy(cap->driver, "tele-video");
>        strcpy(cap->card, "Telegent Poseidon");
>        usb_make_path(p->udev, cap->bus_info, sizeof(cap->bus_info));
> -       cap->version = KERNEL_VERSION(0, 0, 1);
>        cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_TUNER |
>                                V4L2_CAP_AUDIO | V4L2_CAP_STREAMING |
>                                V4L2_CAP_READWRITE | V4L2_CAP_VBI_CAPTURE;

Better yet :)

Thanks for the feedback Mauro!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"

Re: [PATCH 07/12] drivers: media: video: tm6000: tm6000.h: Include version.h header

[Mauro Carvalho Chehab]

Em 18-04-2012 01:30, Marcos Paulo de Souza escreveu:
> The output of "make versioncheck" told us that:
> 
> drivers/media/video/tm6000/tm6000.h: 401: need linux/version.h
> 
> If we take a look at the code, we can see the use of the macro
> KERNEL_VERSION. So, we need this include.
> 
> In this patch too, the headers of the file were reordered in alphabetic
> order. No functional changes here.
> 
> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> Cc: <linux-media@vger.kernel.org >
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Nack. See enclosed.

commit d8a9c01484b258573587a52c3226bbdf6d11cda6
Author: Mauro Carvalho Chehab <mchehab@redhat.com>
Date:   Thu Apr 19 16:35:27 2012 -0300

    [media] tlg2300: Remove usage of KERNEL_VERSION()
    
    As reported by Marcos:
    
    On 04-18-2012 01:30, Marcos Paulo de Souza wrote:
    > The output of "make versioncheck" told us that:
    >
    > drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
    >
    > If we take a look at the code, we can see that this file uses the macro
    > KERNEL_VERSION.
    
    The V4L2 core now fills it automatically, so drivers shouldn't touch on
    cap->version anymore.
    
    Reported by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
index a794ae6..bfbf9e5 100644
--- a/drivers/media/video/tlg2300/pd-video.c
+++ b/drivers/media/video/tlg2300/pd-video.c
@@ -150,7 +150,6 @@ static int vidioc_querycap(struct file *file, void *fh,
 	strcpy(cap->driver, "tele-video");
 	strcpy(cap->card, "Telegent Poseidon");
 	usb_make_path(p->udev, cap->bus_info, sizeof(cap->bus_info));
-	cap->version = KERNEL_VERSION(0, 0, 1);
 	cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_TUNER |
 				V4L2_CAP_AUDIO | V4L2_CAP_STREAMING |
 				V4L2_CAP_READWRITE | V4L2_CAP_VBI_CAPTURE;

Re: [PATCH 06/12] drivers: media: video: tlg2300: pd-video.c: Include version.h header

[Huang Shijie]

Hi Mauro:

On Fri, Apr 20, 2012 at 3:39 AM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> Em 18-04-2012 01:30, Marcos Paulo de Souza escreveu:
>> The output of "make versioncheck" told us that:
>>
>> drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
>>
>> If we take a look at the code, we can see that this file uses the macro
>> KERNEL_VERSION. So, we need this include.
>
> Nack. The right fix here is just the opposite: to remove the KERNEL_VERSION()
> call. The V4L2 core now fills it automatically, so drivers shouldn't touch on
> cap->version anymore. See the enclosed patch.
>
>>
>> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
>> Cc: Huang Shijie <shijie8@gmail.com>
>> Cc: Kang Yong <kangyong@telegent.com>
>> Cc: Zhang Xiaobing <xbzhang@telegent.com>
>> Cc: <linux-media@vger.kernel.org>
>> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>> ---
>>  drivers/media/video/tlg2300/pd-video.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
>> index a794ae6..069db9a 100644
>> --- a/drivers/media/video/tlg2300/pd-video.c
>> +++ b/drivers/media/video/tlg2300/pd-video.c
>> @@ -5,6 +5,7 @@
>>  #include <linux/mm.h>
>>  #include <linux/sched.h>
>>  #include <linux/slab.h>
>> +#include <linux/version.h>
>>
>>  #include <media/v4l2-ioctl.h>
>>  #include <media/v4l2-dev.h>
>
> commit f8bf305b7103857708cd22b504a70ea4a08022fc
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date:   Thu Apr 19 16:35:27 2012 -0300
>
>    tlg2300: Remove usage of KERNEL_VERSION()
>
>    As reported by Marcos:
>
>    On 04-18-2012 01:30, Marcos Paulo de Souza wrote:
>    > The output of "make versioncheck" told us that:
>    >
>    > drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
>    >
>    > If we take a look at the code, we can see that this file uses the macro
>    > KERNEL_VERSION.
>
>    The V4L2 core now fills it automatically, so drivers shouldn't touch on
>    cap->version anymore.
>
>    Reported by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
> index a794ae6..bfbf9e5 100644
> --- a/drivers/media/video/tlg2300/pd-video.c
> +++ b/drivers/media/video/tlg2300/pd-video.c
> @@ -150,7 +150,6 @@ static int vidioc_querycap(struct file *file, void *fh,
>        strcpy(cap->driver, "tele-video");
>        strcpy(cap->card, "Telegent Poseidon");
>        usb_make_path(p->udev, cap->bus_info, sizeof(cap->bus_info));
> -       cap->version = KERNEL_VERSION(0, 0, 1);
>        cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_TUNER |
>                                V4L2_CAP_AUDIO | V4L2_CAP_STREAMING |
>                                V4L2_CAP_READWRITE | V4L2_CAP_VBI_CAPTURE;

thanks a lot.

Huang Shijie