linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: STEricsson_nomadik_linux@list.st.com,
	linus.walleij@stericsson.com, arnd@arndb.de,
	broonie@opensource.wolfsonmicro.com, ola.o.lilja@stericsson.com,
	roger.xr.nilsson@stericsson.com, alsa-devel@alsa-project.org,
	Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 03/17] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
Date: Fri, 24 Aug 2012 15:01:39 +0100	[thread overview]
Message-ID: <1345816913-4113-4-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1345816913-4113-1-git-send-email-lee.jones@linaro.org>

Register both parts of the MSP driver from Device Tree so that they
are probed when Device Tree is enabled. Also, as there is platform
data involved, we ensure that there is allocated memory to place the
configuration into and that the correct information is extracted from
the DT binary.

CC: alsa-devel@alsa-project.org
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 sound/soc/ux500/ux500_msp_dai.c |    6 ++++++
 sound/soc/ux500/ux500_msp_i2s.c |   22 +++++++++++++++++++---
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/sound/soc/ux500/ux500_msp_dai.c b/sound/soc/ux500/ux500_msp_dai.c
index 772cb19..0f7dd49 100644
--- a/sound/soc/ux500/ux500_msp_dai.c
+++ b/sound/soc/ux500/ux500_msp_dai.c
@@ -833,10 +833,16 @@ static int __devexit ux500_msp_drv_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id ux500_msp_i2c_match[] = {
+	{ .compatible = "stericsson,ux500-msp-i2s", },
+	{},
+};
+
 static struct platform_driver msp_i2s_driver = {
 	.driver = {
 		.name = "ux500-msp-i2s",
 		.owner = THIS_MODULE,
+		.of_match_table = ux500_msp_i2c_match,
 	},
 	.probe = ux500_msp_drv_probe,
 	.remove = ux500_msp_drv_remove,
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 08813c5..cb7bdae 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -18,6 +18,7 @@
 #include <linux/pinctrl/consumer.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/of.h>
 
 #include <mach/hardware.h>
 #include <mach/msp.h>
@@ -684,16 +685,31 @@ int ux500_msp_i2s_init_msp(struct platform_device *pdev,
 	int ret = 0;
 	struct resource *res = NULL;
 	struct i2s_controller *i2s_cont;
+	struct device_node *np = pdev->dev.of_node;
 	struct ux500_msp *msp;
 
-	dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__,
-		pdev->name, platform_data->id);
-
 	*msp_p = devm_kzalloc(&pdev->dev, sizeof(struct ux500_msp), GFP_KERNEL);
 	msp = *msp_p;
 	if (!msp)
 		return -ENOMEM;
 
+	if (np) {
+		if (!platform_data) {
+			platform_data = devm_kzalloc(&pdev->dev,
+				sizeof(struct msp_i2s_platform_data), GFP_KERNEL);
+			if (!platform_data)
+				ret = -ENOMEM;
+		}
+	} else
+		if (!platform_data)
+			ret = -EINVAL;
+
+	if (ret)
+		goto err_res;
+
+	dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__,
+		pdev->name, platform_data->id);
+
 	msp->id = platform_data->id;
 	msp->dev = &pdev->dev;
 	msp->dma_cfg_rx = platform_data->msp_i2s_dma_rx;
-- 
1.7.9.5


  parent reply	other threads:[~2012-08-24 14:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24 14:01 [PATCH 00/17] MOP500 Audio fix-ups and DT enablement Lee Jones
2012-08-24 14:01 ` [PATCH 01/17] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Lee Jones
2012-08-30 23:46   ` Linus Walleij
2012-09-10 16:46   ` Lee Jones
2012-09-11  9:28     ` Ola Lilja
2012-08-24 14:01 ` [PATCH 02/17] ASoC: Ux500: Enable MOP500 driver for Device Tree Lee Jones
2012-08-24 14:01 ` Lee Jones [this message]
2012-08-24 14:01 ` [PATCH 04/17] ASoC: codecs: Enable AB8500 CODEC " Lee Jones
2012-08-24 14:01 ` [PATCH 05/17] ASoC: Ux500: Minor coding layout changes Lee Jones
2012-09-10 16:44   ` Lee Jones
2012-09-11  0:27     ` Mark Brown
2012-09-11  9:03     ` Ola Lilja
2012-08-24 14:01 ` [PATCH 06/17] Documentation: Define the MOP500 Audio Machine Driver Device Tree bindings Lee Jones
2012-09-10 16:44   ` Lee Jones
2012-09-11  9:06     ` Ola Lilja
2012-09-11  9:08       ` Mark Brown
2012-09-14 10:02       ` Lee Jones
2012-08-24 14:01 ` [PATCH 07/17] Documentation: Define the MSP " Lee Jones
2012-09-10 16:43   ` Lee Jones
2012-09-11  9:08     ` Ola Lilja
2012-09-14  9:57       ` Lee Jones
2012-08-24 14:01 ` [PATCH 08/17] ARM: ux500: Clean-up MSP platform code Lee Jones
2012-08-24 14:01 ` [PATCH 09/17] ARM: ux500: Add AB8500 CODEC node to DB8500 Device Tree Lee Jones
2012-08-30 23:50   ` Linus Walleij
2012-08-24 14:01 ` [PATCH 10/17] ARM: ux500: Fork MSP platform registration for step-by-step DT enablement Lee Jones
2012-08-24 14:01 ` [PATCH 11/17] ARM: ux500: Pass MSP DMA platform data though AUXDATA Lee Jones
2012-08-24 14:01 ` [PATCH 12/17] ARM: ux500: Stop registering the MOP500 Audio driver from platform code Lee Jones
2012-08-24 14:01 ` [PATCH 13/17] ARM: ux500: Remove platform registration of MSP devices Lee Jones
2012-08-24 14:01 ` [PATCH 14/17] ARM: ux500: Rename MSP board file to something more meaningful Lee Jones
2012-08-24 15:05   ` [alsa-devel] " Hebbar, Gururaja
2012-08-24 15:08     ` Lee Jones
2012-08-24 15:14     ` Lee Jones
2012-08-24 15:16       ` Hebbar, Gururaja
2012-08-24 14:01 ` [PATCH 15/17] ARM: ux500: Add nodes for the MSP into Device Tree Lee Jones
2012-08-24 14:01 ` [PATCH 16/17] ARM: ux500: Add all encompassing sound node to the Snowball " Lee Jones
2012-08-24 14:01 ` [PATCH 17/17] Documentation: Add the AB8500 CODEC device to the MFD AB8500 doc Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345816913-4113-4-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=STEricsson_nomadik_linux@list.st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ola.o.lilja@stericsson.com \
    --cc=roger.xr.nilsson@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).